GNU bug report logs - #69315
[PATCH] Build system fixes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69315 in the body.
You can then email your comments to 69315 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: guile-devel <at> gnu.org, bug-guile <at> gnu.org
Subject: [PATCH] Build system fixes
Date: Thu, 22 Feb 2024 22:14:04 +0100

[Message part 1 (text/plain, inline)]

Dear Guile maintainers,

please find attached two patches for changes that we have been carrying
downstream in LilyPond so far: one fix to make a sed invocation fully
portable, and a fix for cross-compilation in out-of-tree-builds.

Regards
Jonas

[0001-build-Make-sed-invocation-fully-portable.patch (text/x-patch, attachment)]

[0002-build-Fix-cross-compilation-in-out-of-tree-builds.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
To: guile-devel <at> gnu.org, bug-guile <at> gnu.org
Subject: Re: [PATCH] Build system fixes
Date: Wed, 20 Mar 2024 21:14:30 +0100

[Message part 1 (text/plain, inline)]

On Thu, 2024-02-22 at 22:14 +0100, Jonas Hahnfeld via Developers list
for Guile, the GNU extensibility library wrote:
> Dear Guile maintainers,
> 
> please find attached two patches for changes that we have been carrying
> downstream in LilyPond so far: one fix to make a sed invocation fully
> portable, and a fix for cross-compilation in out-of-tree-builds.

ping...

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 69315-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
Cc: 69315-done <at> debbugs.gnu.org, guile-devel <at> gnu.org
Subject: Re: bug#69315: [PATCH] Build system fixes
Date: Mon, 06 May 2024 11:37:13 +0200

Hi Jonas,

Jonas Hahnfeld <hahnjo <at> hahnjo.de> skribis:

> From 428d1b17c5f664d3cb8da4cd5687bd47bdd87877 Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
> Date: Thu, 22 Feb 2024 21:57:41 +0100
> Subject: [PATCH 1/2] build: Make sed invocation fully portable
>
> Commit 08041d216f attempted to make the "invocation compatible with
> BSD sed", but moving '-i' first does not solve the problem because
> it still requires to pass an argument. Instead just redirect the
> instantiated output into a temporary file and install that.
>
> * libguile/Makefile.am: Remove '-i' from INSTANTIATE.

[...]

> From ad01912391b449fcf547ac52ed468f9b572cb0ad Mon Sep 17 00:00:00 2001
> From: Jonas Hahnfeld <hahnjo <at> hahnjo.de>
> Date: Thu, 22 Feb 2024 22:10:06 +0100
> Subject: [PATCH 2/2] build: Fix cross-compilation in out-of-tree-builds
>
> gen-scmconfig.h is generated in libguile, not $(top_builddir).
>
> * libguile/Makefile.am: Add '-I.' when compiling gen-scmconfig.o.

Finally applied both, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.