GNU bug report logs - #69186
[PATCH] Recognize functions and macros as defuns in cmake-ts-mode

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69186: closed ([PATCH] Recognize functions and macros as
 defuns in cmake-ts-mode)
Date: Thu, 22 Feb 2024 13:05:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 22 Feb 2024 15:03:57 +0200
with message-id <861q943b2a.fsf <at> gnu.org>
and subject line Re: bug#69186: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode
has caused the debbugs.gnu.org bug report #69186,
regarding [PATCH] Recognize functions and macros as defuns in cmake-ts-mode
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69186: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69186
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jörg Bornemann <foss <at> jbornemann.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode
Date: Sat, 17 Feb 2024 21:26:58 +0100

[Message part 3 (text/plain, inline)]

Tags: patch


This might exceed the lines of code for the Copyright-paperwork-exempt
marker.  From my side, FSF paperwork is done and my "assignment awaits a
countersignature from the deputy directory" since a while.  In the
meantime, let's have this change reviewed.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-02-16 built on barf
Repository revision: 4b89fb08bdd7d0249698bc0ed578555d6755724d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201009
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-x --with-x-toolkit=gtk3 --with-native-compilation
 --with-imagemagick --with-json --with-sound=alsa --with-mailutils
 --with-file-notification=yes --prefix /home/jobor/dev/emacs-master'

[0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: dev <at> rjt.dev, 69186-done <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Thu, 22 Feb 2024 15:03:57 +0200

> Cc: 69186 <at> debbugs.gnu.org
> Date: Wed, 21 Feb 2024 21:05:59 +0100
> From: Jörg Bornemann <foss <at> jbornemann.de>
> 
> On 2/21/24 04:34, Randy Taylor wrote:
> 
> > Thanks for working on this, it looks good to me.
> 
> Thanks for the review!
> 
> > I have a few small nits:
> [...]
> 
> I've picked the nits and rebased the change.
> And the paperwork is also done from all sides now.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.