GNU bug report logs - #69186
[PATCH] Recognize functions and macros as defuns in cmake-ts-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69186 in the body.
You can then email your comments to 69186 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jörg Bornemann <foss <at> jbornemann.de>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Recognize functions and macros as defuns in cmake-ts-mode
Date: Sat, 17 Feb 2024 21:26:58 +0100

[Message part 1 (text/plain, inline)]

Tags: patch


This might exceed the lines of code for the Copyright-paperwork-exempt
marker.  From my side, FSF paperwork is done and my "assignment awaits a
countersignature from the deputy directory" since a while.  In the
meantime, let's have this change reviewed.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.16.0) of 2024-02-16 built on barf
Repository revision: 4b89fb08bdd7d0249698bc0ed578555d6755724d
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12201009
System Description: Debian GNU/Linux 12 (bookworm)

Configured using:
 'configure --with-x --with-x-toolkit=gtk3 --with-native-compilation
 --with-imagemagick --with-json --with-sound=alsa --with-mailutils
 --with-file-notification=yes --prefix /home/jobor/dev/emacs-master'

[0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.patch (text/patch, attachment)]

Message #8 received at 69186 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: 69186 <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Tue, 20 Feb 2024 16:07:46 +0000

On Saturday, February 17th, 2024 at 15:26, Jörg Bornemann <foss <at> jbornemann.de> wrote:
> 
> 
> Tags: patch
> 
> 
> This might exceed the lines of code for the Copyright-paperwork-exempt
> marker. From my side, FSF paperwork is done and my "assignment awaits a
> countersignature from the deputy directory" since a while. In the
> meantime, let's have this change reviewed.

Thanks, I'll try to take a look later tonight.

Message #11 received at 69186 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: 69186 <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Wed, 21 Feb 2024 03:34:05 +0000

On Saturday, February 17th, 2024 at 15:26, Jörg Bornemann <foss <at> jbornemann.de> wrote:
> 
> 
> Tags: patch
> 
> 
> This might exceed the lines of code for the Copyright-paperwork-exempt
> marker. From my side, FSF paperwork is done and my "assignment awaits a
> countersignature from the deputy directory" since a while. In the
> meantime, let's have this change reviewed.

Thanks for working on this, it looks good to me.

I have a few small nits:
+(defun cmake-ts-mode--defun-name (node)
+  "Return the defun name of NODE.
+Return nil if there is no name or if NODE is not a defun node.  We
+consider CMake functions and macros as defuns."

I would drop the last sentence.

In the commit message:
(cmake-ts-mode): Set up treesit-defun-type-regexp and
treesit-defun-name-function. Change the imenu setup to recognize macros

One more space needed before "Change".

Message #14 received at 69186 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: 69186 <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Wed, 21 Feb 2024 20:53:13 +0000

On Wednesday, February 21st, 2024 at 15:05, Jörg Bornemann <foss <at> jbornemann.de> wrote:
> 
> 
> On 2/21/24 04:34, Randy Taylor wrote:
> 
> > Thanks for working on this, it looks good to me.
> 
> 
> Thanks for the review!
> 
> > I have a few small nits:
> 
> [...]
> 
> I've picked the nits and rebased the change.
> And the paperwork is also done from all sides now.
> 
> 
> Cheers,
> 
> Jörg

Great, thanks!

Can someone install this on master? Thanks in advance.

Message #17 received at 69186 <at> debbugs.gnu.org (full text, mbox):

From: Jörg Bornemann <foss <at> jbornemann.de>
To: Randy Taylor <dev <at> rjt.dev>
Cc: 69186 <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Wed, 21 Feb 2024 21:05:59 +0100

[Message part 1 (text/plain, inline)]

On 2/21/24 04:34, Randy Taylor wrote:

> Thanks for working on this, it looks good to me.

Thanks for the review!

> I have a few small nits:
[...]

I've picked the nits and rebased the change.
And the paperwork is also done from all sides now.


Cheers,

Jörg

[0001-Recognize-functions-and-macros-as-defuns-in-cmake-ts.patch (text/x-patch, attachment)]

Message #22 received at 69186-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: dev <at> rjt.dev, 69186-done <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Thu, 22 Feb 2024 15:03:57 +0200

> Cc: 69186 <at> debbugs.gnu.org
> Date: Wed, 21 Feb 2024 21:05:59 +0100
> From: Jörg Bornemann <foss <at> jbornemann.de>
> 
> On 2/21/24 04:34, Randy Taylor wrote:
> 
> > Thanks for working on this, it looks good to me.
> 
> Thanks for the review!
> 
> > I have a few small nits:
> [...]
> 
> I've picked the nits and rebased the change.
> And the paperwork is also done from all sides now.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.