GNU bug report logs - #69186
[PATCH] Recognize functions and macros as defuns in cmake-ts-mode

Previous Next

Full log

Message #11 received at 69186 <at> debbugs.gnu.org (full text, mbox):

From: Randy Taylor <dev <at> rjt.dev>
To: Jörg Bornemann <foss <at> jbornemann.de>
Cc: 69186 <at> debbugs.gnu.org
Subject: Re: bug#69186: [PATCH] Recognize functions and macros as defuns in
 cmake-ts-mode
Date: Wed, 21 Feb 2024 03:34:05 +0000

On Saturday, February 17th, 2024 at 15:26, Jörg Bornemann <foss <at> jbornemann.de> wrote:
> 
> 
> Tags: patch
> 
> 
> This might exceed the lines of code for the Copyright-paperwork-exempt
> marker. From my side, FSF paperwork is done and my "assignment awaits a
> countersignature from the deputy directory" since a while. In the
> meantime, let's have this change reviewed.

Thanks for working on this, it looks good to me.

I have a few small nits:
+(defun cmake-ts-mode--defun-name (node)
+  "Return the defun name of NODE.
+Return nil if there is no name or if NODE is not a defun node.  We
+consider CMake functions and macros as defuns."

I would drop the last sentence.

In the commit message:
(cmake-ts-mode): Set up treesit-defun-type-regexp and
treesit-defun-name-function. Change the imenu setup to recognize macros

One more space needed before "Change".

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.