GNU bug report logs - #69091
[PATCH 0/1] Adding clojure.java-time

Previous Next

To reply to this bug, email your comments to 69091 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: guix-patches <at> gnu.org
Cc: Steve George <steve <at> futurile.net>
Subject: [PATCH 0/1] Adding clojure.java-time
Date: Mon, 12 Feb 2024 22:18:29 +0000

Investigating adding Clojure libs. Clojure.java-time is a common basic wrapped
Java lib.

Steve George (1):
  gnu: Add clojure.java-time.

 gnu/packages/clojure.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)


base-commit: b64862e5cb8209c92aa2eff4cec0be328e38c45d
-- 
2.41.0

Message #8 received at 69091 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 69091 <at> debbugs.gnu.org
Cc: Steve George <steve <at> futurile.net>
Subject: [PATCH 1/1] gnu: Add clojure.java-time.
Date: Tue, 13 Feb 2024 08:44:51 +0000

* gnu/packages/clojure.scm (clojure.java-time): New variable.

Change-Id: Id76d3e073525bff619fddb92096ec99a3917faeb
---
 gnu/packages/clojure.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 27fce6f368e..f7c5530e35a 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -661,3 +661,28 @@ (define-public clojure-tools-gitlibs
 indicated by git SHAs.  This library provides this functionality and also
 keeps a cache of git directories and working trees that can be reused.")
     (license license:epl1.0)))
+
+(define-public clojure.java-time
+  (package
+    (name "clojure.java-time")
+    (version "1.4.2")
+    (home-page "https://github.com/dm3/clojure.java-time")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url home-page)
+                     (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                  "0rykvgslxaxw6qc1lpv21299d9kx3waj34wi1jvzqlnbs2x1p9fh"))))
+    (build-system clojure-build-system)
+    (arguments
+     `(#:tests? #f  ;;FIXME: tests requires math.combinatorics dependency
+       #:doc-dirs '("docs")
+       #:aot-exclude '(#:all)))
+    (synopsis "A Clojure wrapper for Java's @code{java.time} API.")
+    (description "This library wraps Java's @code{java.time} API.  It provides
+a set of Clojure functions for dealing with Date-Time without requiring any
+additional packages.")
+    (license license:epl1.0)))

base-commit: b64862e5cb8209c92aa2eff4cec0be328e38c45d
-- 
2.41.0

Message #11 received at 69091 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: 69091 <at> debbugs.gnu.org
Cc: guix-patches <at> gnu.org, Steve George <steve <at> futurile.net>
Subject: [PATCH v2 1/1] gnu: Add clojure.java-time.
Date: Wed, 14 Feb 2024 08:57:02 +0000

* gnu/packages/clojure.scm (clojure.java-time): New variable.

Change-Id: Id76d3e073525bff619fddb92096ec99a3917faeb
---
 gnu/packages/clojure.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/clojure.scm b/gnu/packages/clojure.scm
index 27fce6f368e..f7c5530e35a 100644
--- a/gnu/packages/clojure.scm
+++ b/gnu/packages/clojure.scm
@@ -661,3 +661,28 @@ (define-public clojure-tools-gitlibs
 indicated by git SHAs.  This library provides this functionality and also
 keeps a cache of git directories and working trees that can be reused.")
     (license license:epl1.0)))
+
+(define-public clojure.java-time
+  (package
+    (name "clojure.java-time")
+    (version "1.4.2")
+    (home-page "https://github.com/dm3/clojure.java-time")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                     (url home-page)
+                     (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+                (base32
+                  "0rykvgslxaxw6qc1lpv21299d9kx3waj34wi1jvzqlnbs2x1p9fh"))))
+    (build-system clojure-build-system)
+    (arguments
+     `(#:tests? #f  ;;FIXME: tests requires math.combinatorics dependency
+       #:doc-dirs '("docs")
+       #:aot-exclude '(#:all)))
+    (synopsis "A Clojure wrapper for Java's @code{java.time} API.")
+    (description "This library wraps Java's @code{java.time} API.  It provides
+a set of Clojure functions for dealing with Date-Time without requiring any
+additional packages.")
+    (license license:epl1.0)))

base-commit: b64862e5cb8209c92aa2eff4cec0be328e38c45d
-- 
2.41.0

Message #14 received at 69091 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Enge <andreas <at> enge.fr>
To: 69091 <at> debbugs.gnu.org
Subject: Package name
Date: Fri, 16 Feb 2024 11:06:05 +0100

Hello,

according to our naming convention
   https://guix.gnu.org/de/manual/devel/en/html_node/Package-Naming.html
   https://guix.gnu.org/de/manual/devel/en/html_node/Python-Modules.html
I think the package should be called clojure-java-time (well, this is not
spelt out precisely, but we could argue by analogy, and by consistency with
the existing clojure packages).

I know nothing about clojure, but am wondering about two things:
- There is one other package with #:aot-exclude '(#:all), which gives
  an explanation why the line is there; could you add one here as well?
- Would it make sense to package math.combinatorics first to enable the
  tests? If we do not test now, I am afraid we will forget it later...

Andreas

Message #19 received at 69091 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Steve George <steve <at> futurile.net>
Cc: 69091 <at> debbugs.gnu.org, Andreas Enge <andreas <at> enge.fr>,
 69119 <at> debbugs.gnu.org
Subject: Re: bug#69119: [PATCH v2 1/1] gnu: Add clojure.java-time.
Date: Sat, 02 Mar 2024 17:17:31 +0100

Hi Steve,

Did you have a chance to look into Andreas’ comments about this patch?

  https://issues.guix.gnu.org/69119

Ludo’.

Andreas Enge <andreas <at> enge.fr> skribis:

> Hello,
>
> according to our naming convention
>    https://guix.gnu.org/de/manual/devel/en/html_node/Package-Naming.html
>    https://guix.gnu.org/de/manual/devel/en/html_node/Python-Modules.html
> I think the package should be called clojure-java-time (well, this is not
> spelt out precisely, but we could argue by analogy, and by consistency with
> the existing clojure packages).
>
> I know nothing about clojure, but am wondering about two things:
> - There is one other package with #:aot-exclude '(#:all), which gives
>   an explanation why the line is there; could you add one here as well?
> - Would it make sense to package math.combinatorics first to enable the
>   tests? If we do not test now, I am afraid we will forget it later...
>
> Andreas

Message #22 received at 69091 <at> debbugs.gnu.org (full text, mbox):

From: Steve George <steve <at> futurile.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 69091 <at> debbugs.gnu.org, Andreas Enge <andreas <at> enge.fr>,
 69119 <at> debbugs.gnu.org
Subject: Re: bug#69119: [PATCH v2 1/1] gnu: Add clojure.java-time.
Date: Sun, 3 Mar 2024 16:45:10 +0000

Hi Ludo,

I got blocked as this patch caused me to look at whether we should be compiling to byte-code by default. I have not been able to achieve consensus so far (and have taken some time off from the thread):

https://lists.gnu.org/archive/html/guix-devel/2024-02/msg00241.html

Having been unable to convince others I also asked the Clojure community:

https://clojureverse.org/t/should-linux-distributions-ship-clojure-byte-compiled-aot-or-not/10595

Their perspective is that:

a. We should not byte-code compile libraries (what Clojure calls AOT), but we could do so for tools/apps.
b. We should not package libraries at all

From both interactions I'm unsure if packaging this (or any other Clojure libs/tools) is the right move. 

Steve

On  2 Mar, Ludovic Courtès wrote:
> Hi Steve,
> 
> Did you have a chance to look into Andreas’ comments about this patch?
> 
>   https://issues.guix.gnu.org/69119
> 
> Ludo’.
> 
> Andreas Enge <andreas <at> enge.fr> skribis:
> 
> > Hello,
> >
> > according to our naming convention
> >    https://guix.gnu.org/de/manual/devel/en/html_node/Package-Naming.html
> >    https://guix.gnu.org/de/manual/devel/en/html_node/Python-Modules.html
> > I think the package should be called clojure-java-time (well, this is not
> > spelt out precisely, but we could argue by analogy, and by consistency with
> > the existing clojure packages).
> >
> > I know nothing about clojure, but am wondering about two things:
> > - There is one other package with #:aot-exclude '(#:all), which gives
> >   an explanation why the line is there; could you add one here as well?
> > - Would it make sense to package math.combinatorics first to enable the
> >   tests? If we do not test now, I am afraid we will forget it later...
> >
> > Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.