GNU bug report logs - #69068
[PATCH] gnu: kitsas: Update to 5.4.1

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Enge <andreas <at> enge.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#69068: closed ([PATCH] gnu: kitsas: Update to 5.4.1)
Date: Wed, 28 Feb 2024 15:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 28 Feb 2024 16:36:04 +0100
with message-id <Zd9S5HI-ncoPyHbz <at> jurong>
and subject line Re: [bug#69068] To test or not to test?
has caused the debbugs.gnu.org bug report #69068,
regarding [PATCH] gnu: kitsas: Update to 5.4.1
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
69068: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69068
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Saku Laesvuori <saku <at> laesvuori.fi>
To: guix-patches <at> gnu.org
Cc: Saku Laesvuori <saku <at> laesvuori.fi>
Subject: [PATCH] gnu: kitsas: Update to 5.4.1
Date: Mon, 12 Feb 2024 09:03:57 +0200

* gnu/packages/finance.scm (kitsas): Update to 5.4.1.

Change-Id: I968579d762ebecef9f9e8b602682587a054c41ad
---
 gnu/packages/finance.scm | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/finance.scm b/gnu/packages/finance.scm
index 98a220385b..96e2729dda 100644
--- a/gnu/packages/finance.scm
+++ b/gnu/packages/finance.scm
@@ -1307,7 +1307,7 @@ (define-public keepkey-agent
 (define-public kitsas
   (package
     (name "kitsas")
-    (version "4.0.3")
+    (version "5.4.1")
     (source (origin
               (method git-fetch)
               (uri (git-reference
@@ -1316,17 +1316,24 @@ (define-public kitsas
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0hrbsqqm6v2pmjq17s7i4akjgclz3d051mg02vcykq80xgxvbkgf"))))
+                "16zkfpl5d9ia202fqg5vrhjqdw0g6wp044ih6n7nz2hbxj9y3m1z"))))
     (build-system qt-build-system)
-    (inputs (list qtbase-5 libzip poppler-qt5 qtsvg-5))
+    (inputs (list libzip qtsvg qtwebengine qt5compat))
     (arguments
      (list #:tests? #f               ;XXX: some tests fail and others segfault
            #:test-target "check"
+           #:qtbase qtbase
            #:phases
            #~(modify-phases %standard-phases
                (replace 'configure
                  (lambda* _
                    (invoke "qmake" "kitsasproject.pro" "CONFIG+=release")))
+               ;; The tests are not maintained and some don't even build
+               (add-before 'configure 'disable-broken-tests
+                 (lambda _
+                   (substitute* "kitsasproject.pro"
+                     ((" *(unittest|testit).*") "")
+                     (("\\\\") ""))))
                (replace 'install
                  (lambda* _
                    (install-file "kitsas/kitsas"

base-commit: f2102cb5b9239be2ed2023b908b726af542e0124
-- 
2.41.0

[Message part 3 (message/rfc822, inline)]

From: Andreas Enge <andreas <at> enge.fr>
To: Saku Laesvuori <saku <at> laesvuori.fi>
Cc: 69068-done <at> debbugs.gnu.org
Subject: Re: [bug#69068] To test or not to test?
Date: Wed, 28 Feb 2024 16:36:04 +0100

Am Wed, Feb 28, 2024 at 01:49:22PM +0100 schrieb Andreas Enge:
> Sorry, I see that you already answered this question before. I will
> prepare to push.

Following the rust team merge, I wanted to rebuild the package once more,
which succeeded. Pushed, thanks for your patience!

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.