GNU bug report logs -
#69069
14.0.2; table alignment by align-current gives wrong result
Previous Next
Reported by: Uwe Siart <uwe.siart <at> tum.de>
Date: Mon, 12 Feb 2024 07:33:02 UTC
Severity: normal
Found in version 14.0.2
Done: Ikumi Keita <ikumi <at> ikumi.que.jp>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69069 in the body.
You can then email your comments to 69069 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Mon, 12 Feb 2024 07:33:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Uwe Siart <uwe.siart <at> tum.de>
:
New bug report received and forwarded. Copy sent to
bug-auctex <at> gnu.org
.
(Mon, 12 Feb 2024 07:33:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
When I do 'M-x align-current' on
,----
| Mat.-Nr. & Nachname & Vorname & Unterschrift \\
| Mat. No. & Surname & Name & Signature \\
`----
(which would be the expected result, so align-current should do nothing
here) I get
,----
| Mat.-Nr. & Nachname & Vorname & Unterschrift \\
| Mat. No. & Surname & Name & Signature \\
`----
instead. It seems like align-current gets confused by whitespace inside
cell content.
--
Uwe
Emacs : GNU Emacs 29.2 (build 2, x86_64-w64-mingw32)
of 2024-01-18
Package: 14.0.2
current state:
==============
(setq
AUCTeX-date "2024-02-09"
window-system 'w32
LaTeX-version "2e"
TeX-style-path '("~/.emacs.d/auctex" "c:/Users/siart/.emacs.d/elpa/auctex-14.0.2/style"
"c:/Users/siart/.emacs.d/auctex/auto" "c:/Users/siart/.emacs.d/auctex/style" "auto" "style")
TeX-auto-save t
TeX-parse-self t
TeX-master t
TeX-command-list '(("TeX" "%(PDF)%(tex) %(file-line-error) %`%(extraopts) %S%(PDFout)%(mode)%' %(output-dir) %t"
TeX-run-TeX nil (plain-tex-mode texinfo-mode ams-tex-mode) :help "Run plain TeX")
("LaTeX" "%`%l%(mode)%' %T" TeX-run-TeX nil (latex-mode doctex-mode) :help "Run LaTeX")
("Makeinfo" "makeinfo %(extraopts) %(o-dir) %t" TeX-run-compile nil (texinfo-mode) :help
"Run Makeinfo with Info output")
("Makeinfo HTML" "makeinfo %(extraopts) %(o-dir) --html %t" TeX-run-compile nil (texinfo-mode)
:help "Run Makeinfo with HTML output")
("AmSTeX" "amstex %(PDFout) %`%(extraopts) %S%(mode)%' %(output-dir) %t" TeX-run-TeX nil
(ams-tex-mode) :help "Run AMSTeX")
("ConTeXt" "%(cntxcom) --once --texutil %(extraopts) %(execopts)%t" TeX-run-TeX nil (context-mode)
:help "Run ConTeXt once")
("ConTeXt Full" "%(cntxcom) %(extraopts) %(execopts)%t" TeX-run-TeX nil (context-mode) :help
"Run ConTeXt until completion")
("BibTeX" "bibtex %(O?aux)" TeX-run-BibTeX nil
(plain-tex-mode latex-mode doctex-mode context-mode texinfo-mode ams-tex-mode) :help "Run BibTeX")
("Biber" "biber %s %(output-dir)" TeX-run-Biber nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help "Run Biber")
("View" "%V" TeX-run-discard-or-function t t :help "Run Viewer")
("Print" "%p" TeX-run-command t t :help "Print the file")
("Queue" "%q" TeX-run-background nil t :help "View the printer queue" :visible TeX-queue-command)
("File" "%(o?)dvips %d -landscaperotate -Ppdf -j0 -o %f " TeX-run-dvips t
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Generate PostScript file")
("Dvips" "%(o?)dvips %d -landscaperotate -Ppdf -j0 -o %f " TeX-run-dvips nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Convert DVI file to PostScript")
("Dvipdfmx" "dvipdfmx %d -o %(O?pdf)" TeX-run-dvipdfmx nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Convert DVI file to PDF with dvipdfmx")
("Ps2pdf" "ps2pdf -dALLOWPSTRANSPARENCY %f %(O?pdf)" TeX-run-ps2pdf nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Convert PostScript file to PDF")
("Glossaries" "makeglossaries %(O?aux)" TeX-run-command nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Run makeglossaries to create glossary\n file")
("Index" "makeindex %(O?idx)" TeX-run-index nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Run makeindex to create index file")
("upMendex" "upmendex %(O?idx)" TeX-run-index t
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Run upmendex to create index file")
("Xindy" "texindy %s" TeX-run-command nil
(plain-tex-mode latex-mode doctex-mode texinfo-mode ams-tex-mode) :help
"Run xindy to create index file")
("Check" "lacheck %s" TeX-run-compile nil (latex-mode) :help "Check LaTeX file for correctness")
("ChkTeX" "chktex -v6 %s" TeX-run-compile nil (latex-mode) :help
"Check LaTeX file for common mistakes")
("Spell" "(TeX-ispell-document \"\")" TeX-run-function nil t :help "Spell-check the document")
("Clean" "TeX-clean" TeX-run-function nil t :help "Delete generated intermediate files")
("Clean All" "(TeX-clean t)" TeX-run-function nil t :help
"Delete generated intermediate and output files")
("Other" "" TeX-run-command t t :help "Run an arbitrary command"))
)
--
Dr.-Ing.
Uwe Siart
Technical University of Munich
TUM School of Computation, Information and Technology
Department of Electrical Engineering
Chair of High-Frequency Engineering
Arcisstraße 21
80333 Munich, Germany
Tel. +49 89 289 23374
Fax +49 89 289 23365
uwe.siart <at> tum.de
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Mon, 12 Feb 2024 08:10:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Hi Uwe,
>>>>> Uwe Siart <uwe.siart <at> tum.de> writes:
> When I do 'M-x align-current' on
> ,----
> | Mat.-Nr. & Nachname & Vorname & Unterschrift \\
> | Mat. No. & Surname & Name & Signature \\
> `----
> (which would be the expected result, so align-current should do nothing
> here) I get
> ,----
> | Mat.-Nr. & Nachname & Vorname & Unterschrift \\
> | Mat. No. & Surname & Name & Signature \\
> `----
> instead. It seems like align-current gets confused by whitespace inside
> cell content.
Looking at align.el, there are several reference on lower case mode
names:
----------------------------------------------------------------------
(defcustom align-tex-modes
'(tex-mode plain-tex-mode latex-mode slitex-mode)
"A list of modes whose syntax resembles TeX (and family)."
:type '(repeat symbol)
:group 'align)
[...]
(defcustom align-rules-list
[...]
(tex-tabbing-separator
(regexp . ,(lambda (end reverse)
(align-match-tex-pattern "\\\\[=>]" end reverse)))
(group . (1 2))
(modes . align-tex-modes)
(repeat . t)
(run-if . ,(lambda ()
(eq major-mode 'latex-mode))))
[...]
----------------------------------------------------------------------
For the time being, please change the value of these customize options.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Mon, 12 Feb 2024 08:56:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 69069 <at> debbugs.gnu.org (full text, mbox):
On 12 Feb 2024 at 17:08, Ikumi Keita wrote:
> For the time being, please change the value of these customize options.
Thanks, Keita. I've added TeX-mode and LaTeX-mode to the variable
align-tex-modes and that helped.
Beste regards, Uwe
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Mon, 12 Feb 2024 14:17:02 GMT)
Full text and
rfc822 format available.
Message #14 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Hi Uwe,
>>>>> "Uwe Siart" <uwe.siart <at> tum.de> writes:
> Thanks, Keita. I've added TeX-mode and LaTeX-mode to the variable
> align-tex-modes and that helped.
Thanks for reporting back. I'll close this bug.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
bug closed, send any further explanations to
69069 <at> debbugs.gnu.org and Uwe Siart <uwe.siart <at> tum.de>
Request was from
Ikumi Keita <ikumi <at> ikumi.que.jp>
to
control <at> debbugs.gnu.org
.
(Mon, 12 Feb 2024 14:18:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 13 Feb 2024 15:09:02 GMT)
Full text and
rfc822 format available.
Message #19 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
>> Thanks, Keita. I've added TeX-mode and LaTeX-mode to the variable
>> align-tex-modes and that helped.
>
> Thanks for reporting back. I'll close this bug.
Shouldn't we do that change in Emacs itself, too? If so, I'd bring up
the topic on emacs-devel in order to ask in which branch to do it (28,
29, master).
Bye,
Tassilo
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 13 Feb 2024 16:50:01 GMT)
Full text and
rfc822 format available.
Message #22 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Hi Tassilo,
>>>>> Tassilo Horn <tsdh <at> gnu.org> writes:
> Shouldn't we do that change in Emacs itself, too? If so, I'd bring up
> the topic on emacs-devel in order to ask in which branch to do it (28,
> 29, master).
After my further survey, I came to think that AUCTeX should (and can)
fix this issue without change to emacs core. If my thought is correct,
emacs 30 works without any problem currently.
The point is that AUCTeX should extend this follow-up on
`derived-mode-p' to `provided-mode-derived-p'. I'll explain the detail
in a few days.
--- tex.el -----------------------------------------------------------
;; COMPATIBILITY for Emacs<30
(unless (fboundp 'derived-mode-add-parents)
(advice-add 'derived-mode-p :after-until
;; Don't quote by #'-style to avoid compiler warning.
'TeX--compat-derived-mode-p)
(defun TeX--compat-derived-mode-p (&rest modes)
"Add pseudo-parents facility to `derived-mode-p' like Emacs 30.
Modes registered in `derived-mode-extra-parents' property of the
current major mode name symbol are regarded as parent modes as
long as `derived-mode-p' is concerned."
(let ((extra-parents (get major-mode 'derived-mode-extra-parents)))
(and extra-parents
(cl-loop for parent in extra-parents
thereis (memq parent modes))))))
----------------------------------------------------------------------
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Thu, 15 Feb 2024 07:38:02 GMT)
Full text and
rfc822 format available.
Message #25 received at 69069 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
>>>>> Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
> The point is that AUCTeX should extend this follow-up on
> `derived-mode-p' to `provided-mode-derived-p'. I'll explain the detail
> in a few days.
Here we go.
1. In my feature branch and current AUCTeX, I added pseudo-parent mode
facility[1][2] like emacs 30 in order to have compatibility with
directory local variable entry prepared for former mode names like
`latex-mode'.
2. That facility only concerns for `derived-mode-p' and doesn't tweak
`provided-mode-derived-p'. However, the `run-if' property of
`text-colum' entry in `align-rules-list'[3] uses
`provided-mode-derived-p'. This discrepancy calls for a spurious
alignment is in `LaTeX-mode' because it isn't considered as derived
from modes listed in `align-tex-modes'
3. This spurious alignment doen't occur in emacs 30 since it overhauls
`provided-mode-derived-p' in depth.
4. The attached patch improves the pseudo-parent mode facility to cover
`provided-mode-derived-p' as well, and fix this bug.
5. The entry `tex-tabbing-separator' in `align-rules-list'[4] has to be
fixed because its `run-if' property contains conditional with repect
to the major mode without `derived-mode-p' nor
`provided-mode-derived-p'. I'll file a bug report for this.
[1] `TeX-derived-mode-add-parents'
[2] advice for `derived-mode-p' by `TeX--compat-derived-mode-p'
[3]-------------------------------------------------------------------
;; Align space delimited text as columns.
(text-column
(regexp . "\\(^\\|\\S-\\)\\([ \t]+\\)\\(\\S-\\|$\\)")
(group . 2)
(modes . align-text-modes)
(repeat . t)
(run-if . ,(lambda ()
(and (not (eq '- current-prefix-arg))
(not (apply #'provided-mode-derived-p
major-mode align-tex-modes))))))
----------------------------------------------------------------------
[4]-------------------------------------------------------------------
(tex-tabbing-separator
(regexp . ,(lambda (end reverse)
(align-match-tex-pattern "\\\\[=>]" end reverse)))
(group . (1 2))
(modes . align-tex-modes)
(repeat . t)
(run-if . ,(lambda ()
(eq major-mode 'latex-mode))))
----------------------------------------------------------------------
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
[diff (text/x-diff, attachment)]
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Fri, 16 Feb 2024 14:33:02 GMT)
Full text and
rfc822 format available.
Message #28 received at 69069 <at> debbugs.gnu.org (full text, mbox):
> 4. The attached patch improves the pseudo-parent mode facility to cover
> `provided-mode-derived-p' as well, and fix this bug.
I pushed a slightly enhanced fix to the git repo. I'm closing this bug.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 06:13:01 GMT)
Full text and
rfc822 format available.
Message #31 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
>> 4. The attached patch improves the pseudo-parent mode facility to cover
>> `provided-mode-derived-p' as well, and fix this bug.
>
> I pushed a slightly enhanced fix to the git repo. I'm closing this bug.
Thanks, Keita. Just tell me when you think it's time for a new ELPA
release. I've just merged from master without bumping the version
header, so your changes will be tested by users who use auctex from the
ELPA-devel archive (like Uwe), soon.
Bye,
Tassilo
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 07:21:02 GMT)
Full text and
rfc822 format available.
Message #34 received at 69069 <at> debbugs.gnu.org (full text, mbox):
On 20 Feb 2024 at 7:12, Tassilo Horn wrote:
> Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
>
> >> 4. The attached patch improves the pseudo-parent mode facility to cover
> >> `provided-mode-derived-p' as well, and fix this bug.
> >
> > I pushed a slightly enhanced fix to the git repo. I'm closing this bug.
>
> Thanks, Keita. Just tell me when you think it's time for a new ELPA
> release. I've just merged from master without bumping the version
> header, so your changes will be tested by users who use auctex from the
> ELPA-devel archive (like Uwe), soon.
As a quick fix I've added plain-TeX-mode and LaTeX-mode to
align-tex-modes, like Keita suggested.
Should I remove these customizations for testing the next ELPA release?
Regards, Uwe
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 10:35:01 GMT)
Full text and
rfc822 format available.
Message #37 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Hi Tassilo,
>>>>> Tassilo Horn <tsdh <at> gnu.org> writes:
> Thanks, Keita. Just tell me when you think it's time for a new ELPA
> release. I've just merged from master without bumping the version
> header, so your changes will be tested by users who use auctex from the
> ELPA-devel archive (like Uwe), soon.
Thank you, Tassilo. Then I think it's appropriate to make a new ELPA
release now.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 10:42:01 GMT)
Full text and
rfc822 format available.
Message #40 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Hi Uwe,
>>>>> "Uwe Siart" <uwe.siart <at> tum.de> writes:
> As a quick fix I've added plain-TeX-mode and LaTeX-mode to
> align-tex-modes, like Keita suggested.
> Should I remove these customizations for testing the next ELPA release?
That depends on your objective. Those additions won't break with the next
ELPA release. In that sense, you don't have to remove them. On the other
hand, if you want to know whether it works or not without the addition
to `align-tex-modes', you should remove them.
Regards,
Ikumi Keita
#StandWithUkraine #StopWarInUkraine
#Gaza #StopMassiveKilling #CeasefireNOW
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 14:15:01 GMT)
Full text and
rfc822 format available.
Message #43 received at 69069 <at> debbugs.gnu.org (full text, mbox):
Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
>> Should I remove these customizations for testing the next ELPA
>> release?
>
> That depends on your objective. Those additions won't break with the
> next ELPA release. In that sense, you don't have to remove them. On
> the other hand, if you want to know whether it works or not without
> the addition to `align-tex-modes', you should remove them.
Given that Uwe uses the ELPA-devel archive, I'm pretty confident he'll
try the latter and report back. If it works, I'll do a regular ELPA
release afterwards.
I'll do merges without version bump more frequently in the future so
that capable volunteers like Uwe give the devel package some love before
shipping a regular release to the masses. That's my takeaway from the
bumpy 14.0.0 release process. :-)
Bye,
Tassilo
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 14:48:01 GMT)
Full text and
rfc822 format available.
Message #46 received at 69069 <at> debbugs.gnu.org (full text, mbox):
On 20 Feb 2024 at 15:13, Tassilo Horn wrote:
> Ikumi Keita <ikumi <at> ikumi.que.jp> writes:
>
> >> Should I remove these customizations for testing the next ELPA
> >> release?
> >
> > That depends on your objective. Those additions won't break with the
> > next ELPA release. In that sense, you don't have to remove them. On
> > the other hand, if you want to know whether it works or not without
> > the addition to `align-tex-modes', you should remove them.
>
> Given that Uwe uses the ELPA-devel archive, I'm pretty confident he'll
> try the latter and report back. If it works, I'll do a regular ELPA
> release afterwards.
Just installed from elpa-devel and it looks good at a first glance.
I tried first with my customization which looked like
...
'(align-tex-modes
'(tex-mode plain-tex-mode latex-mode slitex-mode plain-TeX-mode LaTeX-mode))
...
in .emacs. With this 'align-current' worked like expected. Then I
removed that part from .emacs to have 'align-tex-modes' in its default
state again, and still 'align-current' does a perfect job.
Uwe
Information forwarded
to
bug-auctex <at> gnu.org
:
bug#69069
; Package
auctex
.
(Tue, 20 Feb 2024 16:09:01 GMT)
Full text and
rfc822 format available.
Message #49 received at 69069 <at> debbugs.gnu.org (full text, mbox):
"Uwe Siart" <uwe.siart <at> tum.de> writes:
Hi Uwe,
>> Given that Uwe uses the ELPA-devel archive, I'm pretty confident
>> he'll try the latter and report back. If it works, I'll do a regular
>> ELPA release afterwards.
>
> Just installed from elpa-devel and it looks good at a first glance.
>
> I tried first with my customization which looked like
>
> ...
> '(align-tex-modes
> '(tex-mode plain-tex-mode latex-mode slitex-mode plain-TeX-mode LaTeX-mode))
> ...
>
> in .emacs. With this 'align-current' worked like expected. Then I
> removed that part from .emacs to have 'align-tex-modes' in its default
> state again, and still 'align-current' does a perfect job.
Perfect, thanks for testing. I've triggered the release of 14.0.3 on
ELPA.
Bye,
Tassilo
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 20 Mar 2024 11:24:10 GMT)
Full text and
rfc822 format available.
This bug report was last modified 1 year and 94 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.