GNU bug report logs - #69068
[PATCH] gnu: kitsas: Update to 5.4.1

Previous Next

Full log

View this message in rfc822 format

From: Andreas Enge <andreas <at> enge.fr>
To: Saku Laesvuori <saku <at> laesvuori.fi>
Cc: 69068 <at> debbugs.gnu.org
Subject: [bug#69068] To test or not to test?
Date: Wed, 28 Feb 2024 13:36:54 +0100

Am Wed, Feb 28, 2024 at 01:47:47PM +0200 schrieb Saku Laesvuori:
> I don't believe any of them even compile with Qt6. The test suite has
> been unmaintained for years, so it doesn't really tell anything about
> whether the program works correctly or not.

Sorry for not being more precise:

I am wondering if this part of the patch:
+               ;; The tests are not maintained and some don't even build
+               (add-before 'configure 'disable-broken-tests
+                 (lambda _
+                   (substitute* "kitsasproject.pro"
+                     ((" *(unittest|testit).*") "")
+                     (("\\\\") ""))))

is of interest given that there already is
      (list #:tests? #f               ;XXX: some tests fail and others segfault
            #:test-target "check"

?

Andreas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.