GNU bug report logs - #69024
[PATCH] Breaking change in tree-sitter-typescript/tsx starting version 0.20.4

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 69024 in the body.
You can then email your comments to 69024 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Loïc Lemaître <loic.lemaitre <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Breaking change in tree-sitter-typescript/tsx starting
 version 0.20.4
Date: Sun, 11 Feb 2024 00:38:43 +0100

[Message part 1 (text/plain, inline)]

Hi,

A similar patch is also needed for Typescript/TSX in relation to this 
closed bug in Javascript :
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68879

The attached patch should do the job.

Thank you in advance.

Loïc Lemaître

[0001-Handle-tree-sitter-grammar-breaking-change-for-funct.patch (text/x-patch, attachment)]

Message #8 received at 69024 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Loïc Lemaître <loic.lemaitre <at> gmail.com>,
 69024 <at> debbugs.gnu.org
Subject: Re: bug#69024: [PATCH] Breaking change in tree-sitter-typescript/tsx
 starting version 0.20.4
Date: Sun, 11 Feb 2024 05:02:17 +0200

Hi!

On 11/02/2024 01:38, Loïc Lemaître wrote:
> A similar patch is also needed for Typescript/TSX in relation to this 
> closed bug in Javascript :
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68879
> 
> The attached patch should do the job.

Thanks for the patch! Pushed to emacs-29.

It probably doesn't exhaust our capability to accept your patches 
without copyright assignment, but it would help if you can get started 
on it, to contribute more in the future.

Message #11 received at 69024 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dmitry <at> gutov.dev>
Cc: 69024 <at> debbugs.gnu.org, loic.lemaitre <at> gmail.com
Subject: Re: bug#69024: [PATCH] Breaking change in tree-sitter-typescript/tsx
 starting version 0.20.4
Date: Sun, 11 Feb 2024 08:50:45 +0200

> Date: Sun, 11 Feb 2024 05:02:17 +0200
> From: Dmitry Gutov <dmitry <at> gutov.dev>
> 
> On 11/02/2024 01:38, Loïc Lemaître wrote:
> > A similar patch is also needed for Typescript/TSX in relation to this 
> > closed bug in Javascript :
> > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68879
> > 
> > The attached patch should do the job.
> 
> Thanks for the patch! Pushed to emacs-29.

Should this bug be closed now?

And what about bug#68924 -- does this solve that one as well?

Message #16 received at 69024 <at> debbugs.gnu.org (full text, mbox):

From: Loïc Lemaître <loic.lemaitre <at> gmail.com>
To: Dmitry Gutov <dmitry <at> gutov.dev>, 69024 <at> debbugs.gnu.org
Subject: Re: bug#69024: [PATCH] Breaking change in tree-sitter-typescript/tsx
 starting version 0.20.4
Date: Sun, 11 Feb 2024 11:37:29 +0100

[Message part 1 (text/plain, inline)]

Thanks !

For the copyright assignment, I have read this page 
https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html 
and I guess I should contact emacs-devel <at> gnu.org 
<mailto:emacs-devel <at> gnu.org> to better understand what is the process to 
get it.

Le 11/02/2024 à 04:02, Dmitry Gutov a écrit :
> Hi!
>
> On 11/02/2024 01:38, Loïc Lemaître wrote:
>> A similar patch is also needed for Typescript/TSX in relation to this 
>> closed bug in Javascript :
>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68879
>>
>> The attached patch should do the job.
>
> Thanks for the patch! Pushed to emacs-29.
>
> It probably doesn't exhaust our capability to accept your patches 
> without copyright assignment, but it would help if you can get started 
> on it, to contribute more in the future.

[Message part 2 (text/html, inline)]

Message #19 received at 69024 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Loïc Lemaître <loic.lemaitre <at> gmail.com>
Cc: 69024 <at> debbugs.gnu.org, dmitry <at> gutov.dev
Subject: Re: bug#69024: [PATCH] Breaking change in tree-sitter-typescript/tsx
 starting version 0.20.4
Date: Sun, 11 Feb 2024 13:38:54 +0200

> Date: Sun, 11 Feb 2024 11:37:29 +0100
> From: Loïc Lemaître
>  <loic.lemaitre <at> gmail.com>
> 
> For the copyright assignment, I have read this page
> https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html and I guess I
> should contact emacs-devel <at> gnu.org to better understand what is the process to get it.

No need, I've sent the form off-list.

Thanks.

Message #24 received at 69024-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dmitry <at> gutov.dev>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 69024-done <at> debbugs.gnu.org, loic.lemaitre <at> gmail.com
Subject: Re: bug#69024: [PATCH] Breaking change in tree-sitter-typescript/tsx
 starting version 0.20.4
Date: Sun, 11 Feb 2024 14:27:46 +0200

On 11/02/2024 08:50, Eli Zaretskii wrote:
>> Date: Sun, 11 Feb 2024 05:02:17 +0200
>> From: Dmitry Gutov<dmitry <at> gutov.dev>
>>
>> On 11/02/2024 01:38, Loïc Lemaître wrote:
>>> A similar patch is also needed for Typescript/TSX in relation to this
>>> closed bug in Javascript :
>>> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68879
>>>
>>> The attached patch should do the job.
>> Thanks for the patch! Pushed to emacs-29.
> Should this bug be closed now?
> 
> And what about bug#68924 -- does this solve that one as well?

Yep, closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.