GNU bug report logs - #68981
[PATCH] Add support for deriving major modes in which-func

Previous Next

Package: emacs;

Reported by: Damien Cassou <damien <at> cassou.me>

Date: Wed, 7 Feb 2024 19:53:01 UTC

Severity: normal

Tags: patch

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #10 received at 68981-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Damien Cassou <damien <at> cassou.me>, 68981-done <at> debbugs.gnu.org
Subject: Re: bug#68981: [PATCH] Add support for deriving major modes in
 which-func
Date: Sat, 10 Feb 2024 05:10:29 -0600
Version: 30.1

Damien Cassou <damien <at> cassou.me> writes:

> I wanted to configure which-func to activate only for programmation
> modes so I wrote:
>
> (use-package which-func
>   :init
>   (progn
>     (setq which-func-modes '(prog-mode)))
>   :config
>   (progn
>     (which-function-mode)))
>
> But this doesn't work because which-func only checks for exact major
> modes, not derived ones: because emacs-lisp-mode is not in
> `which-func-modes`, I won't get which-func to activate in
> emacs-lisp-mode even though I want it.
>
> I wrote the attached patch so which-func uses `derived-mode-p'. This
> solves my issue.

Thanks, pushed to master as commit 657d2c11337.  Closing.




This bug report was last modified 1 year and 160 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.