GNU bug report logs - #68980
[Matto Fransen] Propose to add rcirc-sqlite to ELPA

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68980 in the body.
You can then email your comments to 68980 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: submit <at> debbugs.gnu.org
Subject: [Matto Fransen] Propose to add rcirc-sqlite to ELPA
Date: Wed, 7 Feb 2024 11:19:45 -0800

Package: elpa

-------------------- Start of forwarded message --------------------
From: Matto Fransen <matto <at> matto.nl>
To: emacs-devel <at> gnu.org
Subject: Propose to add rcirc-sqlite to ELPA
Date: Wed, 07 Feb 2024 17:05:09 +0100

Hi,

I would like to propose to add the package `rcirc-sqlite' to ELPA.

rcirc is a default, simple IRC client in Emacs. rcirc can be
enabled to log to files.

rcirc-sqlite diverts the rcirc logs to a SQLite database and offers
some functionality to query this database.

Please see: https://codeberg.org/mattof/rcirc-sqlite/

-- 
Best regards,

Matto

-------------------- End of forwarded message --------------------

Message #8 received at 68980 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68980 <at> debbugs.gnu.org, Matto Fransen <matto <at> matto.nl>
Subject: Re: bug#68980: [Matto Fransen] Propose to add rcirc-sqlite to ELPA
Date: Wed, 07 Feb 2024 20:11:24 -0500

> I would like to propose to add the package `rcirc-sqlite' to ELPA.
>
> rcirc is a default, simple IRC client in Emacs. rcirc can be
> enabled to log to files.
>
> rcirc-sqlite diverts the rcirc logs to a SQLite database and offers
> some functionality to query this database.
>
> Please see: https://codeberg.org/mattof/rcirc-sqlite/

LGTM, thank you.
I just added it to `elpa.git`.
See below for a few minor changes that would be desirable.


        Stefan


diff --git a/.gitignore b/.gitignore
index 92112bec18..a475b22e90 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,3 +11,6 @@
 # Undo-tree save-files
 *.~undo-tree
 
+# ELPA-generated files
+/rcirc-sqlite-autoloads.el
+/rcirc-sqlite-pkg.el
diff --git a/rcirc-sqlite.el b/rcirc-sqlite.el
index 9928695d0d..f37440361c 100644
--- a/rcirc-sqlite.el
+++ b/rcirc-sqlite.el
@@ -45,6 +45,9 @@
 
 ;;; Code:
 
+(defvar rcirc-log-alist)
+(defvar rcirc-log-time-format)
+
 (defgroup rcirc-sqlite nil
   "Rcirc logging in SQLite."
   :prefix "rcirc-sqlite-"

Message #11 received at 68980 <at> debbugs.gnu.org (full text, mbox):

From: Matto Fransen <matto <at> matto.nl>
To: 68980 <at> debbugs.gnu.org
Subject: Re: bug#68980: [Matto Fransen] Propose to add rcirc-sqlite to ELPA
Date: Sat, 10 Feb 2024 11:17:37 +0100

Hi,

On  7 February 2024 20:11 Stefan Monnier, wrote:

> LGTM, thank you.
> I just added it to `elpa.git`.
> See below for a few minor changes that would be desirable.
>

Done

Best regards,

Matto

Message #16 received at 68980-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Matto Fransen <matto <at> matto.nl>
Cc: 68980-done <at> debbugs.gnu.org
Subject: Re: bug#68980: [Matto Fransen] Propose to add rcirc-sqlite to ELPA
Date: Sat, 10 Feb 2024 09:24:06 -0500

>> LGTM, thank you.
>> I just added it to `elpa.git`.
>> See below for a few minor changes that would be desirable.
> Done

Thanks, closing,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.