GNU bug report logs - #6890
23.1; makefile-fill-paragraph doesn't leave space for backslashes

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6890: closed (23.1; makefile-fill-paragraph doesn't leave
 space for backslashes)
Date: Sat, 21 Aug 2010 13:09:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Aug 2010 11:21:37 +0200
with message-id <jwvaaogs4q2.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#6890: 23.1; makefile-fill-paragraph doesn't leave space for backslashes
has caused the GNU bug report #6890,
regarding 23.1; makefile-fill-paragraph doesn't leave space for backslashes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6890: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6890
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kirk Kelsey <kirk.kelsey <at> 0x4b.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; makefile-fill-paragraph doesn't leave space for backslashes
Date: Fri, 20 Aug 2010 17:26:28 -0400

[Message part 3 (text/plain, inline)]

Using makefile-fill-paragraph on text in which some lines fit precisely
within
the fill-column will fill past the fill-column. The problem stems from the
direct use of fill-paragraph-function followed by makefile-backslash-region,
which inserts more text on each line. I think this can be solved by
decrementing fill-column before invoking fill-paragraph-function, and I've
included a patch to that effect.

Thanks,
Kirk


--- make-mode.el 2010-08-20 16:51:46.253395990 -0400
+++ make-mode-patch.el 2010-08-20 16:53:08.985392193 -0400
@@ -1323,7 +1323,9 @@
  (save-restriction
   (narrow-to-region beginning end)
   (makefile-backslash-region (point-min) (point-max) t)
-  (let ((fill-paragraph-function nil))
+  (let ((fill-paragraph-function nil)
+                ;; adjust fill-column to allow space for the backslash
+                (fill-column (- fill-column 1)))
     (fill-paragraph nil))
   (makefile-backslash-region (point-min) (point-max) nil)
   (goto-char (point-max))

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kirk Kelsey <kirk.kelsey <at> 0x4b.net>
Subject: Re: bug#6890: 23.1;
	makefile-fill-paragraph doesn't leave space for backslashes
Date: Sat, 21 Aug 2010 11:21:37 +0200

> Using makefile-fill-paragraph on text in which some lines fit precisely
> within
> the fill-column will fill past the fill-column. The problem stems from the
> direct use of fill-paragraph-function followed by makefile-backslash-region,
> which inserts more text on each line. I think this can be solved by
> decrementing fill-column before invoking fill-paragraph-function, and I've
> included a patch to that effect.

Thank you.  I liked your patch so much that I've installed it twice
(I've found this code at 2 places in the file).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.