GNU bug report logs - #6890
23.1; makefile-fill-paragraph doesn't leave space for backslashes

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6890 in the body.
You can then email your comments to 6890 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kirk Kelsey <kirk.kelsey <at> 0x4b.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 23.1; makefile-fill-paragraph doesn't leave space for backslashes
Date: Fri, 20 Aug 2010 17:26:28 -0400

[Message part 1 (text/plain, inline)]

Using makefile-fill-paragraph on text in which some lines fit precisely
within
the fill-column will fill past the fill-column. The problem stems from the
direct use of fill-paragraph-function followed by makefile-backslash-region,
which inserts more text on each line. I think this can be solved by
decrementing fill-column before invoking fill-paragraph-function, and I've
included a patch to that effect.

Thanks,
Kirk


--- make-mode.el 2010-08-20 16:51:46.253395990 -0400
+++ make-mode-patch.el 2010-08-20 16:53:08.985392193 -0400
@@ -1323,7 +1323,9 @@
  (save-restriction
   (narrow-to-region beginning end)
   (makefile-backslash-region (point-min) (point-max) t)
-  (let ((fill-paragraph-function nil))
+  (let ((fill-paragraph-function nil)
+                ;; adjust fill-column to allow space for the backslash
+                (fill-column (- fill-column 1)))
     (fill-paragraph nil))
   (makefile-backslash-region (point-min) (point-max) nil)
   (goto-char (point-max))

[Message part 2 (text/html, inline)]

Message #10 received at 6890-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kirk Kelsey <kirk.kelsey <at> 0x4b.net>
Subject: Re: bug#6890: 23.1;
	makefile-fill-paragraph doesn't leave space for backslashes
Date: Sat, 21 Aug 2010 11:21:37 +0200

> Using makefile-fill-paragraph on text in which some lines fit precisely
> within
> the fill-column will fill past the fill-column. The problem stems from the
> direct use of fill-paragraph-function followed by makefile-backslash-region,
> which inserts more text on each line. I think this can be solved by
> decrementing fill-column before invoking fill-paragraph-function, and I've
> included a patch to that effect.

Thank you.  I liked your patch so much that I've installed it twice
(I've found this code at 2 places in the file).


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.