GNU bug report logs - #68860
race condition with make recheck

Previous Next

Package: automake;

Reported by: Peter Johansson <trojkan <at> gmail.com>

Date: Thu, 1 Feb 2024 01:13:01 UTC

Severity: normal

Full log


View this message in rfc822 format

From: Karl Berry <karl <at> freefriends.org>
To: bogdro_rep <at> gmx.us
Cc: 68860 <at> debbugs.gnu.org, trojkan <at> gmail.com
Subject: bug#68860: race condition with make recheck
Date: Sun, 25 Aug 2024 19:17:52 -0600
    >      -  $output_rules .= "check-am: all-am\n";
    >      +  $output_rules .= "check-am: all-am";
    >         if (@check)
    >           {
    >      -      pretty_print_rule ("\t\$(MAKE) \$(AM_MAKEFLAGS)", "\t  ", @check);
    >      +      $output_rules .= " @check";

Looking again, the comment before this code says:

  # The check target must depend on the local equivalent of
  # 'all', to ensure all the primary targets are built.  Then it
  # must build the local check rules.

.. which makes sense. We have to make all before we can make check.
Hence the check targets can't be dependencies, since then they would be
run in parallel with make, and the programs built by 'all' might not be
built yet. This explains why they made it a sub-make.

So I'm puzzled as to how all the tests can still be passing. Maybe there
is no test specifically for this? --thanks, karl.




This bug report was last modified 291 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.