GNU bug report logs - #68859
[PATCH] gnu: Add cl-modf.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68859 in the body.
You can then email your comments to 68859 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles <at> charje.net>
To: guix-patches <at> gnu.org
Cc: Charles <charles <at> charje.net>
Subject: [PATCH] gnu: Add cl-modf.
Date: Wed, 31 Jan 2024 17:58:07 -0600

* gnu/packages/lisp-xyz.scm (sbcl-modf, cl-modf, ecl-modf): New variables.

Change-Id: Ic7e8e4511ca537531a7d9aa134e671aca060aa09
---
I used the quicklisp importer again for this one.

Also guix lint complains about "synopsis should start with an upper-case letter or digit", but I figure it should be fine to start with a @code.

 gnu/packages/lisp-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index ae71c67009..afe9c1bdbb 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -11550,6 +11550,42 @@ (define-public ecl-fset
      ;; Tests fails on ECL with "The function FSET::MAKE-CHAR is undefined".
      '(#:tests? #f))))
 
+(define-public sbcl-modf
+  (let ((commit "dea93fe62c6bf7f66f32f52ac0c555aedbf7abad")
+        (revision "0"))
+    (package
+      (name "sbcl-modf")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/smithzvk/modf")
+               (commit commit)))
+         (file-name (git-file-name "sbcl-modf" version))
+         (sha256
+          (base32
+           "1aap7ldy7lv942khp026pgndgdzfkkqa9xcq1ykinrmflrgdazay"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-alexandria
+             sbcl-closer-mop
+             sbcl-iterate))
+      (native-inputs
+       (list sbcl-stefil))
+      (home-page "https://github.com/smithzvk/modf")
+      (synopsis "@code{setf} like macro for functional programming in Common Lisp")
+      (description "This library simplifies functional programming in Common
+Lisp by making it easier to make new data structures with specified changes in
+place.")
+      (license license:bsd-3))))
+
+(define-public cl-modf
+  (sbcl-package->cl-source-package sbcl-modf))
+
+(define-public ecl-modf
+  (sbcl-package->ecl-package sbcl-modf))
+
 (define-public sbcl-cl-cont
   (let ((commit "fc1fa7e6eb64894fdca13e688e6015fad5290d2a")
         (revision "1"))

base-commit: 73d8e5a9352304a5192b22e04ef022234488e0da
prerequisite-patch-id: 45d179497c5c23d36ba555ff93d47a18276835ab
prerequisite-patch-id: 57958f0ec7271916a336f2d490f8edeabb429322
-- 
2.41.0

Message #8 received at 68859 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles <at> charje.net>
To: 68859 <at> debbugs.gnu.org
Cc: Charles <charles <at> charje.net>
Subject: [PATCH v2] gnu: Add cl-modf.
Date: Wed, 31 Jan 2024 18:29:22 -0600

* gnu/packages/lisp-xyz.scm (sbcl-modf, cl-modf, ecl-modf): New variables.

Change-Id: Ic7e8e4511ca537531a7d9aa134e671aca060aa09
---
I just saw that you change the git-file-name to use the package name, so I updated this patch to do the same.

 gnu/packages/lisp-xyz.scm | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index b764d6b885..8c9ee783a4 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -11552,6 +11552,42 @@ (define-public ecl-fset
      ;; Tests fails on ECL with "The function FSET::MAKE-CHAR is undefined".
      '(#:tests? #f))))
 
+(define-public sbcl-modf
+  (let ((commit "dea93fe62c6bf7f66f32f52ac0c555aedbf7abad")
+        (revision "0"))
+    (package
+      (name "sbcl-modf")
+      (version (git-version "0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/smithzvk/modf")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32
+           "1aap7ldy7lv942khp026pgndgdzfkkqa9xcq1ykinrmflrgdazay"))))
+      (build-system asdf-build-system/sbcl)
+      (inputs
+       (list sbcl-alexandria
+             sbcl-closer-mop
+             sbcl-iterate))
+      (native-inputs
+       (list sbcl-stefil))
+      (home-page "https://github.com/smithzvk/modf")
+      (synopsis "@code{setf} like macro for functional programming in Common Lisp")
+      (description "This library simplifies functional programming in Common
+Lisp by making it easier to make new data structures with specified changes in
+place.")
+      (license license:bsd-3))))
+
+(define-public cl-modf
+  (sbcl-package->cl-source-package sbcl-modf))
+
+(define-public ecl-modf
+  (sbcl-package->ecl-package sbcl-modf))
+
 (define-public sbcl-cl-cont
   (let ((commit "fc1fa7e6eb64894fdca13e688e6015fad5290d2a")
         (revision "1"))

base-commit: bf7991a8c767abd32cfb2c92e3d57665a7cabf00
prerequisite-patch-id: bcaf8eb7f369a54bf47e9c7ef7b94fda2295de4a
-- 
2.41.0

Message #13 received at 68859-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Charles <charles <at> charje.net>
Cc: 68859-done <at> debbugs.gnu.org
Subject: Re: [bug#68859] [PATCH v2] gnu: Add cl-modf.
Date: Mon, 05 Feb 2024 13:37:23 +0000

[Message part 1 (text/plain, inline)]

Charles <charles <at> charje.net> skribis:

> I just saw that you change the git-file-name to use the package name, so I updated this patch to do the same.

Usually when packaging the xyz Common Lisp package, we use "cl-xyz" as
name for the sources instead of "sbcl-xyz" to indicate that the sources
are not specific to sbcl (as they are also used for the cl-xyz and
ecl-xyz packages).

Patch applied as 87f5876e60922a032b253c43964d2e455d14955a.
Thanks.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.