GNU bug report logs - #68762
30.0.50; thing-at-point for an e-mail adress stops at "."

Previous Next

Full log

Message #40 received at 68762-done <at> debbugs.gnu.org (full text, mbox):

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68762-done <at> debbugs.gnu.org, rpluim <at> gmail.com, mail <at> titusmueller.de,
 philipk <at> posteo.net
Subject: Re: bug#68762: 30.0.50; thing-at-point for an e-mail adress stops
 at "."
Date: Sat, 10 Feb 2024 17:48:42 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Eshel Yaron <me <at> eshelyaron.com>
>> Cc: rpluim <at> gmail.com,  philipk <at> posteo.net,  mail <at> titusmueller.de,
>>   68762 <at> debbugs.gnu.org
>> Date: Thu, 01 Feb 2024 12:10:35 +0100
>>
>> > Eshel, would you like to add some tests for this?
>>
>> Sure, I'm attaching below a patch with a slightly cleaner implementation
>> and a couple of tests.
>>
>> Note that this is a complete rewrite of a function that mostly haven't
>> changed since 1997, so please give it a close look before installing, in
>> case there's some use case that didn't occur to me and isn't covered by
>> the existing tests.
>
> Thanks, I boldly went ahead and installed this on master.  Closing.

Thanks.  I've found an edge case that my implementation didn't handle
correctly.  I'm not sure it affects any of the actual uses of this
function, but nevertheless I pushed a small fix along with a another
test case in 939187fd7a0.


Best,

Eshel

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.