GNU bug report logs - #68761
[PATCH] Record dependencies in packages installed via package-vc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68761 in the body.
You can then email your comments to 68761 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Steven Allen <steven <at> stebalien.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Record dependencies in packages installed via package-vc
Date: Sat, 27 Jan 2024 08:22:23 -0800

[Message part 1 (text/plain, inline)]

The dependency list wasn't getting recorded in the package's `-pkg.el` file.

[Message part 2 (text/x-patch, attachment)]

Message #8 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Steven Allen <steven <at> stebalien.com>
Cc: 68761 <at> debbugs.gnu.org
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Tue, 06 Feb 2024 20:05:25 +0000

Steven Allen <steven <at> stebalien.com> writes:

> The dependency list wasn't getting recorded in the package's `-pkg.el` file.

Did you notice this because of some bug or what is the motivation for
this change?  I'll certainly look into it, I just wanted some context.

>>From edc9f75958d5feb2a82c53879e9dde4c51921bb6 Mon Sep 17 00:00:00 2001
> From: Steven Allen <steven <at> stebalien.com>
> Date: Sat, 27 Jan 2024 08:17:08 -0800
> Subject: [PATCH] Record dependencies in packages installed via package-vc
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): Record a
> package's declared dependencies in the package's metadata ("-pkg.el").
> ---
>  lisp/emacs-lisp/package-vc.el | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index db0cc515e46..fc402716dab 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -532,6 +532,7 @@ package-vc--unpack-1
>                  (setq deps))))))
>        (dolist (dep deps)
>          (cl-callf version-to-list (cadr dep)))
> +      (setf (package-desc-reqs pkg-desc) deps)
>        (setf missing (package-vc-install-dependencies (delete-dups deps)))
>        (setf missing (delq (assq (package-desc-name pkg-desc)
>                                  missing)

Message #11 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Steven Allen <steven <at> stebalien.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 68761 <at> debbugs.gnu.org
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Tue, 06 Feb 2024 12:15:25 -0800

>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>
> Did you notice this because of some bug or what is the motivation for
> this change?  I'll certainly look into it, I just wanted some context.

I noticed this because I tried to remove "unused" dependencies
(package-autoremove) and ended up removing dependencies from my
package-vc packages.

Message #14 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Steven Allen <steven <at> stebalien.com>
Cc: 68761 <at> debbugs.gnu.org
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Wed, 07 Feb 2024 07:18:33 +0000

Steven Allen <steven <at> stebalien.com> writes:

>>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>>
>> Did you notice this because of some bug or what is the motivation for
>> this change?  I'll certainly look into it, I just wanted some context.
>
> I noticed this because I tried to remove "unused" dependencies
> (package-autoremove) and ended up removing dependencies from my
> package-vc packages.

That doesn't sound good.  Your patch should resolve the issue, and I
would be inclined to propose applying it to the Emacs 29 branch, if the
maintainers don't object.

Message #17 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 68761 <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed via
 package-vc
Date: Wed, 07 Feb 2024 14:57:48 +0200

> Cc: 68761 <at> debbugs.gnu.org
> From: Philip Kaludercic <philipk <at> posteo.net>
> Date: Wed, 07 Feb 2024 07:18:33 +0000
> 
> Steven Allen <steven <at> stebalien.com> writes:
> 
> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
> >>
> >> Did you notice this because of some bug or what is the motivation for
> >> this change?  I'll certainly look into it, I just wanted some context.
> >
> > I noticed this because I tried to remove "unused" dependencies
> > (package-autoremove) and ended up removing dependencies from my
> > package-vc packages.
> 
> That doesn't sound good.  Your patch should resolve the issue, and I
> would be inclined to propose applying it to the Emacs 29 branch, if the
> maintainers don't object.

How serious is the problem?  Since it's unlikely there will be any
more Emacs 29.x releases, except if we have some emergency, we should
try to keep the release branch as safe and undiverged from 29.2 as
possible.

Message #20 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68761 <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Wed, 07 Feb 2024 17:07:43 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 68761 <at> debbugs.gnu.org
>> From: Philip Kaludercic <philipk <at> posteo.net>
>> Date: Wed, 07 Feb 2024 07:18:33 +0000
>> 
>> Steven Allen <steven <at> stebalien.com> writes:
>> 
>> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
>> >>
>> >> Did you notice this because of some bug or what is the motivation for
>> >> this change?  I'll certainly look into it, I just wanted some context.
>> >
>> > I noticed this because I tried to remove "unused" dependencies
>> > (package-autoremove) and ended up removing dependencies from my
>> > package-vc packages.
>> 
>> That doesn't sound good.  Your patch should resolve the issue, and I
>> would be inclined to propose applying it to the Emacs 29 branch, if the
>> maintainers don't object.
>
> How serious is the problem?  Since it's unlikely there will be any
> more Emacs 29.x releases, except if we have some emergency, we should
> try to keep the release branch as safe and undiverged from 29.2 as
> possible.

I wouldn't clarify it as an emergency, at most a regrettable
inconvenience.

Just to avoid confusion: What branch is the current release branch then?

Message #23 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 68761 <at> debbugs.gnu.org, steven <at> stebalien.com
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Wed, 07 Feb 2024 19:18:46 +0200

> From: Philip Kaludercic <philipk <at> posteo.net>
> Cc: steven <at> stebalien.com,  68761 <at> debbugs.gnu.org
> Date: Wed, 07 Feb 2024 17:07:43 +0000
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: 68761 <at> debbugs.gnu.org
> >> From: Philip Kaludercic <philipk <at> posteo.net>
> >> Date: Wed, 07 Feb 2024 07:18:33 +0000
> >> 
> >> Steven Allen <steven <at> stebalien.com> writes:
> >> 
> >> >>> The dependency list wasn't getting recorded in the package's `-pkg.el` file.
> >> >>
> >> >> Did you notice this because of some bug or what is the motivation for
> >> >> this change?  I'll certainly look into it, I just wanted some context.
> >> >
> >> > I noticed this because I tried to remove "unused" dependencies
> >> > (package-autoremove) and ended up removing dependencies from my
> >> > package-vc packages.
> >> 
> >> That doesn't sound good.  Your patch should resolve the issue, and I
> >> would be inclined to propose applying it to the Emacs 29 branch, if the
> >> maintainers don't object.
> >
> > How serious is the problem?  Since it's unlikely there will be any
> > more Emacs 29.x releases, except if we have some emergency, we should
> > try to keep the release branch as safe and undiverged from 29.2 as
> > possible.
> 
> I wouldn't clarify it as an emergency, at most a regrettable
> inconvenience.

Then I tend to think this should be installed on master.

> Just to avoid confusion: What branch is the current release branch then?

It's still emacs-29.  When we start the release cycle of Emacs 30.1,
we will cut the emacs-30 branch.

The release branch is not closed to fixes, it just should receive only
very safe ones (like documentation fixes), or very urgent/serious
ones.

Message #26 received at 68761 <at> debbugs.gnu.org (full text, mbox):

From: Steven Allen <steven <at> stebalien.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Philip Kaludercic <philipk <at> posteo.net>
Cc: 68761 <at> debbugs.gnu.org
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Wed, 07 Feb 2024 10:42:24 -0800

>> I wouldn't clarify it as an emergency, at most a regrettable
>> inconvenience.
>
> Then I tend to think this should be installed on master.

I agree. Users will only run into it if they:

1. Use `package-vc` (very new and has quite a few sharp edges).
2. Use the "package-autoremove" feature.

Given that nobody else has reported this, it's probably not causing too
many issues.

Message #31 received at 68761-done <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Steven Allen <steven <at> stebalien.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68761-done <at> debbugs.gnu.org
Subject: Re: bug#68761: [PATCH] Record dependencies in packages installed
 via package-vc
Date: Sat, 10 Feb 2024 15:54:36 +0000

Steven Allen <steven <at> stebalien.com> writes:

>>> I wouldn't clarify it as an emergency, at most a regrettable
>>> inconvenience.
>>
>> Then I tend to think this should be installed on master.
>
> I agree. Users will only run into it if they:
>
> 1. Use `package-vc` (very new and has quite a few sharp edges).
> 2. Use the "package-autoremove" feature.
>
> Given that nobody else has reported this, it's probably not causing too
> many issues.

OK, I have applied the branch to master.

Thanks!

-- 
Philip Kaludercic

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.