GNU bug report logs - #68762
30.0.50; thing-at-point for an e-mail adress stops at "."

Previous Next

Full log

View this message in rfc822 format

From: Eshel Yaron <me <at> eshelyaron.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: rpluim <at> gmail.com, mail <at> titusmueller.de, philipk <at> posteo.net, 68762 <at> debbugs.gnu.org
Subject: bug#68762: 30.0.50; thing-at-point for an e-mail adress stops at "."
Date: Thu, 01 Feb 2024 12:10:35 +0100

[Message part 1 (text/plain, inline)]

Hi,

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: philipk <at> posteo.net, mail <at> titusmueller.de, me <at> eshelyaron.com,
>>  68762 <at> debbugs.gnu.org
>> Date: Mon, 29 Jan 2024 14:41:02 +0200
>> From: Eli Zaretskii <eliz <at> gnu.org>
>>
>> > From: Robert Pluim <rpluim <at> gmail.com>
>> > Cc: Eli Zaretskii <eliz <at> gnu.org>,  mail <at> titusmueller.de,
>> >   philipk <at> posteo.net,  68762 <at> debbugs.gnu.org
>> > Date: Mon, 29 Jan 2024 10:05:17 +0100
>> >
>> > >>>>> On Sun, 28 Jan 2024 08:47:49 +0100, Eshel Yaron <me <at> eshelyaron.com> said:
>> >
>> >     >> Robert, any comments?
>> >
>> > Not really. It would be nice if the test suite could be extended to
>> > catch this.
>>
>> Agreed.
>
> Eshel, would you like to add some tests for this?

Sure, I'm attaching below a patch with a slightly cleaner implementation
and a couple of tests.

Note that this is a complete rewrite of a function that mostly haven't
changed since 1997, so please give it a close look before installing, in
case there's some use case that didn't occur to me and isn't covered by
the existing tests.


Best,

Eshel

[0001-Ensure-thing-at-point-looking-at-finds-full-match.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.