GNU bug report logs - #68762
30.0.50; thing-at-point for an e-mail adress stops at "."

Previous Next

Package: emacs;

Reported by: Titus Müller <mail <at> titusmueller.de>

Date: Sat, 27 Jan 2024 16:37:01 UTC

Severity: normal

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Robert Pluim <rpluim <at> gmail.com>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, mail <at> titusmueller.de, philipk <at> posteo.net, 68762 <at> debbugs.gnu.org
Subject: bug#68762: 30.0.50; thing-at-point for an e-mail adress stops at "."
Date: Mon, 29 Jan 2024 10:05:17 +0100

>>>>> On Sun, 28 Jan 2024 08:47:49 +0100, Eshel Yaron <me <at> eshelyaron.com> said:

    Eshel> Eli Zaretskii <eliz <at> gnu.org> writes:
    >>> From: Eshel Yaron <me <at> eshelyaron.com>
    >>> Cc: Titus Müller <mail <at> titusmueller.de>,  Philip Kaludercic
    >>> <philipk <at> posteo.net>,  68762 <at> debbugs.gnu.org
    >>> Date: Sun, 28 Jan 2024 06:58:19 +0100
    >>> 
    >>> FWIW, AFAICT this is introduced by 03cfede8f0 (which fixed Bug#61519).
    >>> 
    >>> I think the real issue resides in `thing-at-point-looking-at`, though:
    >>> It stops extending the match backwards when it first encounters a
    >>> non-match.  The following change solves this for me, and keeps all the
    >>> tests happy:
    >> 
    >> Thanks.  Can you describe the main ideas of the change?

    Eshel> Sure: the current implementation searches forward first, and then back,
    Eshel> until it finds a match that contains point.  It then extends the match
    Eshel> backward character by character until it reaches a non-match.  My change
    Eshel> reverses the direction: start from some position before point and search
    Eshel> forward until you find a match that contains point.  This works better
    Eshel> since "matching a regular expression at a given spot always works from
    Eshel> beginning to end" (from Info node "(elisp) Regexp Search").


    >> Robert, any comments?

Not really. It would be nice if the test suite could be extended to
catch this.

Robert
--
This bug report was last modified 1 year and 159 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.