GNU bug report logs - #68617
[PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.

Previous Next

Full log

View this message in rfc822 format

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68617 <at> debbugs.gnu.org
Cc: poptsov.artyom <at> gmail.com
Subject: [bug#68617] [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sat, 3 Feb 2024 05:42:58 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch!

> +          (add-before 'check 'add-supported-mimes-md
> +            (lambda* (#:key inputs #:allow-other-keys #:rest args)
> +              ;; This file needs to be available for writing during the
Instead of path string you may use import-path (change inputs in
lambda to use it. Check for examples in golang.scm.

> +              ;; tests otherwise they will fail.
> +              (let ((file
> +                     "src/
github.com/gabriel-vasile/mimetype/supported_mimes.md"))
It would be something like this (invoke "touch" (string-append import-path
"supported_mimes.md"). Or check if the code
 depends on HOME envar.

>+    (description
> +     "A fast Golang library for media type and file extension detection,
based on
> +magic numbers .")
Trailing space in the end of the sentence. Try to add more detail,
I've checked github page there is a link to a little bit detailed doc.

Apply common steps: guix lint, guix style.

Looking forward for v2.

Thanks,
Oleg

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.