GNU bug report logs - #68617
[PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68617 in the body.
You can then email your comments to 68617 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sat, 20 Jan 2024 21:09:08 +0300

[Message part 1 (text/plain, inline)]

Hello,

this patch adds "go-github-com-gabriel-vasile-mimetype"[1]

[0001-gnu-Add-go-github-com-gabriel-vasile-mimetype.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
- avp

References:
1. https://github.com/gabriel-vasile/mimetype/

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 68617 <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68617 <at> debbugs.gnu.org
Cc: poptsov.artyom <at> gmail.com
Subject: [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sat, 3 Feb 2024 05:42:58 +0000

[Message part 1 (text/plain, inline)]

Hi,

Thank you for the patch!

> +          (add-before 'check 'add-supported-mimes-md
> +            (lambda* (#:key inputs #:allow-other-keys #:rest args)
> +              ;; This file needs to be available for writing during the
Instead of path string you may use import-path (change inputs in
lambda to use it. Check for examples in golang.scm.

> +              ;; tests otherwise they will fail.
> +              (let ((file
> +                     "src/
github.com/gabriel-vasile/mimetype/supported_mimes.md"))
It would be something like this (invoke "touch" (string-append import-path
"supported_mimes.md"). Or check if the code
 depends on HOME envar.

>+    (description
> +     "A fast Golang library for media type and file extension detection,
based on
> +magic numbers .")
Trailing space in the end of the sentence. Try to add more detail,
I've checked github page there is a link to a little bit detailed doc.

Apply common steps: guix lint, guix style.

Looking forward for v2.

Thanks,
Oleg

[Message part 2 (text/html, inline)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sun, 04 Feb 2024 09:58:05 +0300

[Message part 1 (text/plain, inline)]

Hello,

I took into account the comments from Sharlatan Hellseher and updated
the patch.

[0001-gnu-Add-go-github-com-gabriel-vasile-mimetype.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Artyom V. Poptsov" <poptsov.artyom <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Sun, 04 Feb 2024 20:14:43 +0300

[Message part 1 (text/plain, inline)]

Hello,

I attached the old version of the patch by mistake to the previous
email.

Here's the right version.

[0001-gnu-Add-go-github-com-gabriel-vasile-mimetype.patch (text/x-diff, attachment)]

[Message part 3 (text/plain, inline)]

Thanks,
- avp

-- 
Artyom "avp" Poptsov <poptsov.artyom <at> gmail.com>
Home page: https://memory-heap.org/~avp/
CADR Hackerspace co-founder: https://cadrspace.ru/
GPG: D0C2 EAC1 3310 822D 98DE  B57C E9C5 A2D9 0898 A02F

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 68617-done <at> debbugs.gnu.org (full text, mbox):

From: Sharlatan Hellseher <sharlatanus <at> gmail.com>
To: 68617-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: Add go-github-com-gabriel-vasile-mimetype.
Date: Mon, 05 Feb 2024 15:51:15 +0000

[Message part 1 (text/plain, inline)]

Hi,

 Modification applied
 - package placed in golang-xyz.scm, as golang.scm in a process of split into logical modules,
   see <https://lists.gnu.org/archive/html/guix-devel/2024-01/msg00113.html>
 - [description]: Append "This package provides a"

Pushed as 317d9840d371469daa23d13ac7c62477ed347b54 to master.

Thanks,
Oleg

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.