GNU bug report logs - #68484
[PATCH] gnu: guile-fibers: Disable failing tests on aarch64.

Previous Next

Package: guix-patches;

Reported by: Roman Scherer <roman <at> burningswell.com>

Date: Mon, 15 Jan 2024 19:58:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Roman Scherer <roman <at> burningswell.com>
Subject: bug#68484: closed (Re: [bug#68484] [PATCH v2] gnu: guile-fibers:
 Disable failing tests on aarch64.)
Date: Wed, 24 Jan 2024 22:31:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#68484: [PATCH] gnu: guile-fibers: Disable failing tests on aarch64.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 68484 <at> debbugs.gnu.org.

-- 
68484: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68484
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 68484-done <at> debbugs.gnu.org
Subject: Re: [bug#68484] [PATCH v2] gnu: guile-fibers: Disable failing tests
 on aarch64.
Date: Wed, 24 Jan 2024 23:30:20 +0100
Hi Roman,

Roman Scherer <roman <at> burningswell.com> skribis:

> * gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.
>
> Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800

I pushed a variant of this patch as
8bee6bb9aaaf35c36fe325675d1eb2daebd69c25, which avoids a rebuild on
x86_64 and makes things somewhat clearer IMO.

Thank you,
Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH] gnu: guile-fibers: Disable failing tests on aarch64.
Date: Mon, 15 Jan 2024 20:57:00 +0100
* gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.

Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800
---
 gnu/packages/guile-xyz.scm | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 77be632cc3..9b0f27016d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -824,16 +824,27 @@ (define-public guile-fibers
            #~(list "GUILE_AUTO_COMPILE=0")
            #:phases
            (if (target-x86-64?)
-             #~%standard-phases
-             #~(modify-phases %standard-phases
-                 (add-before 'check 'disable-some-tests
-                   (lambda _
-                     ;; This test can take more than an hour on some systems.
-                     (substitute* "tests/basic.scm"
-                       ((".*spawn-fiber loop-to-1e4.*") ""))
-                     ;; These tests can take more than an hour and/or segfault.
-                     (substitute* "Makefile"
-                       (("tests/speedup.scm") ""))))))))
+               #~%standard-phases
+               #~(modify-phases %standard-phases
+                   (add-before 'check 'disable-some-tests
+                     (lambda _
+                       (substitute* "tests/basic.scm"
+                         ;; This test can take more than an hour on some systems.
+                         ((".*spawn-fiber loop-to-1e4.*") "")
+                         ;; This test has issues on aarch64 systems. It passes
+                         ;; on an Apple M1, but takes a very long time on a
+                         ;; Hetzner aarch64 VM.
+                         ((".*spawn-fiber-chain 5000000.*") ""))
+
+                       (substitute* "tests/channels.scm"
+                         ;; This test has issues on aarch64 systems. It passes
+                         ;; on an Apple M1, but raises exceptions on a Hetzner
+                         ;; aarch64 VM.
+                         ((".*assert-run-fibers-terminates .*pingpong.*") ""))
+
+                       ;; These tests can take more than an hour and/or segfault.
+                       (substitute* "Makefile"
+                         (("tests/speedup.scm") ""))))))))
     (native-inputs
      (list texinfo pkg-config autoconf-2.71 automake libtool
            guile-3.0            ;for 'guild compile

base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
-- 
2.41.0




This bug report was last modified 1 year and 116 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.