GNU bug report logs - #68484
[PATCH] gnu: guile-fibers: Disable failing tests on aarch64.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68484 in the body.
You can then email your comments to 68484 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: guix-patches <at> gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH] gnu: guile-fibers: Disable failing tests on aarch64.
Date: Mon, 15 Jan 2024 20:57:00 +0100

* gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.

Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800
---
 gnu/packages/guile-xyz.scm | 31 +++++++++++++++++++++----------
 1 file changed, 21 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 77be632cc3..9b0f27016d 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -824,16 +824,27 @@ (define-public guile-fibers
            #~(list "GUILE_AUTO_COMPILE=0")
            #:phases
            (if (target-x86-64?)
-             #~%standard-phases
-             #~(modify-phases %standard-phases
-                 (add-before 'check 'disable-some-tests
-                   (lambda _
-                     ;; This test can take more than an hour on some systems.
-                     (substitute* "tests/basic.scm"
-                       ((".*spawn-fiber loop-to-1e4.*") ""))
-                     ;; These tests can take more than an hour and/or segfault.
-                     (substitute* "Makefile"
-                       (("tests/speedup.scm") ""))))))))
+               #~%standard-phases
+               #~(modify-phases %standard-phases
+                   (add-before 'check 'disable-some-tests
+                     (lambda _
+                       (substitute* "tests/basic.scm"
+                         ;; This test can take more than an hour on some systems.
+                         ((".*spawn-fiber loop-to-1e4.*") "")
+                         ;; This test has issues on aarch64 systems. It passes
+                         ;; on an Apple M1, but takes a very long time on a
+                         ;; Hetzner aarch64 VM.
+                         ((".*spawn-fiber-chain 5000000.*") ""))
+
+                       (substitute* "tests/channels.scm"
+                         ;; This test has issues on aarch64 systems. It passes
+                         ;; on an Apple M1, but raises exceptions on a Hetzner
+                         ;; aarch64 VM.
+                         ((".*assert-run-fibers-terminates .*pingpong.*") ""))
+
+                       ;; These tests can take more than an hour and/or segfault.
+                       (substitute* "Makefile"
+                         (("tests/speedup.scm") ""))))))))
     (native-inputs
      (list texinfo pkg-config autoconf-2.71 automake libtool
            guile-3.0            ;for 'guild compile

base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
-- 
2.41.0

Message #8 received at 68484 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 68484 <at> debbugs.gnu.org
Subject: Re: [bug#68484] [PATCH] gnu: guile-fibers: Disable failing tests on
 aarch64.
Date: Wed, 17 Jan 2024 10:56:03 +0100

Hey,

> +                       (substitute* "tests/channels.scm"
> +                         ;; This test has issues on aarch64 systems. It passes
> +                         ;; on an Apple M1, but raises exceptions on a Hetzner
> +                         ;; aarch64 VM.
> +                         ((".*assert-run-fibers-terminates .*pingpong.*") ""))

Maybe we should only disable that one if we are targeting an aarch64
system / target?

Thanks,

Mathieu

Message #11 received at 68484 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman.scherer <at> burningswell.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 68484 <at> debbugs.gnu.org
Subject: Re: [bug#68484] [PATCH] gnu: guile-fibers: Disable failing tests on
 aarch64.
Date: Wed, 17 Jan 2024 20:46:46 +0100

[Message part 1 (text/plain, inline)]

Hi Mathieu,

thanks for taking a look. Yes, you are right. I'm going to send another
patch.

Roman

Mathieu Othacehe <othacehe <at> gnu.org> writes:

> Hey,
>
>> +                       (substitute* "tests/channels.scm"
>> +                         ;; This test has issues on aarch64 systems. It passes
>> +                         ;; on an Apple M1, but raises exceptions on a Hetzner
>> +                         ;; aarch64 VM.
>> +                         ((".*assert-run-fibers-terminates .*pingpong.*") ""))
>
> Maybe we should only disable that one if we are targeting an aarch64
> system / target?
>
> Thanks,
>
> Mathieu

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 68484 <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: 68484 <at> debbugs.gnu.org
Cc: Roman Scherer <roman <at> burningswell.com>
Subject: [PATCH v2] gnu: guile-fibers: Disable failing tests on aarch64.
Date: Wed, 17 Jan 2024 20:48:36 +0100

* gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.

Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800
---
 gnu/packages/guile-xyz.scm | 25 +++++++++++++++++++------
 1 file changed, 19 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index 77be632cc3..1db0984a04 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -823,17 +823,30 @@ (define-public guile-fibers
      (list #:make-flags
            #~(list "GUILE_AUTO_COMPILE=0")
            #:phases
-           (if (target-x86-64?)
-             #~%standard-phases
-             #~(modify-phases %standard-phases
-                 (add-before 'check 'disable-some-tests
-                   (lambda _
+           #~(modify-phases %standard-phases
+               (add-before 'check 'disable-some-tests
+                 (lambda _
+                   (unless #$(target-x86-64?)
                      ;; This test can take more than an hour on some systems.
                      (substitute* "tests/basic.scm"
                        ((".*spawn-fiber loop-to-1e4.*") ""))
+
                      ;; These tests can take more than an hour and/or segfault.
                      (substitute* "Makefile"
-                       (("tests/speedup.scm") ""))))))))
+                       (("tests/speedup.scm") "")))
+
+                   (when #$(target-aarch64?)
+                     ;; This test has issues on aarch64 systems. It passes on
+                     ;; an Apple M1, but takes a very long time on a Hetzner
+                     ;; aarch64 VM.
+                     (substitute* "tests/basic.scm"
+                       ((".*spawn-fiber-chain 5000000.*") ""))
+
+                     ;; This test has issues on aarch64 systems. It passes on
+                     ;; an Apple M1, but raises exceptions on a Hetzner
+                     ;; aarch64 VM.
+                     (substitute* "tests/channels.scm"
+                       ((".*assert-run-fibers-terminates .*pingpong.*") ""))))))))
     (native-inputs
      (list texinfo pkg-config autoconf-2.71 automake libtool
            guile-3.0            ;for 'guild compile

base-commit: 162d6a2fdd6af13272967c77347a54934ecb45e6
-- 
2.41.0

Message #19 received at 68484-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Roman Scherer <roman <at> burningswell.com>
Cc: 68484-done <at> debbugs.gnu.org
Subject: Re: [bug#68484] [PATCH v2] gnu: guile-fibers: Disable failing tests
 on aarch64.
Date: Wed, 24 Jan 2024 23:30:20 +0100

Hi Roman,

Roman Scherer <roman <at> burningswell.com> skribis:

> * gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on aarch64.
>
> Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800

I pushed a variant of this patch as
8bee6bb9aaaf35c36fe325675d1eb2daebd69c25, which avoids a rebuild on
x86_64 and makes things somewhat clearer IMO.

Thank you,
Ludo’.

Message #22 received at 68484-done <at> debbugs.gnu.org (full text, mbox):

From: Roman Scherer <roman <at> burningswell.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 68484-done <at> debbugs.gnu.org
Subject: Re: [bug#68484] [PATCH v2] gnu: guile-fibers: Disable failing tests
 on aarch64.
Date: Wed, 24 Jan 2024 23:45:11 +0100

[Message part 1 (text/plain, inline)]

Perfect. Thank you.

On Wed, Jan 24, 2024, 23:30 Ludovic Courtès <ludo <at> gnu.org> wrote:

> Hi Roman,
>
> Roman Scherer <roman <at> burningswell.com> skribis:
>
> > * gnu/packages/guile-xyz.scm (guile-fibers): Disable failing tests on
> aarch64.
> >
> > Change-Id: Id05b516a659f641cc7ef01efdaf6cd1f2c735800
>
> I pushed a variant of this patch as
> 8bee6bb9aaaf35c36fe325675d1eb2daebd69c25, which avoids a rebuild on
> x86_64 and makes things somewhat clearer IMO.
>
> Thank you,
> Ludo’.
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.