GNU bug report logs - #68367
30.0.50; etc-fstab-generic-mode is missing cgroup2

Previous Next

Full log

Message #8 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>, 68367 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 06:55:30 -0800

Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
> cgroup v2 instead of cgroup for cgroup v1).  I just learned about
> etc-fstab-generic-mode and after loading generic-x and visiting
> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
> column is fontified in the default face, not in font-lock-keyword-face,
> unlike all other file system types in my /etc/fstab file.  This patch
> fixes the misfontification:
>
> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
> index b4ae0225943..373bfad92dd 100644
> --- a/lisp/generic-x.el
> +++ b/lisp/generic-x.el
> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>      "cd9660"
>      "cfs"
>      "cgroup"
> +    "cgroup2"
>      "cifs"
>      "coda"
>      "coherent"

Thanks, but could you please reformat this using `git format-patch -1`?

> While the misfontification isn't a regression -- the support for cgroups
> (but only for cgroup v1) in etc-fstab-generic-mode was added in January
> 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
> v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
> omitting cgroup2 was presumably an oversight in that commit.

I don't really have an opinion, but sounds good to me.  Eli?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.