GNU bug report logs - #68367
30.0.50; etc-fstab-generic-mode is missing cgroup2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68367 in the body.
You can then email your comments to 68367 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 14:31:32 +0100

[Message part 1 (text/plain, inline)]

My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
cgroup v2 instead of cgroup for cgroup v1).  I just learned about
etc-fstab-generic-mode and after loading generic-x and visiting
/etc/fstab, I saw that in the line for cgroup2, the entry in the type
column is fontified in the default face, not in font-lock-keyword-face,
unlike all other file system types in my /etc/fstab file.  This patch
fixes the misfontification:

[Message part 2 (text/x-patch, inline)]

diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index b4ae0225943..373bfad92dd 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
     "cd9660"
     "cfs"
     "cgroup"
+    "cgroup2"
     "cifs"
     "coda"
     "coherent"

[Message part 3 (text/plain, inline)]

While the misfontification isn't a regression -- the support for cgroups
(but only for cgroup v1) in etc-fstab-generic-mode was added in January
2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
omitting cgroup2 was presumably an oversight in that commit.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2
Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Linux From Scratch r12.0-112

Message #8 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>, 68367 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 06:55:30 -0800

Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
text editors" <bug-gnu-emacs <at> gnu.org> writes:

> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
> cgroup v2 instead of cgroup for cgroup v1).  I just learned about
> etc-fstab-generic-mode and after loading generic-x and visiting
> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
> column is fontified in the default face, not in font-lock-keyword-face,
> unlike all other file system types in my /etc/fstab file.  This patch
> fixes the misfontification:
>
> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
> index b4ae0225943..373bfad92dd 100644
> --- a/lisp/generic-x.el
> +++ b/lisp/generic-x.el
> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>      "cd9660"
>      "cfs"
>      "cgroup"
> +    "cgroup2"
>      "cifs"
>      "coda"
>      "coherent"

Thanks, but could you please reformat this using `git format-patch -1`?

> While the misfontification isn't a regression -- the support for cgroups
> (but only for cgroup v1) in etc-fstab-generic-mode was added in January
> 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
> v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
> omitting cgroup2 was presumably an oversight in that commit.

I don't really have an opinion, but sounds good to me.  Eli?

Message #11 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 68367 <at> debbugs.gnu.org, stephen.berman <at> gmx.net
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 17:07:26 +0200

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Wed, 10 Jan 2024 06:55:30 -0800
> Cc: Eli Zaretskii <eliz <at> gnu.org>
> 
> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
> 
> > While the misfontification isn't a regression -- the support for cgroups
> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
> > omitting cgroup2 was presumably an oversight in that commit.
> 
> I don't really have an opinion, but sounds good to me.  Eli?

I don't mind adding this to emacs-29.

Thanks.

Message #14 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68367 <at> debbugs.gnu.org
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 16:26:21 +0100

On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas <stefankangas <at> gmail.com> wrote:

> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>
>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
>> cgroup v2 instead of cgroup for cgroup v1).  I just learned about
>> etc-fstab-generic-mode and after loading generic-x and visiting
>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
>> column is fontified in the default face, not in font-lock-keyword-face,
>> unlike all other file system types in my /etc/fstab file.  This patch
>> fixes the misfontification:
>>
>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
>> index b4ae0225943..373bfad92dd 100644
>> --- a/lisp/generic-x.el
>> +++ b/lisp/generic-x.el
>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>>      "cd9660"
>>      "cfs"
>>      "cgroup"
>> +    "cgroup2"
>>      "cifs"
>>      "coda"
>>      "coherent"
>
> Thanks, but could you please reformat this using `git format-patch -1`?

On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii <eliz <at> gnu.org> wrote:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Wed, 10 Jan 2024 06:55:30 -0800
>> Cc: Eli Zaretskii <eliz <at> gnu.org>
>>
>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>
>> > While the misfontification isn't a regression -- the support for cgroups
>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
>> > omitting cgroup2 was presumably an oversight in that commit.
>>
>> I don't really have an opinion, but sounds good to me.  Eli?
>
> I don't mind adding this to emacs-29.
>
> Thanks.

Instead of resending the patch I just went ahead and installed it to
emacs-29.

Steve Berman

Message #17 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>, 68367 <at> debbugs.gnu.org
Cc: Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 07:27:19 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Thanks, but could you please reformat this using `git format-patch -1`?

Ah, I forgot you have commit access.  My bad.

So please just install this on emacs-29.  Thanks in advance.

Message #20 received at 68367 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68367 <at> debbugs.gnu.org
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 07:27:50 -0800

Stephen Berman <stephen.berman <at> gmx.net> writes:

> Instead of resending the patch I just went ahead and installed it to
> emacs-29.

Thanks!

Message #25 received at 68367-done <at> debbugs.gnu.org (full text, mbox):

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68367-done <at> debbugs.gnu.org
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 16:27:21 +0100

On Wed, 10 Jan 2024 16:26:21 +0100 Stephen Berman <stephen.berman <at> gmx.net> wrote:

> On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas <stefankangas <at> gmail.com> wrote:
>
>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>
>>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
>>> cgroup v2 instead of cgroup for cgroup v1).  I just learned about
>>> etc-fstab-generic-mode and after loading generic-x and visiting
>>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
>>> column is fontified in the default face, not in font-lock-keyword-face,
>>> unlike all other file system types in my /etc/fstab file.  This patch
>>> fixes the misfontification:
>>>
>>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
>>> index b4ae0225943..373bfad92dd 100644
>>> --- a/lisp/generic-x.el
>>> +++ b/lisp/generic-x.el
>>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>>>      "cd9660"
>>>      "cfs"
>>>      "cgroup"
>>> +    "cgroup2"
>>>      "cifs"
>>>      "coda"
>>>      "coherent"
>>
>> Thanks, but could you please reformat this using `git format-patch -1`?
>
> On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>>> From: Stefan Kangas <stefankangas <at> gmail.com>
>>> Date: Wed, 10 Jan 2024 06:55:30 -0800
>>> Cc: Eli Zaretskii <eliz <at> gnu.org>
>>>
>>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>>> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>>
>>> > While the misfontification isn't a regression -- the support for cgroups
>>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
>>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
>>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
>>> > omitting cgroup2 was presumably an oversight in that commit.
>>>
>>> I don't really have an opinion, but sounds good to me.  Eli?
>>
>> I don't mind adding this to emacs-29.
>>
>> Thanks.
>
> Instead of resending the patch I just went ahead and installed it to
> emacs-29.

And now closed the bug.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.