GNU bug report logs - #68367
30.0.50; etc-fstab-generic-mode is missing cgroup2

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stephen Berman <stephen.berman <at> gmx.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68367: closed (30.0.50; etc-fstab-generic-mode is missing
 cgroup2)
Date: Wed, 10 Jan 2024 15:28:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 10 Jan 2024 16:27:21 +0100
with message-id <87cyu9mco6.fsf <at> gmx.net>
and subject line Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
has caused the debbugs.gnu.org bug report #68367,
regarding 30.0.50; etc-fstab-generic-mode is missing cgroup2
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68367: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68367
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stephen Berman <stephen.berman <at> gmx.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 14:31:32 +0100

[Message part 3 (text/plain, inline)]

My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
cgroup v2 instead of cgroup for cgroup v1).  I just learned about
etc-fstab-generic-mode and after loading generic-x and visiting
/etc/fstab, I saw that in the line for cgroup2, the entry in the type
column is fontified in the default face, not in font-lock-keyword-face,
unlike all other file system types in my /etc/fstab file.  This patch
fixes the misfontification:

[Message part 4 (text/x-patch, inline)]

diff --git a/lisp/generic-x.el b/lisp/generic-x.el
index b4ae0225943..373bfad92dd 100644
--- a/lisp/generic-x.el
+++ b/lisp/generic-x.el
@@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
     "cd9660"
     "cfs"
     "cgroup"
+    "cgroup2"
     "cifs"
     "coda"
     "coherent"

[Message part 5 (text/plain, inline)]

While the misfontification isn't a regression -- the support for cgroups
(but only for cgroup v1) in etc-fstab-generic-mode was added in January
2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
omitting cgroup2 was presumably an oversight in that commit.


In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
 3.24.38, cairo version 1.18.0) of 2024-01-09 built on strobelfs2
Repository revision: fccaeabc959f5403ce49744030bd2620352b59f8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: Linux From Scratch r12.0-112

[Message part 6 (message/rfc822, inline)]

From: Stephen Berman <stephen.berman <at> gmx.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 68367-done <at> debbugs.gnu.org
Subject: Re: bug#68367: 30.0.50; etc-fstab-generic-mode is missing cgroup2
Date: Wed, 10 Jan 2024 16:27:21 +0100

On Wed, 10 Jan 2024 16:26:21 +0100 Stephen Berman <stephen.berman <at> gmx.net> wrote:

> On Wed, 10 Jan 2024 06:55:30 -0800 Stefan Kangas <stefankangas <at> gmail.com> wrote:
>
>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>
>>> My /etc/fstab file contains a line for the file system cgroup2 (i.e. for
>>> cgroup v2 instead of cgroup for cgroup v1).  I just learned about
>>> etc-fstab-generic-mode and after loading generic-x and visiting
>>> /etc/fstab, I saw that in the line for cgroup2, the entry in the type
>>> column is fontified in the default face, not in font-lock-keyword-face,
>>> unlike all other file system types in my /etc/fstab file.  This patch
>>> fixes the misfontification:
>>>
>>> diff --git a/lisp/generic-x.el b/lisp/generic-x.el
>>> index b4ae0225943..373bfad92dd 100644
>>> --- a/lisp/generic-x.el
>>> +++ b/lisp/generic-x.el
>>> @@ -1491,6 +1491,7 @@ etc-fstab-generic-mode
>>>      "cd9660"
>>>      "cfs"
>>>      "cgroup"
>>> +    "cgroup2"
>>>      "cifs"
>>>      "coda"
>>>      "coherent"
>>
>> Thanks, but could you please reformat this using `git format-patch -1`?
>
> On Wed, 10 Jan 2024 17:07:26 +0200 Eli Zaretskii <eliz <at> gnu.org> wrote:
>
>>> From: Stefan Kangas <stefankangas <at> gmail.com>
>>> Date: Wed, 10 Jan 2024 06:55:30 -0800
>>> Cc: Eli Zaretskii <eliz <at> gnu.org>
>>>
>>> Stephen Berman via "Bug reports for GNU Emacs, the Swiss army knife of
>>> text editors" <bug-gnu-emacs <at> gnu.org> writes:
>>>
>>> > While the misfontification isn't a regression -- the support for cgroups
>>> > (but only for cgroup v1) in etc-fstab-generic-mode was added in January
>>> > 2021 (commit 80d964ec8b) -- the fix could go into emacs-29, since cgroup
>>> > v2 became official in the Linux kernel in March 2016 (kernel 4.5); i.e.,
>>> > omitting cgroup2 was presumably an oversight in that commit.
>>>
>>> I don't really have an opinion, but sounds good to me.  Eli?
>>
>> I don't mind adding this to emacs-29.
>>
>> Thanks.
>
> Instead of resending the patch I just went ahead and installed it to
> emacs-29.

And now closed the bug.

Steve Berman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.