GNU bug report logs - #68228
[PATCH] gnu: Add gnome-software.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68228 in the body.
You can then email your comments to 68228 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <terramorpha <at> cock.li>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add gnome-software.
Date: Wed, 03 Jan 2024 01:30:38 -0500

[Message part 1 (text/plain, inline)]

Hi. This is a patch for gnome-software.

Cheers.

[0001-gnu-Add-gnome-software.patch (text/x-patch, attachment)]

Message #8 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Justin Veilleux <terramorpha <at> cock.li>
Cc: 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH] gnu: Add gnome-software.
Date: Thu, 04 Jan 2024 13:41:35 +0100

Hello,

> Hi. This is a patch for gnome-software.

I tried out this package but it complains about a missing .service for
PackageKit. Have you fixed that issue locally?

Is there any software that can be installed using the gnome-software
on Guix System in the first place?

Thanks,

Mathieu

Message #11 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <terramorpha <at> cock.li>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH] gnu: Add gnome-software.
Date: Thu, 04 Jan 2024 12:36:10 -0500

[Message part 1 (text/plain, inline)]

Hello. For it to work, it needs to be installed in a profile.

For now, it can be used to install flatpaks

Cheers.

On January 4, 2024 7:41:35 a.m. EST, Mathieu Othacehe <othacehe <at> gnu.org> wrote:
>
>Hello,
>
>> Hi. This is a patch for gnome-software.
>
>I tried out this package but it complains about a missing .service for
>PackageKit. Have you fixed that issue locally?
>
>Is there any software that can be installed using the gnome-software
>on Guix System in the first place?
>
>Thanks,
>
>Mathieu

[Message part 2 (text/html, inline)]

Message #17 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>
Subject: [PATCH v2] gnu: Add gnome-software.
Date: Sun, 16 Mar 2025 19:18:26 +0100

From: terramorpha <terramorpha <at> cock.li>

* gnu/packages/gnome.scm (gnome-software): New variable.

Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
---
 gnu/packages/gnome.scm | 70 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7705ba0513..fbecc886c8 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -79,6 +79,8 @@
 ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
 ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
+;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
+;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages file-systems)
+  #:use-module (gnu packages firmware)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages game-development)
@@ -14594,3 +14597,70 @@ (define-public lock
     (description "This package provides a graphical frontend for
 GNU Privacy Guard built with libadwaita.")
     (license license:expat)))
+
+(define-public gnome-software
+  (package
+    (name "gnome-software")
+    (version "46.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "mirror://gnome/sources/"
+                       name "/"
+                       (version-major version) "/"
+                       name "-" version ".tar.xz"))
+       (sha256 (base32 "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
+    (native-inputs
+     (list
+      pkg-config
+      (list glib "bin")
+      gettext-minimal
+      gtk-doc))
+    (inputs
+     (list
+      appstream
+      gdk-pixbuf
+      libxmlb
+      gtk
+      json-glib
+      libadwaita
+      libglib-testing
+      valgrind
+      polkit
+      packagekit
+      flatpak
+      libostree
+      libsoup-minimal-2
+      malcontent
+      libgudev
+      sysprof
+      fwupd))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:glib-or-gtk? #t
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-iso-codes
+            (lambda* (#:key native-inputs inputs #:allow-other-keys)
+              (with-directory-excursion
+                  "src"
+                (substitute* "./gs-language.c"
+                  (("DATADIR")
+                   (format #f "\"~a/share\"" #$iso-codes)))
+                (invoke "cat" "gs-language.c"))))
+          (add-after 'unpack 'disable-gtk-update-icon-cache
+            (lambda _
+              (setenv "DESTDIR" "/"))))
+      #:configure-flags
+      ''("-Dsoup2=true"
+         "-Dman=false"                  ;tries to access the internet
+         "-Dhardcoded_proprietary_webapps=false")
+      #:tests? #f
+      #:validate-runpath? #f))
+    (synopsis "Graphical software manager for gnome")
+    (description "Software allows you to find and install new apps and system
+extensions and remove existing installed apps.")
+    (license license:gpl2)
+    (home-page "https://apps.gnome.org/en/Software/")))

base-commit: 8a565a8ff1c2150b778b5fdf8aa3a5f59a3fce9d
-- 
2.48.1

Message #20 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v2] gnu: Add gnome-software.
Date: Sun, 16 Mar 2025 20:38:45 +0100

Am Sonntag, dem 16.03.2025 um 19:18 +0100 schrieb Noé Lopez:
> From: terramorpha <terramorpha <at> cock.li>
> 
> * gnu/packages/gnome.scm (gnome-software): New variable.
> 
> Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
> ---
>  gnu/packages/gnome.scm | 70
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 7705ba0513..fbecc886c8 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -79,6 +79,8 @@
>  ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
>  ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
>  ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
> +;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
> +;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages file-systems)
> +  #:use-module (gnu packages firmware)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages game-development)
> @@ -14594,3 +14597,70 @@ (define-public lock
>      (description "This package provides a graphical frontend for
>  GNU Privacy Guard built with libadwaita.")
>      (license license:expat)))
> +
> +(define-public gnome-software
> +  (package
> +    (name "gnome-software")
> +    (version "46.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "mirror://gnome/sources/"
> +                       name "/"
> +                       (version-major version) "/"
> +                       name "-" version ".tar.xz"))
> +       (sha256 (base32
> "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
> +    (native-inputs
> +     (list
> +      pkg-config
> +      (list glib "bin")
> +      gettext-minimal
> +      gtk-doc))
> +    (inputs
> +     (list
> +      appstream
> +      gdk-pixbuf
> +      libxmlb
> +      gtk
> +      json-glib
> +      libadwaita
> +      libglib-testing
> +      valgrind
> +      polkit
> +      packagekit
> +      flatpak
> +      libostree
> +      libsoup-minimal-2
> +      malcontent
> +      libgudev
> +      sysprof
> +      fwupd))
Inputs should be after build-system+arguments.
Please sort them.  You can also likely save two lines there, depending
on how far you want to indent.
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-iso-codes
> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)
> +              (with-directory-excursion
> +                  "src"
> +                (substitute* "./gs-language.c"
> +                  (("DATADIR")
> +                   (format #f "\"~a/share\"" #$iso-codes)))
> +                (invoke "cat" "gs-language.c"))))
> +          (add-after 'unpack 'disable-gtk-update-icon-cache
> +            (lambda _
> +              (setenv "DESTDIR" "/"))))
#:phases should typically be put last
> +      #:configure-flags
> +      ''("-Dsoup2=true"
> +         "-Dman=false"                  ;tries to access the
> internet
> +         "-Dhardcoded_proprietary_webapps=false")
Use #~(list …)
> +      #:tests? #f
Don't leave this undocumented.
> +      #:validate-runpath? #f))
I doubt that this one should even be used, but again: explain yourself.
> +    (synopsis "Graphical software manager for gnome")
> +    (description "Software allows you to find and install new apps
> and system
> +extensions and remove existing installed apps.")
> +    (license license:gpl2)
Is this really GPL2 only?  If not, use gpl2+
> +    (home-page "https://apps.gnome.org/en/Software/")))

Most importantly: does it work?  Can you do something with it?

Cheers

Message #23 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v2] gnu: Add gnome-software.
Date: Sun, 16 Mar 2025 23:09:52 +0100

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 16.03.2025 um 19:18 +0100 schrieb Noé Lopez:
>> From: terramorpha <terramorpha <at> cock.li>
>> 
>> * gnu/packages/gnome.scm (gnome-software): New variable.
>> 
>> Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
>> ---
>>  gnu/packages/gnome.scm | 70
>> ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 70 insertions(+)
>> 
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 7705ba0513..fbecc886c8 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -79,6 +79,8 @@
>>  ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
>>  ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
>>  ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
>> +;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
>> +;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
>>    #:use-module (gnu packages flex)
>>    #:use-module (gnu packages fonts)
>>    #:use-module (gnu packages file-systems)
>> +  #:use-module (gnu packages firmware)
>>    #:use-module (gnu packages fontutils)
>>    #:use-module (gnu packages freedesktop)
>>    #:use-module (gnu packages game-development)
>> @@ -14594,3 +14597,70 @@ (define-public lock
>>      (description "This package provides a graphical frontend for
>>  GNU Privacy Guard built with libadwaita.")
>>      (license license:expat)))
>> +
>> +(define-public gnome-software
>> +  (package
>> +    (name "gnome-software")
>> +    (version "46.5")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri
>> +        (string-append "mirror://gnome/sources/"
>> +                       name "/"
>> +                       (version-major version) "/"
>> +                       name "-" version ".tar.xz"))
>> +       (sha256 (base32
>> "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
>> +    (native-inputs
>> +     (list
>> +      pkg-config
>> +      (list glib "bin")
>> +      gettext-minimal
>> +      gtk-doc))
>> +    (inputs
>> +     (list
>> +      appstream
>> +      gdk-pixbuf
>> +      libxmlb
>> +      gtk
>> +      json-glib
>> +      libadwaita
>> +      libglib-testing
>> +      valgrind
>> +      polkit
>> +      packagekit
>> +      flatpak
>> +      libostree
>> +      libsoup-minimal-2
>> +      malcontent
>> +      libgudev
>> +      sysprof
>> +      fwupd))
> Inputs should be after build-system+arguments.
> Please sort them.  You can also likely save two lines there, depending
> on how far you want to indent.
>> +    (build-system meson-build-system)
>> +    (arguments
>> +     (list
>> +      #:glib-or-gtk? #t
>> +      #:phases
>> +      #~(modify-phases %standard-phases
>> +          (add-after 'unpack 'patch-iso-codes
>> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)
>> +              (with-directory-excursion
>> +                  "src"
>> +                (substitute* "./gs-language.c"
>> +                  (("DATADIR")
>> +                   (format #f "\"~a/share\"" #$iso-codes)))
>> +                (invoke "cat" "gs-language.c"))))
>> +          (add-after 'unpack 'disable-gtk-update-icon-cache
>> +            (lambda _
>> +              (setenv "DESTDIR" "/"))))
> #:phases should typically be put last
>> +      #:configure-flags
>> +      ''("-Dsoup2=true"
>> +         "-Dman=false"                  ;tries to access the
>> internet
>> +         "-Dhardcoded_proprietary_webapps=false")
> Use #~(list …)
>> +      #:tests? #f
> Don't leave this undocumented.
>> +      #:validate-runpath? #f))
> I doubt that this one should even be used, but again: explain yourself.
>> +    (synopsis "Graphical software manager for gnome")
>> +    (description "Software allows you to find and install new apps
>> and system
>> +extensions and remove existing installed apps.")
>> +    (license license:gpl2)
> Is this really GPL2 only?  If not, use gpl2+
>> +    (home-page "https://apps.gnome.org/en/Software/")))
>

Thanks for the fast review, I’m sending an updated patch with everything
fixed.

> Most importantly: does it work?  Can you do something with it?

It does work!  If you want some apps to appear you need two things: an
active packagekit backend and the corresponding AppStream catalog.  For
example installing flatpak and flathub should make all of flathub
available.  There are also some progressive web apps bundled, I haven’t
tried them.

As for Guix packages, I’m currently working on the integration and
looking for a mentor to review some bits:
https://lists.gnu.org/archive/html/guix-devel/2025-03/msg00003.html

Have a nice day,
Noé

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>
Subject: [PATCH v3] gnu: Add gnome-software.
Date: Sun, 16 Mar 2025 23:10:40 +0100

From: terramorpha <terramorpha <at> cock.li>

* gnu/packages/gnome.scm (gnome-software): New variable.

Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
---
 gnu/packages/gnome.scm | 69 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7705ba0513..26ca4a721c 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -79,6 +79,8 @@
 ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
 ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
+;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
+;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages file-systems)
+  #:use-module (gnu packages firmware)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages game-development)
@@ -14594,3 +14597,69 @@ (define-public lock
     (description "This package provides a graphical frontend for
 GNU Privacy Guard built with libadwaita.")
     (license license:expat)))
+
+(define-public gnome-software
+  (package
+    (name "gnome-software")
+    (version "46.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "mirror://gnome/sources/"
+                       name "/"
+                       (version-major version) "/"
+                       name "-" version ".tar.xz"))
+       (sha256 (base32 "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:tests? #f                       ;needs a complete system (/etc/machine-id, dbus)
+      #:glib-or-gtk? #t
+      #:configure-flags
+      #~(list "-Dsoup2=true"
+              "-Dman=false"             ;tries to access the internet
+              "-Dhardcoded_proprietary_webapps=false")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-iso-codes
+            (lambda* (#:key native-inputs inputs #:allow-other-keys)
+              (with-directory-excursion
+                  "src"
+                (substitute* "./gs-language.c"
+                  (("DATADIR")
+                   (format #f "\"~a/share\"" #$iso-codes)))
+                (invoke "cat" "gs-language.c"))))
+          (add-before 'install 'disable-gtk-update-icon-cache
+            (lambda _
+              (setenv "DESTDIR" "/")
+              ;; Needed for complete RUNPATHs, but not actually needed at runtime.
+              (copy-file
+               "../build/lib/libgnomesoftware.so.20"
+               (string-append #$output "/lib/libgnomesoftware.so.20")))))))
+    (native-inputs (list `(,glib "bin")
+                         gettext-minimal
+                         gtk-doc
+                         pkg-config))
+    (inputs (list appstream
+                  flatpak
+                  fwupd
+                  gdk-pixbuf
+                  gtk
+                  json-glib
+                  libadwaita
+                  libglib-testing
+                  libgudev
+                  libostree
+                  libsoup-minimal-2
+                  libxmlb
+                  malcontent
+                  packagekit
+                  polkit
+                  sysprof
+                  valgrind))
+    (synopsis "Graphical software manager for gnome")
+    (description "Software allows you to find and install new apps and system
+extensions and remove existing installed apps.")
+    (license license:gpl2+)
+    (home-page "https://apps.gnome.org/en/Software/")))

base-commit: 8a565a8ff1c2150b778b5fdf8aa3a5f59a3fce9d
-- 
2.48.1

Message #29 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Mon, 17 Mar 2025 06:19:51 +0100

Am Sonntag, dem 16.03.2025 um 23:10 +0100 schrieb Noé Lopez:
> From: terramorpha <terramorpha <at> cock.li>
> 
> * gnu/packages/gnome.scm (gnome-software): New variable.
> 
> Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
> ---
>  gnu/packages/gnome.scm | 69
> ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> index 7705ba0513..26ca4a721c 100644
> --- a/gnu/packages/gnome.scm
> +++ b/gnu/packages/gnome.scm
> @@ -79,6 +79,8 @@
>  ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
>  ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
>  ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
> +;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
> +;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
>    #:use-module (gnu packages flex)
>    #:use-module (gnu packages fonts)
>    #:use-module (gnu packages file-systems)
> +  #:use-module (gnu packages firmware)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages game-development)
> @@ -14594,3 +14597,69 @@ (define-public lock
>      (description "This package provides a graphical frontend for
>  GNU Privacy Guard built with libadwaita.")
>      (license license:expat)))
> +
> +(define-public gnome-software
> +  (package
> +    (name "gnome-software")
> +    (version "46.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "mirror://gnome/sources/"
> +                       name "/"
> +                       (version-major version) "/"
> +                       name "-" version ".tar.xz"))
> +       (sha256 (base32
> "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:tests? #f                       ;needs a complete system
> (/etc/machine-id, dbus)
Can we silence fatal dbus warnings?  Other GNOME packages are tested
e.g. using dbus-run-session.
> +      #:glib-or-gtk? #t
> +      #:configure-flags
> +      #~(list "-Dsoup2=true"
> +              "-Dman=false"             ;tries to access the
> internet
> +              "-Dhardcoded_proprietary_webapps=false")
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-iso-codes
> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)
> +              (with-directory-excursion
> +                  "src"
> +                (substitute* "./gs-language.c"
> +                  (("DATADIR")
> +                   (format #f "\"~a/share\"" #$iso-codes)))
> +                (invoke "cat" "gs-language.c"))))
> +          (add-before 'install 'disable-gtk-update-icon-cache
> +            (lambda _
> +              (setenv "DESTDIR" "/")
> +              ;; Needed for complete RUNPATHs, but not actually
> needed at runtime.
> +              (copy-file
> +               "../build/lib/libgnomesoftware.so.20"
> +               (string-append #$output
> "/lib/libgnomesoftware.so.20")))))))
> +    (native-inputs (list `(,glib "bin")
> +                         gettext-minimal
> +                         gtk-doc
> +                         pkg-config))
> +    (inputs (list appstream
> +                  flatpak
> +                  fwupd
> +                  gdk-pixbuf
> +                  gtk
> +                  json-glib
> +                  libadwaita
> +                  libglib-testing
> +                  libgudev
> +                  libostree
> +                  libsoup-minimal-2
> +                  libxmlb
> +                  malcontent
> +                  packagekit
> +                  polkit
> +                  sysprof
> +                  valgrind))
> +    (synopsis "Graphical software manager for gnome")
> +    (description "Software allows you to find and install new apps
> and system
> +extensions and remove existing installed apps.")
> +    (license license:gpl2+)
> +    (home-page "https://apps.gnome.org/en/Software/")))
> 
> base-commit: 8a565a8ff1c2150b778b5fdf8aa3a5f59a3fce9d

Otherwise LGTM (albeit untested as of now).

Cheers

Message #32 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Mon, 17 Mar 2025 11:15:14 +0100

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Sonntag, dem 16.03.2025 um 23:10 +0100 schrieb Noé Lopez:
>> From: terramorpha <terramorpha <at> cock.li>
>> 
>> * gnu/packages/gnome.scm (gnome-software): New variable.
>> 
>> Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
>> ---
>>  gnu/packages/gnome.scm | 69
>> ++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 69 insertions(+)
>> 
>> diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
>> index 7705ba0513..26ca4a721c 100644
>> --- a/gnu/packages/gnome.scm
>> +++ b/gnu/packages/gnome.scm
>> @@ -79,6 +79,8 @@
>>  ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
>>  ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
>>  ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
>> +;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
>> +;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
>>    #:use-module (gnu packages flex)
>>    #:use-module (gnu packages fonts)
>>    #:use-module (gnu packages file-systems)
>> +  #:use-module (gnu packages firmware)
>>    #:use-module (gnu packages fontutils)
>>    #:use-module (gnu packages freedesktop)
>>    #:use-module (gnu packages game-development)
>> @@ -14594,3 +14597,69 @@ (define-public lock
>>      (description "This package provides a graphical frontend for
>>  GNU Privacy Guard built with libadwaita.")
>>      (license license:expat)))
>> +
>> +(define-public gnome-software
>> +  (package
>> +    (name "gnome-software")
>> +    (version "46.5")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri
>> +        (string-append "mirror://gnome/sources/"
>> +                       name "/"
>> +                       (version-major version) "/"
>> +                       name "-" version ".tar.xz"))
>> +       (sha256 (base32
>> "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
>> +    (build-system meson-build-system)
>> +    (arguments
>> +     (list
>> +      #:tests? #f                       ;needs a complete system
>> (/etc/machine-id, dbus)
> Can we silence fatal dbus warnings?  Other GNOME packages are tested
> e.g. using dbus-run-session.

Surely? The real blocker for me is /etc/machine-id, it seems to need to
exist for most tests to run, and I suspect also the tests that fail with
dbus would fail with it too.

But creating /etc/machine-id leads to a permission error.

>> +      #:glib-or-gtk? #t
>> +      #:configure-flags
>> +      #~(list "-Dsoup2=true"
>> +              "-Dman=false"             ;tries to access the
>> internet
>> +              "-Dhardcoded_proprietary_webapps=false")
>> +      #:phases
>> +      #~(modify-phases %standard-phases
>> +          (add-after 'unpack 'patch-iso-codes
>> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)
>> +              (with-directory-excursion
>> +                  "src"
>> +                (substitute* "./gs-language.c"
>> +                  (("DATADIR")
>> +                   (format #f "\"~a/share\"" #$iso-codes)))
>> +                (invoke "cat" "gs-language.c"))))
>> +          (add-before 'install 'disable-gtk-update-icon-cache
>> +            (lambda _
>> +              (setenv "DESTDIR" "/")
>> +              ;; Needed for complete RUNPATHs, but not actually
>> needed at runtime.
>> +              (copy-file
>> +               "../build/lib/libgnomesoftware.so.20"
>> +               (string-append #$output
>> "/lib/libgnomesoftware.so.20")))))))
>> +    (native-inputs (list `(,glib "bin")
>> +                         gettext-minimal
>> +                         gtk-doc
>> +                         pkg-config))
>> +    (inputs (list appstream
>> +                  flatpak
>> +                  fwupd
>> +                  gdk-pixbuf
>> +                  gtk
>> +                  json-glib
>> +                  libadwaita
>> +                  libglib-testing
>> +                  libgudev
>> +                  libostree
>> +                  libsoup-minimal-2
>> +                  libxmlb
>> +                  malcontent
>> +                  packagekit
>> +                  polkit
>> +                  sysprof
>> +                  valgrind))
>> +    (synopsis "Graphical software manager for gnome")
>> +    (description "Software allows you to find and install new apps
>> and system
>> +extensions and remove existing installed apps.")
>> +    (license license:gpl2+)
>> +    (home-page "https://apps.gnome.org/en/Software/")))
>> 
>> base-commit: 8a565a8ff1c2150b778b5fdf8aa3a5f59a3fce9d
>
> Otherwise LGTM (albeit untested as of now).

Great!

[signature.asc (application/pgp-signature, inline)]

Message #35 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Mon, 17 Mar 2025 19:01:06 +0100

Am Montag, dem 17.03.2025 um 11:15 +0100 schrieb Noé Lopez:
> Surely? The real blocker for me is /etc/machine-id, it seems to need
> to exist for most tests to run, and I suspect also the tests that
> fail with dbus would fail with it too.
> 
> But creating /etc/machine-id leads to a permission error.
Does anything actually read this file?  Because if not, that's just a
dbus warning that can be made non-fatal by setting the appropriate
environment variable.

Cheers

Message #38 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Tue, 18 Mar 2025 00:32:32 +0100

[Message part 1 (text/plain, inline)]

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:

> Am Montag, dem 17.03.2025 um 11:15 +0100 schrieb Noé Lopez:
>> Surely? The real blocker for me is /etc/machine-id, it seems to need
>> to exist for most tests to run, and I suspect also the tests that
>> fail with dbus would fail with it too.
>> 
>> But creating /etc/machine-id leads to a permission error.
> Does anything actually read this file?  Because if not, that's just a
> dbus warning that can be made non-fatal by setting the appropriate
> environment variable.
>

I got confused, because the fatal warning was actually made by
gnome-software (to check if it would be able to start dbus!!!).  I
deleted the warning, and added a dbus session, but now its requiring a
dbus system session.  Do you know of any way to start one? I couldn’t
find any packages doing this, and dbus-daemon --system fails miserably
(tries to access /var/run/dbus/system_bus_socket).

Thanks,
Noé

[signature.asc (application/pgp-signature, inline)]

Message #41 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Tue, 18 Mar 2025 15:45:22 +0900

Hi,

Noé Lopez <noe <at> noé.eu> writes:

> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>
>> Am Montag, dem 17.03.2025 um 11:15 +0100 schrieb Noé Lopez:
>>> Surely? The real blocker for me is /etc/machine-id, it seems to need
>>> to exist for most tests to run, and I suspect also the tests that
>>> fail with dbus would fail with it too.
>>> 
>>> But creating /etc/machine-id leads to a permission error.
>> Does anything actually read this file?  Because if not, that's just a
>> dbus warning that can be made non-fatal by setting the appropriate
>> environment variable.
>>
>
> I got confused, because the fatal warning was actually made by
> gnome-software (to check if it would be able to start dbus!!!).  I
> deleted the warning, and added a dbus session, but now its requiring a
> dbus system session.  Do you know of any way to start one? I couldn’t
> find any packages doing this, and dbus-daemon --system fails miserably
> (tries to access /var/run/dbus/system_bus_socket).

Did you inspect their CI script/workflow file for clues?

-- 
Thanks,
Maxim

Message #44 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: terramorpha <terramorpha <at> cock.li>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Vivien Kraus <vivien <at> planete-kraus.eu>, 68228 <at> debbugs.gnu.org,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v2] gnu: Add gnome-software.
Date: Tue, 18 Mar 2025 15:55:43 +0900

Hi,

Noé Lopez <noe <at> noé.eu> writes:

[...]

> +    (native-inputs
> +     (list
> +      pkg-config
> +      (list glib "bin")
> +      gettext-minimal
> +      gtk-doc))

Nitpick, but it is more conventional to format inputs as:

--8<---------------cut here---------------start------------->8---
       (native-inputs
        (list first
              second
              ...))
--8<---------------cut here---------------end--------------->8---

> +    (inputs
> +     (list
> +      appstream
> +      gdk-pixbuf
> +      libxmlb
> +      gtk
> +      json-glib
> +      libadwaita
> +      libglib-testing
> +      valgrind
> +      polkit
> +      packagekit
> +      flatpak
> +      libostree
> +      libsoup-minimal-2
> +      malcontent
> +      libgudev
> +      sysprof
> +      fwupd))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:glib-or-gtk? #t
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-iso-codes
> +            (lambda* (#:key native-inputs inputs #:allow-other-keys)

Since you aren't using the arguments, this should be a
--8<---------------cut here---------------start------------->8---
   (lambda _
    [...]
--8<---------------cut here---------------end--------------->8---

> +              (with-directory-excursion
> +                  "src"

Please format this as

--8<---------------cut here---------------start------------->8---
(with-directory-excursion "src"
 (substitute* [...]))
--8<---------------cut here---------------end--------------->8---

Otherwise I agree with Liliana's comments.  Thank you for working on
this!

-- 
Thanks,
Maxim

Message #47 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v2] gnu: Add gnome-software.
Date: Tue, 18 Mar 2025 15:57:12 +0900

Hi Noé,

Noé Lopez <noe <at> noé.eu> writes:

[...]

> As for Guix packages, I’m currently working on the integration and
> looking for a mentor to review some bits:
> https://lists.gnu.org/archive/html/guix-devel/2025-03/msg00003.html

Can't promise anything, but I have an interest in seeing this
accomplished, would be happy to have a look and try to help, as time
allows.

-- 
Thanks,
Maxim

Message #50 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Tue, 18 Mar 2025 19:09:16 +0100

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi,
>
> Noé Lopez <noe <at> noé.eu> writes:
>
>> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>>
>>> Am Montag, dem 17.03.2025 um 11:15 +0100 schrieb Noé Lopez:
>>>> Surely? The real blocker for me is /etc/machine-id, it seems to need
>>>> to exist for most tests to run, and I suspect also the tests that
>>>> fail with dbus would fail with it too.
>>>> 
>>>> But creating /etc/machine-id leads to a permission error.
>>> Does anything actually read this file?  Because if not, that's just a
>>> dbus warning that can be made non-fatal by setting the appropriate
>>> environment variable.
>>>
>>
>> I got confused, because the fatal warning was actually made by
>> gnome-software (to check if it would be able to start dbus!!!).  I
>> deleted the warning, and added a dbus session, but now its requiring a
>> dbus system session.  Do you know of any way to start one? I couldn’t
>> find any packages doing this, and dbus-daemon --system fails miserably
>> (tries to access /var/run/dbus/system_bus_socket).
>
> Did you inspect their CI script/workflow file for clues?
>

Good idea, but it seems they are just using a full Docker image so no
help there it seems.

[signature.asc (application/pgp-signature, inline)]

Message #53 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Wed, 19 Mar 2025 21:02:35 +0900

Hi Noé,

Noé Lopez <noe <at> noé.eu> writes:

[...]

>> Did you inspect their CI script/workflow file for clues?
>>
>
> Good idea, but it seems they are just using a full Docker image so no
> help there it seems.

Docker, when using a single container (outside of 'docker compose')
isn't appropriate to run multiple services (it's designed to run a
single process, IIRC).  So it may be interesting to see how they managed
to run a system dbus service there on top of the test.

-- 
Thanks,
Maxim

Message #56 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228 <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v3] gnu: Add gnome-software.
Date: Wed, 19 Mar 2025 15:33:42 +0100

[Message part 1 (text/plain, inline)]

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> writes:

> Hi Noé,
>
> Noé Lopez <noe <at> noé.eu> writes:
>
> [...]
>
>>> Did you inspect their CI script/workflow file for clues?
>>>
>>
>> Good idea, but it seems they are just using a full Docker image so no
>> help there it seems.
>
> Docker, when using a single container (outside of 'docker compose')
> isn't appropriate to run multiple services (it's designed to run a
> single process, IIRC).  So it may be interesting to see how they managed
> to run a system dbus service there on top of the test.
>

Docker can have multiple processes, and they start dbus like this:
sudo mkdir -p /run/dbus
sudo mkdir -p /var
sudo ln -s /var/run /run
sudo dbus-daemon --system --fork

The mkdir part which we can’t do AFAIK for lack of permissions.

I’m sending a v4 with the other tests enabled.

Have a nice day,
Noé

[signature.asc (application/pgp-signature, inline)]

Message #59 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Noé Lopez <noe <at> xn--no-cja.eu>
To: 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>
Subject: [PATCH v4] gnu: Add gnome-software.
Date: Wed, 19 Mar 2025 15:36:44 +0100

From: terramorpha <terramorpha <at> cock.li>

* gnu/packages/gnome.scm (gnome-software): New variable.

Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
---
 gnu/packages/gnome.scm | 69 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 69 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index 7705ba0513..221137473d 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -79,6 +79,8 @@
 ;;; Copyright © 2023 Zhu Zihao <all_but_last <at> 163.com>
 ;;; Copyright © 2024 Dariqq <dariqq <at> posteo.net>
 ;;; Copyright © 2024 James Smith <jsubuntuxp <at> disroot.org>
+;;; Copyright © 2024 Justin Veilleux <terramorpha <at> cock.li>
+;;; Copyright © 2025 Noé Lopez <noelopez <at> free.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -135,6 +137,7 @@ (define-module (gnu packages gnome)
   #:use-module (gnu packages flex)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages file-systems)
+  #:use-module (gnu packages firmware)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
   #:use-module (gnu packages game-development)
@@ -14594,3 +14597,69 @@ (define-public lock
     (description "This package provides a graphical frontend for
 GNU Privacy Guard built with libadwaita.")
     (license license:expat)))
+
+(define-public gnome-software
+  (package
+    (name "gnome-software")
+    (version "46.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri
+        (string-append "mirror://gnome/sources/"
+                       name "/"
+                       (version-major version) "/"
+                       name "-" version ".tar.xz"))
+       (sha256 (base32 "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
+    (build-system meson-build-system)
+    (arguments
+     (list
+      #:test-options #~(list "--no-suite=plugins") ;needs a dbus-system
+      #:glib-or-gtk? #t
+      #:configure-flags
+      #~(list "-Dsoup2=true"
+              "-Dman=false"             ;tries to access the internet
+              "-Dhardcoded_proprietary_webapps=false")
+      #:phases
+      #~(modify-phases %standard-phases
+          (add-after 'unpack 'patch-iso-codes
+            (lambda _
+              (with-directory-excursion "src"
+                (substitute* "./gs-language.c"
+                  (("DATADIR")
+                   (format #f "\"~a/share\"" #$iso-codes))))))
+          (add-before 'install 'disable-gtk-update-icon-cache
+            (lambda _
+              (setenv "DESTDIR" "/")
+              ;; Needed for complete RUNPATHs, but not actually needed at runtime.
+              (copy-file
+               "../build/lib/libgnomesoftware.so.20"
+               (string-append #$output "/lib/libgnomesoftware.so.20")))))))
+    (native-inputs
+     (list `(,glib "bin")
+           gettext-minimal
+           gtk-doc
+           pkg-config))
+    (inputs
+     (list appstream
+           flatpak
+           fwupd
+           gdk-pixbuf
+           gtk
+           json-glib
+           libadwaita
+           libglib-testing
+           libgudev
+           libostree
+           libsoup-minimal-2
+           libxmlb
+           malcontent
+           packagekit
+           polkit
+           sysprof
+           valgrind))
+    (synopsis "Graphical software manager for gnome")
+    (description "Software allows you to find and install new apps and system
+extensions and remove existing installed apps.")
+    (license license:gpl2+)
+    (home-page "https://apps.gnome.org/en/Software/")))

base-commit: 8a565a8ff1c2150b778b5fdf8aa3a5f59a3fce9d
-- 
2.48.1

Message #62 received at 68228 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>, 68228 <at> debbugs.gnu.org
Cc: terramorpha <terramorpha <at> cock.li>, Vivien Kraus <vivien <at> planete-kraus.eu>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Mathieu Othacehe <othacehe <at> gnu.org>
Subject: Re: [bug#68228] [PATCH v4] gnu: Add gnome-software.
Date: Wed, 19 Mar 2025 15:55:52 +0100

Am Mittwoch, dem 19.03.2025 um 15:36 +0100 schrieb Noé Lopez:
> From: terramorpha <terramorpha <at> cock.li>
> 
> * gnu/packages/gnome.scm (gnome-software): New variable.
> 
> Change-Id: I5838a581d8612eed0697c801fff0e241256ce558
> ---
LGTM!

Maxim et al, WDYT?

Message #67 received at 68228-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Noé Lopez <noe <at> xn--no-cja.eu>
Cc: terramorpha <terramorpha <at> cock.li>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Vivien Kraus <vivien <at> planete-kraus.eu>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>, 68228-done <at> debbugs.gnu.org
Subject: Re: [bug#68228] [PATCH v4] gnu: Add gnome-software.
Date: Thu, 20 Mar 2025 14:49:02 +0900

Hi,

Noé Lopez <noe <at> noé.eu> writes:

> From: terramorpha <terramorpha <at> cock.li>
>
> * gnu/packages/gnome.scm (gnome-software): New variable.

A 2nd look on it from my side.  Apologies for failing to mention these
in my first look.

[...]

> +(define-public gnome-software
> +  (package
> +    (name "gnome-software")
> +    (version "46.5")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri
> +        (string-append "mirror://gnome/sources/"
> +                       name "/"
> +                       (version-major version) "/"
> +                       name "-" version ".tar.xz"))
> +       (sha256 (base32 "0b5y9z64582aarw3v92wjm63yib2q85ylny1k7k4d2y48jivirb9"))))
> +    (build-system meson-build-system)
> +    (arguments
> +     (list
> +      #:test-options #~(list "--no-suite=plugins") ;needs a dbus-system
> +      #:glib-or-gtk? #t
> +      #:configure-flags
> +      #~(list "-Dsoup2=true"

Why forcing libsoup2?  libsoup2 is deprecated in GNOME; we should be
using the newer version.  If there are problems, it should be ideally
resolved, failing that at least a comment should appear above to explain
why we force libsoup2.

From meson.build, it seems we should be able to use libsoup v3:

--8<---------------cut here---------------start------------->8---
if get_option('soup2')
  libsoup = dependency('libsoup-2.4', version : '>= 2.52.0')
  libsoupapiversion = '2.4'
  conf.set('SOUP_HTTP_URI_FLAGS', '(G_URI_FLAGS_HAS_PASSWORD | G_URI_FLAGS_ENCODED_PATH | G_URI_FLAGS_ENCODED_QUERY | G_URI_FLAGS_ENCODED_FRAGMENT | G_URI_FLAGS_SCHEME_NORMALIZE)')
else
  libsoup = dependency('libsoup-3.0', version : '>= 3.0')
  libsoupapiversion = '3.0'
endif
--8<---------------cut here---------------end--------------->8---


> +              "-Dman=false"             ;tries to access the internet

That surprises me!  Looking at src/meson.build, I see:

--8<---------------cut here---------------start------------->8---
if get_option('man')
  xsltproc = find_program('xsltproc')
  custom_target('manfile-gnome-software',
    input: 'gnome-software.xml',
    output: 'gnome-software.1',
    install: true,
    install_dir: join_paths(get_option('mandir'), 'man1'),
    command: [
      xsltproc,
      '--nonet',
      '--stringparam', 'man.output.quietly', '1',
      '--stringparam', 'funcsynopsis.style', 'ansi',
      '--stringparam', 'man.th.extra1.suppress', '1',
      '--stringparam', 'man.authors.section.enabled', '0',
      '--stringparam', 'man.copyright.section.enabled', '0',
      '-o', '@OUTPUT@',
      'http://docbook.sourceforge.net/release/xsl/current/manpages/docbook.xsl',
      '@INPUT@'
    ]
  )
endif
--8<---------------cut here---------------end--------------->8---

We were just missing the docbook-xsl and libxslt packages as native
inputs.

> +              "-Dhardcoded_proprietary_webapps=false")
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'patch-iso-codes
> +            (lambda _
> +              (with-directory-excursion "src"
> +                (substitute* "./gs-language.c"
> +                  (("DATADIR")
> +                   (format #f "\"~a/share\"" #$iso-codes))))))
> +          (add-before 'install 'disable-gtk-update-icon-cache
> +            (lambda _
> +              (setenv "DESTDIR" "/")
> +              ;; Needed for complete RUNPATHs, but not actually needed at runtime.
> +              (copy-file
> +               "../build/lib/libgnomesoftware.so.20"
> +               (string-append #$output "/lib/libgnomesoftware.so.20")))))))

The above lib copying is weird, but it indeed relates to some
post-install script that has to do with generating the icon cache (at
least that's one of the things it does).  Perhaps we could disable this
post-install script instead and avoid that useful library?

> +    (native-inputs
> +     (list `(,glib "bin")
> +           gettext-minimal
> +           gtk-doc
> +           pkg-config))
> +    (inputs
> +     (list appstream
> +           flatpak
> +           fwupd
> +           gdk-pixbuf
> +           gtk
> +           json-glib
> +           libadwaita
> +           libglib-testing

Hm, the above is for some epiphany self-test plugin, which appears
only useful while running the test suite; 'guix size gnome-software'
doesn't list it either, so it can indeed be moved to the native inputs.


> +           libgudev
> +           libostree
> +           libsoup-minimal-2
> +           libxmlb
> +           malcontent
> +           packagekit
> +           polkit
> +           sysprof
> +           valgrind))

sysprof and valgrind should also be moved to native inputs (aka build
time dependencies).

> +    (synopsis "Graphical software manager for gnome")

s/gnome/GNOME/

> +    (description "Software allows you to find and install new apps and system
>

> +extensions and remove existing installed apps.")

I'd use s/apps/applications/, and call it 'GNOME Software' instead of
just 'Software'.

Actually, having tested that hands on, I was satisfied with a version
that implements most of the above changes:

--8<---------------cut here---------------start------------->8---
1 file changed, 18 insertions(+), 14 deletions(-)
gnu/packages/gnome.scm | 32 ++++++++++++++++++--------------

modified   gnu/packages/gnome.scm
@@ -14616,12 +14616,13 @@ (define-public gnome-software
     (build-system meson-build-system)
     (arguments
      (list
-      #:test-options #~(list "--no-suite=plugins") ;needs a dbus-system
+      #:test-options
+      ;; The plugins test suite requires a D-Bus system session, which
+      ;; attempts to set its session under /var/run and fails.
+      #~(list "--no-suite=plugins")
       #:glib-or-gtk? #t
       #:configure-flags
-      #~(list "-Dsoup2=true"
-              "-Dman=false"             ;tries to access the internet
-              "-Dhardcoded_proprietary_webapps=false")
+      #~(list "-Dhardcoded_proprietary_webapps=false")
       #:phases
       #~(modify-phases %standard-phases
           (add-after 'unpack 'patch-iso-codes
@@ -14638,10 +14639,15 @@ (define-public gnome-software
                "../build/lib/libgnomesoftware.so.20"
                (string-append #$output "/lib/libgnomesoftware.so.20")))))))
     (native-inputs
-     (list `(,glib "bin")
+     (list docbook-xsl
            gettext-minimal
+           `(,glib "bin")
            gtk-doc
-           pkg-config))
+           libglib-testing
+           libxslt                      ;for xsltproc
+           pkg-config
+           sysprof
+           valgrind))
     (inputs
      (list appstream
            flatpak
@@ -14650,18 +14656,16 @@ (define-public gnome-software
            gtk
            json-glib
            libadwaita
-           libglib-testing
            libgudev
            libostree
-           libsoup-minimal-2
+           libsoup-minimal
            libxmlb
            malcontent
            packagekit
-           polkit
-           sysprof
-           valgrind))
-    (synopsis "Graphical software manager for gnome")
-    (description "Software allows you to find and install new apps and system
-extensions and remove existing installed apps.")
+           polkit))
+    (synopsis "Graphical software manager for GNOME")
+    (description "GNOME Software allows you to find and install new
+applications and system extensions and remove existing installed
+applications.")
     (license license:gpl2+)
     (home-page "https://apps.gnome.org/en/Software/")))

--8<---------------cut here---------------end--------------->8---

So I've already pushed it as commit 77ff73a920, add myself as co-author
via a git trailer in the commit message.

To be able to use libsoup 3, I had to update ostree first to have it use
libsoup 3 as well.

Thank you!

-- 
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.