GNU bug report logs - #68180
[PATCH 0/4] Add emacs-pde

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Sun, 31 Dec 2023 16:50:01 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #74 received at 68180 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: 68180 <at> debbugs.gnu.org, Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Andrew Tropin <andrew <at> trop.in>
Subject: Re: [bug#68180] [PATCH v2 4/4] gnu: Add emacs-pde.
Date: Tue, 02 Jan 2024 14:41:08 -0500

Hello,

Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:


[...]

>> +              (make-file-writable "lisp/perltidy.el")
>> +              (emacs-substitute-variables "lisp/perltidy.el"
>> +                ("perltidy-program"
>> +                 (search-input-file inputs "bin/perltidy")))
>> +              (substitute* "lisp/tools/perldoc-cache.pl"
>> +                (("`perldoc")
>> +                 (string-append
>> +                  "`" (search-input-file inputs "bin/perldoc"))))))
> I'd use for-each to make the files writable, possibly also a directory
> excursion.

Done, see v3.

Thanks for the review!

-- 
Maxim
This bug report was last modified 1 year and 122 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.