GNU bug report logs - #68181
[PATCH] gnu: extempore: Add rtmidi@4 to package inputs.

Previous Next

Package: guix-patches;

Reported by: Giacomo Leidi <goodoldpaul <at> autistici.org>

Date: Sun, 31 Dec 2023 16:54:01 UTC

Severity: normal

Tags: patch

Done: paul <goodoldpaul <at> autistici.org>

To reply to this bug, email your comments to 68181 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#68181; Package guix-patches. (Sun, 31 Dec 2023 16:54:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Giacomo Leidi <goodoldpaul <at> autistici.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 31 Dec 2023 16:54:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: guix-patches <at> gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH] gnu: extempore: Add rtmidi <at> 4 to package inputs.
Date: Sun, 31 Dec 2023 17:52:40 +0100

Some extempore code (libs/contrib/rtmidi.xtm specifically) depend on
rtmidi, this patch adds it to package inputs and hardcodes the soname
path.

* gnu/packages/music.scm (extempore)[inputs]: Add rtmidi-4.0;
[arguments]<hardcode-contrib-lib-paths>: new phase.

Change-Id: I16e055a68d48c813fb54dd55f686be102a0850af
---
 gnu/packages/music.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 77e952d383..a79fb3e4ee 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1073,6 +1073,16 @@ (define-public extempore
                 ("gl/glcore-directbind"   "libGL.so" "mesa")
                 ("gl/glcompat-directbind" "libGL.so" "mesa")))
              #t))
+         (add-after 'hardcode-external-lib-paths 'hardcode-contrib-lib-paths
+           (lambda* (#:key inputs #:allow-other-keys)
+             (use-modules (ice-9 match))
+             (for-each
+              (match-lambda
+                ((file-name lib pkg-name)
+                 (substitute* (string-append "libs/contrib/" file-name ".xtm")
+                   ((lib) (string-append (assoc-ref inputs pkg-name)
+                                         "/lib/" lib)))))
+              '(("rtmidi"    "librtmidi.so"    "rtmidi")))))
          (add-after 'unpack 'use-own-llvm
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "EXT_LLVM_DIR" (assoc-ref inputs "llvm"))
@@ -1125,6 +1135,7 @@ (define-public extempore
        ("libffi" ,libffi)
        ("jack" ,jack-1)
        ("libsndfile" ,libsndfile)
+       ("rtmidi" ,rtmidi-4.0)
        ("glfw" ,glfw)
        ("apr" ,apr)
        ("stb-image"

base-commit: b7466215cd05c2a1cd7c7a18c92af30376d21043
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#68181; Package guix-patches. (Sun, 31 Dec 2023 17:11:02 GMT) Full text and rfc822 format available.

Message #8 received at 68181 <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: 68181 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH v2] gnu: extempore: Add rtmidi <at> 4 to package inputs.
Date: Sun, 31 Dec 2023 18:10:02 +0100

Some extempore code (libs/contrib/rtmidi.xtm specifically) depend on
rtmidi, this patch adds it to package inputs and hardcodes the soname
path.

* gnu/packages/music.scm (extempore)[inputs]: Add rtmidi-4.0;
[arguments]<hardcode-contrib-lib-paths>: new phase.

Change-Id: I16e055a68d48c813fb54dd55f686be102a0850af
---
 gnu/packages/music.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 77e952d383..ece2c71385 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1073,6 +1073,12 @@ (define-public extempore
                 ("gl/glcore-directbind"   "libGL.so" "mesa")
                 ("gl/glcompat-directbind" "libGL.so" "mesa")))
              #t))
+         (add-after 'hardcode-external-lib-paths 'hardcode-contrib-lib-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (substitute* "libs/contrib/rtmidi.xtm"
+                  (("librtmidic.so")
+                   (string-append (assoc-ref inputs "rtmidi")
+                                  "/lib/librtmidi.so")))))
          (add-after 'unpack 'use-own-llvm
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "EXT_LLVM_DIR" (assoc-ref inputs "llvm"))
@@ -1125,6 +1131,7 @@ (define-public extempore
        ("libffi" ,libffi)
        ("jack" ,jack-1)
        ("libsndfile" ,libsndfile)
+       ("rtmidi" ,rtmidi-4.0)
        ("glfw" ,glfw)
        ("apr" ,apr)
        ("stb-image"

base-commit: b7466215cd05c2a1cd7c7a18c92af30376d21043
-- 
2.41.0
Information forwarded to guix-patches <at> gnu.org:
bug#68181; Package guix-patches. (Sun, 20 Oct 2024 22:53:02 GMT) Full text and rfc822 format available.

Message #11 received at 68181 <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: 68181 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: extempore: Add rtmidi <at> 4 to package inputs.
Date: Mon, 21 Oct 2024 00:52:01 +0200

Hi Guix , this is a friendly ping. I'm sending a patchset rebased on 
current master.

Thank you for your work,

giacomo
Information forwarded to guix-patches <at> gnu.org:
bug#68181; Package guix-patches. (Sun, 20 Oct 2024 22:53:03 GMT) Full text and rfc822 format available.

Message #14 received at 68181 <at> debbugs.gnu.org (full text, mbox):

From: Giacomo Leidi <goodoldpaul <at> autistici.org>
To: 68181 <at> debbugs.gnu.org
Cc: Giacomo Leidi <goodoldpaul <at> autistici.org>
Subject: [PATCH v2] gnu: extempore: Add rtmidi <at> 4 to package inputs.
Date: Mon, 21 Oct 2024 00:52:24 +0200

Some extempore code (libs/contrib/rtmidi.xtm specifically) depend on
rtmidi, this patch adds it to package inputs and hardcodes the soname
path.

* gnu/packages/music.scm (extempore)[inputs]: Add rtmidi-4.0;
[arguments]<hardcode-contrib-lib-paths>: new phase.

Change-Id: I16e055a68d48c813fb54dd55f686be102a0850af
---
 gnu/packages/music.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 9c1a617ca1..102f3143f4 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -1212,6 +1212,12 @@ (define-public extempore
                 ("gl/glcore-directbind"   "libGL.so" "mesa")
                 ("gl/glcompat-directbind" "libGL.so" "mesa")))
              #t))
+         (add-after 'hardcode-external-lib-paths 'hardcode-contrib-lib-paths
+              (lambda* (#:key inputs #:allow-other-keys)
+                (substitute* "libs/contrib/rtmidi.xtm"
+                  (("librtmidic.so")
+                   (string-append (assoc-ref inputs "rtmidi")
+                                  "/lib/librtmidi.so")))))
          (add-after 'unpack 'use-own-llvm
            (lambda* (#:key inputs #:allow-other-keys)
              (setenv "EXT_LLVM_DIR" (assoc-ref inputs "llvm"))
@@ -1264,6 +1270,7 @@ (define-public extempore
        ("libffi" ,libffi)
        ("jack" ,jack-1)
        ("libsndfile" ,libsndfile)
+       ("rtmidi" ,rtmidi-4.0)
        ("glfw" ,glfw)
        ("apr" ,apr)
        ("stb-image"

base-commit: 5ab3c4c1e43ebb637551223791db0ea3519986e1
-- 
2.46.0
Reply sent to paul <goodoldpaul <at> autistici.org>:
You have taken responsibility. (Sun, 01 Jun 2025 10:10:02 GMT) Full text and rfc822 format available.
Notification sent to Giacomo Leidi <goodoldpaul <at> autistici.org>:
bug acknowledged by developer. (Sun, 01 Jun 2025 10:10:02 GMT) Full text and rfc822 format available.

Message #19 received at 68181-done <at> debbugs.gnu.org (full text, mbox):

From: paul <goodoldpaul <at> autistici.org>
To: 68181-done <at> debbugs.gnu.org
Date: Sun, 1 Jun 2025 12:09:56 +0200

This has been moved on Codeberg at 
https://codeberg.org/guix/guix/pulls/368 , in the hope it'll get more 
attention
This bug report was last modified 11 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.