GNU bug report logs - #68180
[PATCH 0/4] Add emacs-pde

Previous Next

Full log

Message #53 received at 68180 <at> debbugs.gnu.org (full text, mbox):

From: Andrew Tropin <andrew <at> trop.in>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>, 68180 <at> debbugs.gnu.org
Cc: Katherine Cox-Buday <cox.katherine.e+guix <at> gmail.com>,
 Liliana Marie Prikler <liliana.prikler <at> gmail.com>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: Re: [bug#68180] [PATCH v2 1/4] gnu: emacs: Patch awk, find, sed and
 sh commands.
Date: Tue, 02 Jan 2024 10:07:07 +0300

[Message part 1 (text/plain, inline)]

On 2024-01-01 20:58, Maxim Cournoyer wrote:

> Before this change, using Emacs in a pure environment, e.g. 'guix shell --pure
> emacs', would cause problems such as:
>
>   jka-compr-insert-file-contents: Uncompression program ‘sh’ not found
>
> And other problems were found requiring the other tools.
>
> * gnu/packages/emacs.scm (emacs-minimal) [arguments]: Extend the
> patch-program-file-names phase.
> [inputs]: Add findutils, gawk and sed.
>
> Change-Id: Ifb4fe2fc12ddc9eae387adb3da3f7821fab78e65
> ---
>
> Changes in v2:
>  - Patch references in place instead of wrapping via PATH

Yep, I think this is a right way.  Thank you very much for working on
it!

>
>  gnu/packages/emacs.scm | 56 +++++++++++++++++++++++++++++++++++++++---
>  1 file changed, 52 insertions(+), 4 deletions(-)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index b9d9e2b891..3e8de3c2e0 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -9,7 +9,7 @@
>  ;;; Copyright © 2016 David Thompson <dthompson2 <at> worcester.edu>
>  ;;; Copyright © 2016 Nikita <nikita <at> n0.is>
>  ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
> -;;; Copyright © 2017, 2019, 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> +;;; Copyright © 2017, 2019, 2020, 2023, 2024 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
>  ;;; Copyright © 2017 Alex Vong <alexvong1995 <at> gmail.com>
>  ;;; Copyright © 2017, 2018 Ricardo Wurmus <rekado <at> elephly.net>
>  ;;; Copyright © 2017, 2023 Janneke Nieuwenhuizen <janneke <at> gnu.org>
> @@ -59,6 +59,7 @@ (define-module (gnu packages emacs)
>    #:use-module (gnu packages fontutils)
>    #:use-module (gnu packages freedesktop)
>    #:use-module (gnu packages fribidi)
> +  #:use-module (gnu packages gawk)
>    #:use-module (gnu packages gcc)
>    #:use-module (gnu packages gd)
>    #:use-module (gnu packages gettext)
> @@ -157,13 +158,60 @@ (define-public emacs-minimal
>                  (delete-file "configure"))))
>            (add-after 'unpack 'patch-program-file-names
>              (lambda* (#:key inputs #:allow-other-keys)
> +              ;; Substitute "sh" command.
>                (substitute* '("src/callproc.c"
>                               "lisp/term.el"
>                               "lisp/htmlfontify.el"
> +                             "lisp/mail/feedmail.el"
> +                             "lisp/obsolete/pgg-pgp.el"
> +                             "lisp/obsolete/pgg-pgp5.el"
> +                             "lisp/obsolete/terminal.el"
> +                             "lisp/org/ob-eval.el"
>                               "lisp/textmodes/artist.el"
> -                             "lisp/progmodes/sh-script.el")
> +                             "lisp/progmodes/sh-script.el"
> +                             "lisp/textmodes/artist.el"
> +                             "lisp/htmlfontify.el"
> +                             "lisp/term.el")
>                  (("\"/bin/sh\"")
> -                 (format #f "~s" (search-input-file inputs "/bin/sh"))))
> +                 (format #f "~s" (search-input-file inputs "bin/sh"))))
> +              (substitute* '("lisp/gnus/mm-uu.el"
> +                             "lisp/gnus/nnrss.el"
> +                             "lisp/mail/blessmail.el")
> +                (("\"#!/bin/sh\\\n\"")
> +                 (format #f "\"#!~a~%\"" (search-input-file inputs "bin/sh"))))
> +              (substitute* '("lisp/jka-compr.el"
> +                             "lisp/man.el")
> +                (("\"sh\"")
> +                 (format #f "~s" (search-input-file inputs "bin/sh"))))
> +
> +              ;; Substitute "awk" command.
> +              (substitute* '("lisp/gnus/nnspool.el"
> +                             "lisp/org/ob-awk.el"
> +                             "lisp/man.el")
> +                (("\"awk\"")
> +                 (format #f "~s" (search-input-file inputs "bin/awk"))))
> +
> +              ;; Substitute "find" command.
> +              (substitute* '("lisp/gnus/gnus-search.el"
> +                             "lisp/obsolete/nnir.el"
> +                             "lisp/progmodes/executable.el"
> +                             "lisp/progmodes/grep.el"
> +                             "lisp/filecache.el"
> +                             "lisp/ldefs-boot.el"
> +                             "lisp/mpc.el")
> +                (("\"find\"")
> +                 (format #f "~s" (search-input-file inputs "bin/find"))))
> +
> +              ;; Substitute "sed" command.
> +              (substitute* "lisp/org/ob-sed.el"
> +                (("org-babel-sed-command \"sed\"")
> +                 (format #f "org-babel-sed-command ~s"
> +                         (search-input-file inputs "bin/sed"))))
> +              (substitute* "lisp/man.el"
> +                (("Man-sed-command \"sed\"")
> +                 (format #f "Man-sed-command ~s"
> +                         (search-input-file inputs "bin/sed"))))
> +
>                (substitute* "lisp/doc-view.el"
>                  (("\"(gs|dvipdf|ps2pdf|pdftotext)\"" all what)
>                   (let ((replacement (false-if-exception
> @@ -254,7 +302,7 @@ (define-public emacs-minimal
>                  (copy-file
>                   (car (find-files "bin" "^emacs-([0-9]+\\.)+[0-9]+$"))
>                   "bin/emacs")))))))
> -    (inputs (list bash-minimal coreutils gzip ncurses))
> +    (inputs (list bash-minimal coreutils findutils gawk gzip ncurses sed))
>      (native-inputs (list autoconf pkg-config texinfo))
>      (home-page "https://www.gnu.org/software/emacs/")
>      (synopsis "The extensible text editor (minimal build for byte-compilation)")

-- 
Best regards,
Andrew Tropin

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.