GNU bug report logs - #68018
[PATCH] Fix previous page and next page tooltips in doc-view.el

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#68018: closed ([PATCH] Fix previous page and next page
 tooltips in doc-view.el)
Date: Sat, 30 Dec 2023 07:43:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 30 Dec 2023 09:42:13 +0200
with message-id <83r0j43zmy.fsf <at> gnu.org>
and subject line Re: bug#68018: [PATCH] Fix previous page and next page tooltips in doc-view.el
has caused the debbugs.gnu.org bug report #68018,
regarding [PATCH] Fix previous page and next page tooltips in doc-view.el
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
68018: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=68018
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix previous page and next page tooltips in doc-view.el
Date: Mon, 25 Dec 2023 00:04:39 +0100

[Message part 3 (text/plain, inline)]

Tags: patch


In docview.el, the toolbar icons used to navigate to the previous and
next pages have incorrect tooltips.  I've attached a patch to address
this issue.  Thanks.

[0001-Fix-previous-page-and-next-page-tooltips-in-doc-view.patch (text/patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: luangruo <at> yahoo.com, 68018-done <at> debbugs.gnu.org
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Sat, 30 Dec 2023 09:42:13 +0200

> Cc: 68018 <at> debbugs.gnu.org
> Date: Mon, 25 Dec 2023 11:54:07 +0100
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > Daniel Martín <mardani29 <at> yahoo.es> writes:
> >
> >> In docview.el, the toolbar icons used to navigate to the previous and
> >> next pages have incorrect tooltips.  I've attached a patch to address
> >> this issue.  Thanks.
> >
> > Thanks, but why rename the icon?
> 
> So that the name of the icon matches what the icon really represents.
> If you feel that renaming the icon may cause incompatibilities, here’s a
> new patch that only changes the help tooltip.  Thanks.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.