GNU bug report logs - #68018
[PATCH] Fix previous page and next page tooltips in doc-view.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 68018 in the body.
You can then email your comments to 68018 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix previous page and next page tooltips in doc-view.el
Date: Mon, 25 Dec 2023 00:04:39 +0100

[Message part 1 (text/plain, inline)]

Tags: patch


In docview.el, the toolbar icons used to navigate to the previous and
next pages have incorrect tooltips.  I've attached a patch to address
this issue.  Thanks.

[0001-Fix-previous-page-and-next-page-tooltips-in-doc-view.patch (text/patch, attachment)]

Message #8 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 68018 <at> debbugs.gnu.org
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 08:26:40 +0800

Daniel Martín <mardani29 <at> yahoo.es> writes:

> In docview.el, the toolbar icons used to navigate to the previous and
> next pages have incorrect tooltips.  I've attached a patch to address
> this issue.  Thanks.

Thanks, but why rename the icon?

Message #11 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 11:54:07 +0100

[Message part 1 (text/plain, inline)]

Po Lu <luangruo <at> yahoo.com> writes:

> Daniel Martín <mardani29 <at> yahoo.es> writes:
>
>> In docview.el, the toolbar icons used to navigate to the previous and
>> next pages have incorrect tooltips.  I've attached a patch to address
>> this issue.  Thanks.
>
> Thanks, but why rename the icon?

So that the name of the icon matches what the icon really represents.
If you feel that renaming the icon may cause incompatibilities, here’s a
new patch that only changes the help tooltip.  Thanks.

[0001-Fix-previous-page-and-next-page-tooltips-in-doc-view.patch (text/x-patch, attachment)]

Message #14 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 68018 <at> debbugs.gnu.org
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 19:59:39 +0800

Daniel Martín <mardani29 <at> yahoo.es> writes:

> So that the name of the icon matches what the icon really represents.

I don't see an appreciable distinction between "previous" and "last" in
this context, except perhaps that "previous" might refer to the page
previously visited (in contrast to the preceding page in the document),
which is not the function of the Doc View command in question.  As such,
please don't rename the icon.  Thanks.

Message #17 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 14:22:18 +0200

> Cc: 68018 <at> debbugs.gnu.org
> Date: Mon, 25 Dec 2023 19:59:39 +0800
> From:  Po Lu via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Daniel Martín <mardani29 <at> yahoo.es> writes:
> 
> > So that the name of the icon matches what the icon really represents.
> 
> I don't see an appreciable distinction between "previous" and "last" in
> this context, except perhaps that "previous" might refer to the page
> previously visited (in contrast to the preceding page in the document),
> which is not the function of the Doc View command in question.  As such,
> please don't rename the icon.  Thanks.

Doesn't the icon's name say what it is supposed to mean?  I don't
think I like to see "last-page" where the function is
doc-view-previous-page.  If the icon's image is not very
self-explanatory, we should perhaps look for a better icon, but that
is unrelated to this issue.

Message #20 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 20:59:01 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Doesn't the icon's name say what it is supposed to mean?  I don't

Yes.  The icon's name implies it will move one page backwards, in line
with the function of doc-view-previous-page.

Thanks.

Message #23 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 15:40:42 +0200

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: mardani29 <at> yahoo.es,  68018 <at> debbugs.gnu.org
> Date: Mon, 25 Dec 2023 20:59:01 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Doesn't the icon's name say what it is supposed to mean?  I don't
> 
> Yes.  The icon's name implies it will move one page backwards, in line
> with the function of doc-view-previous-page.

Then why is the icon called "LAST page" and not "PREVIOUS page"?

Message #26 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Mon, 25 Dec 2023 06:23:16 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Po Lu <luangruo <at> yahoo.com>
>> Cc: mardani29 <at> yahoo.es,  68018 <at> debbugs.gnu.org
>> Date: Mon, 25 Dec 2023 20:59:01 +0800
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> > Doesn't the icon's name say what it is supposed to mean?  I don't
>>
>> Yes.  The icon's name implies it will move one page backwards, in line
>> with the function of doc-view-previous-page.
>
> Then why is the icon called "LAST page" and not "PREVIOUS page"?

FWIW, I tend to agree that it's purpose would be be more clear if we
renamed it.  This icon was added in July 2023.

Message #29 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Tue, 26 Dec 2023 10:02:21 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Then why is the icon called "LAST page" and not "PREVIOUS page"?

Because it was generated from "next-page.xpm", and the icon itself could
easily mean either "last in document" or "last in time".

Message #32 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Wed, 27 Dec 2023 14:38:34 +0200

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: mardani29 <at> yahoo.es,  68018 <at> debbugs.gnu.org
> Date: Tue, 26 Dec 2023 10:02:21 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Then why is the icon called "LAST page" and not "PREVIOUS page"?
> 
> Because it was generated from "next-page.xpm", and the icon itself could
> easily mean either "last in document" or "last in time".

Then how about copying last-page.* into prev-page.*, so that we keep
both?

Message #35 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Wed, 27 Dec 2023 21:02:18 +0800

Eli Zaretskii <eliz <at> gnu.org> writes:

> Then how about copying last-page.* into prev-page.*, so that we keep
> both?

I think there are tasks worthier of our attention than duplicating an
icon in order to create a copy whose name reflects a marginally
different meaning from that which the original's does.  It would spare
us a lot of quibbling if we focused on the substantive part of this
change, namely the two corrections to the tooltips, rather than the
renaming of an icon.  But maybe that's just me, and we do want the names
of each icon in etc/images to be 150% representative of every meaning it
might carry.

TIA.

Message #38 received at 68018 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 68018 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Wed, 27 Dec 2023 15:39:27 +0200

> From: Po Lu <luangruo <at> yahoo.com>
> Cc: mardani29 <at> yahoo.es,  68018 <at> debbugs.gnu.org
> Date: Wed, 27 Dec 2023 21:02:18 +0800
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Then how about copying last-page.* into prev-page.*, so that we keep
> > both?
> 
> I think there are tasks worthier of our attention than duplicating an
> icon in order to create a copy whose name reflects a marginally
> different meaning from that which the original's does.

You prefer to have to answer questions from surprised people about why
it's "last" and not "prev"?  Fine by me.

> It would spare us a lot of quibbling if we focused on the
> substantive part of this change, namely the two corrections to the
> tooltips, rather than the renaming of an icon.

Aren't those other parts no-brainers?

> But maybe that's just me, and we do want the names of each icon in
> etc/images to be 150% representative of every meaning it might
> carry.

Are we going to argue again about the importance of mnemonic names?

Message #45 received at 68018-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: luangruo <at> yahoo.com, 68018-done <at> debbugs.gnu.org
Subject: Re: bug#68018: [PATCH] Fix previous page and next page tooltips in
 doc-view.el
Date: Sat, 30 Dec 2023 09:42:13 +0200

> Cc: 68018 <at> debbugs.gnu.org
> Date: Mon, 25 Dec 2023 11:54:07 +0100
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> Po Lu <luangruo <at> yahoo.com> writes:
> 
> > Daniel Martín <mardani29 <at> yahoo.es> writes:
> >
> >> In docview.el, the toolbar icons used to navigate to the previous and
> >> next pages have incorrect tooltips.  I've attached a patch to address
> >> this issue.  Thanks.
> >
> > Thanks, but why rename the icon?
> 
> So that the name of the icon matches what the icon really represents.
> If you feel that renaming the icon may cause incompatibilities, here’s a
> new patch that only changes the help tooltip.  Thanks.

Thanks, installed on master, and closing the bug.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.