GNU bug report logs - #6768
ls: fix a test failure that should have been skipped

Previous Next

Full log

Message #8 received at 6768 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: 6768 <at> debbugs.gnu.org
Subject: Re: bug#6768: ls: fix a test failure that should have been skipped
Date: Mon, 09 Aug 2010 08:54:44 -0600

[Message part 1 (text/plain, inline)]

On 07/30/2010 07:49 PM, dsh <at> linux.ucla.edu wrote:
> Hi,
> 
> I just ran into this one test failure while building the latest sources.  The
> test didn't really fail, but the exit via the function invoked in $() doesn't
> terminate the test script, it simply terminates the substitution command.
> 
> Here are the bits where it failed:
> 
> ++ case $base in
> ++ skip_test_ 'mount point component starts with "."'
> ...
> ++ exit 77
> + readdir_inode=
> ++ env stat --format=%i /home/dsh/.gvfs

Thanks; applied.

> Subject: [PATCH] ls: fix a test failure that should have been skipped
> 
> * tests/ls/readdir-mountpoint-inode: Check to see if skip_test_ is
> called in a helper function via $() instead of mistakenly failing.

>  for dir in $mount_points; do
>    readdir_inode=$(inode_via_readdir $dir)
> +  test $? = 77 && continue

-- 
Eric Blake   eblake <at> redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.