GNU bug report logs - #6769
df (GNU coreutils) 7.4 Dutch output misalignment

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6769 in the body.
You can then email your comments to 6769 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Erik Quaeghebeur <gnu <at> equaeghe.nospammail.net>
To: bug-coreutils <at> gnu.org
Subject: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Sat, 31 Jul 2010 20:30:59 -0400 (EDT)

Dear df-maintainer,


I observed a misalignment of the output of df (GNU coreutils) 7.4 in a 
Dutch locale: from the second column onward, the column header in the 
first row is too far to the right (by six spaces, in the cases I 
investigated).

Sample output (please use a fixed-width font):

$ df
Bestandssysteem           1K-blokken Gebruikt Beschikbr Geb% Aangekoppeld op
/dev/sda7             15306620   6146768   8382308  43% /
none                   1019676       364   1019312   1% /dev
none                   1024188      1728   1022460   1% /dev/shm
none                   1024188       276   1023912   1% /var/run
none                   1024188         0   1024188   0% /var/lock
none                   1024188         0   1024188   0% /lib/init/rw
/dev/sda3                75272     19297     51959  28% /boot
/dev/sda5             40132520  17351692  20742184  46% /home

$ df -h
Bestandssysteem            Grtte   Gebr Besch Geb% Aangekoppeld op
/dev/sda7              15G  5,9G  8,0G  43% /
none                  996M  364K  996M   1% /dev
none                 1001M  1,7M  999M   1% /dev/shm
none                 1001M  276K 1000M   1% /var/run
none                 1001M     0 1001M   0% /var/lock
none                 1001M     0 1001M   0% /lib/init/rw
/dev/sda3              74M   19M   51M  28% /boot
/dev/sda5              39G   17G   20G  46% /home

$ df -P
Bestandssysteem         1024-blokken  Gebruikt Beschikbr Vulgraad Aangekoppeld op
/dev/sda7             15306620   6146768   8382308      43% /
none                   1019676       364   1019312       1% /dev
none                   1024188      1728   1022460       1% /dev/shm
none                   1024188       276   1023912       1% /var/run
none                   1024188         0   1024188       0% /var/lock
none                   1024188         0   1024188       0% /lib/init/rw
/dev/sda3                75272     19297     51959      28% /boot
/dev/sda5             40132520  17352604  20741272      46% /home

No reply necessary. I appreciate your effort and very much understand that 
this minor issue does not have high priority.


Sincerely,

Erik Quaeghebeur

Message #8 received at 6769 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Erik Quaeghebeur <gnu <at> equaeghe.nospammail.net>
Cc: 6769 <at> debbugs.gnu.org
Subject: Re: bug#6769: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Mon, 09 Aug 2010 01:47:43 +0100

On 01/08/10 01:30, Erik Quaeghebeur wrote:
> Dear df-maintainer,
> 
> 
> I observed a misalignment of the output of df (GNU coreutils) 7.4 in a
> Dutch locale: from the second column onward, the column header in the
> first row is too far to the right (by six spaces, in the cases I
> investigated).

This is a common annoyance.
I'm looking at fixing this with the mbsalign module.
Note this will probably break translations for a while.

cheers,
Pádraig.

Message #11 received at 6769 <at> debbugs.gnu.org (full text, mbox):

From: "Benno Schulenberg" <bensberg <at> justemail.net>
To: 6769 <at> debbugs.gnu.org
Subject: translation misalignment in 'df' is specific to Ubuntu
Date: Wed, 20 Oct 2010 22:25:17 +0200

Hello Erik,

Most likely you were using a version of Ubuntu (or a derivative);
the misalignment is due to a longstanding bug in Launchpad/Rosetta
(https://bugs.launchpad.net/rosetta/+bug/30358).

For Ubuntu 10.10 I've tried to alleviate the problem by reducing
the word "Bestandssysteem" to "Bstndsystm" -- but just for Ubuntu,
not for the official coreutils PO file at the Translation Project
(http://translationproject.org/domain/coreutils.html).

If you have more comments about translation deficiences, please
direct them to the vertaling mailing list at vrijschrift (see the
Dutch team page at the TP).

Regards,

Benno

-- 
http://www.fastmail.fm - A fast, anti-spam email service.

Message #14 received at 6769 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 6769 <at> debbugs.gnu.org
Subject: Re: bug#6769: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Tue, 22 Mar 2011 14:06:58 +0000

[Message part 1 (text/plain, inline)]

On 01/08/10 01:30, Erik Quaeghebeur wrote:
> Dear df-maintainer,
> 
> 
> I observed a misalignment of the output of df (GNU coreutils) 7.4 in a
> Dutch locale: from the second column onward, the column header in the
> first row is too far to the right (by six spaces, in the cases I
> investigated).

Here's a proposed fix for all these alignment issues.
A good command to compare before and after is:

  df --all -T -P -B\'1

cheers,
Pádraig.

[df-align.diff (text/x-patch, attachment)]

Message #17 received at 6769 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 6769 <at> debbugs.gnu.org
Subject: Re: bug#6769: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Tue, 22 Mar 2011 22:22:30 +0000

On 22/03/11 14:06, Pádraig Brady wrote:
> On 01/08/10 01:30, Erik Quaeghebeur wrote:
>> Dear df-maintainer,
>>
>>
>> I observed a misalignment of the output of df (GNU coreutils) 7.4 in a
>> Dutch locale: from the second column onward, the column header in the
>> first row is too far to the right (by six spaces, in the cases I
>> investigated).
> 
> Here's a proposed fix for all these alignment issues.
> A good command to compare before and after is:
> 
>   df --all -T -P -B\'1

Here's the lastest version with a few inconsequential tweaks,
and a NEWS entry

http://www.pixelbeat.org/patches/df-align.diff

cheers,
Pádraig.

Message #20 received at 6769 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 6769 <at> debbugs.gnu.org
Subject: Re: bug#6769: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Wed, 23 Mar 2011 11:48:47 +0100

Pádraig Brady wrote:
> On 22/03/11 14:06, Pádraig Brady wrote:
>> On 01/08/10 01:30, Erik Quaeghebeur wrote:
>>> Dear df-maintainer,
>>>
>>> I observed a misalignment of the output of df (GNU coreutils) 7.4 in a
>>> Dutch locale: from the second column onward, the column header in the
>>> first row is too far to the right (by six spaces, in the cases I
>>> investigated).
>>
>> Here's a proposed fix for all these alignment issues.
>> A good command to compare before and after is:
>>
>>   df --all -T -P -B\'1

I like it.

> Here's the lastest version with a few inconsequential tweaks,
> and a NEWS entry
>
> http://www.pixelbeat.org/patches/df-align.diff

Thanks.
I've tried to compile with that, and saw some new warnings (using F14's gcc
4.5.1 20100924).  Fixing them, I also removed some stray spaces in "table [...":

diff --git a/src/df.c b/src/df.c
index 7c67620..df31611 100644
--- a/src/df.c
+++ b/src/df.c
@@ -254,11 +254,11 @@ get_header (void)
     {
       if (field == TYPE_FIELD && !print_type)
         {
-          table [nrows-1][field] = NULL;
+          table[nrows-1][field] = NULL;
           continue;
         }

-      char *header = _(headers[field][header_mode]);
+      char const *header = _(headers[field][header_mode]);
       if (!header)
         header = _(headers[field][DEFAULT_MODE]);

@@ -318,7 +318,7 @@ get_header (void)
       if (!header)
         xalloc_die ();

-      table [nrows-1][field] = header;
+      table[nrows-1][field] = (char *) header;

       widths[field] = MAX (widths[field], mbswidth (header, 0));
     }

Having a test that exhibits the change in behavior would
be nice, but is probably not worth the trouble.

Message #25 received at 6769-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: 6769-done <at> debbugs.gnu.org
Subject: Re: bug#6769: df (GNU coreutils) 7.4 Dutch output misalignment
Date: Thu, 24 Mar 2011 00:02:38 +0000

On 23/03/11 10:48, Jim Meyering wrote:
> I've tried to compile with that, and saw some new warnings (using F14's gcc
> 4.5.1 20100924).
> 
> -      char *header = _(headers[field][header_mode]);
> +      char const *header = _(headers[field][header_mode]);

I've fixed that up and pushed the result.
Closing this bug...

thanks,
Pádraig.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.