GNU bug report logs - #67229
[PATCH] gnu: Add r-gtsummary and dependencies

Previous Next

Full log

Message #8 received at 67229 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Sebastian Gibb via Guix-patches via <guix-patches <at> gnu.org>,
 67229 <at> debbugs.gnu.org
Cc: paren <at> disroot.org, ludo <at> gnu.org, me <at> tobias.gr, rekado <at> elephly.net,
 rg <at> raghavgururajan.name, jgart <at> dismail.de, othacehe <at> gnu.org, guix <at> cbaines.net,
 Sebastian Gibb <mail <at> sebastiangibb.de>
Subject: Re: [bug#67229] [PATCH] gnu: Add r-gtsummary and dependencies
Date: Fri, 12 Jan 2024 09:51:18 +0100

Hi,

(Sorry for the late reply.)

On Thu, 16 Nov 2023 at 15:07, Sebastian Gibb via Guix-patches via <guix-patches <at> gnu.org> wrote:
> Change-Id: I8925668063ca53b91bec49788fbed3df5eb2c2fc
> ---
>  gnu/packages/cran.scm | 211 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 211 insertions(+)

Thanks for your contributions.  From a first look, they look good to me
but it would help if you could:

 1. Split all the additions to atomic commits – one package per commit:

        +(define-public r-reactr
        +(define-public r-reactable
        +(define-public r-juicyjuice
        +(define-public r-gt
        +(define-public r-gtsummary
        +(define-public r-bigd
        +(define-public r-broom-helpers

    Hence 7 commits; :-)

 2. Write compliant commit messages, as:

--8<---------------cut here---------------start------------->8---
gnu: Add r-reactr.

* gnu/packages/cran.scm (r-reactr): New variable.
--8<---------------cut here---------------end--------------->8---

Could you send v2 (reroll-count=2)? 

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.