GNU bug report logs - #6674
PATCH: fix assignment of grep-find-use-xargs on Windows/MS-DOS

Previous Next

Full log

View this message in rfc822 format

From: Óscar Fuentes <ofv <at> wanadoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: bug#6674: [PATCH fixed] bug#6674: fix assignment of	grep-find-use-xargs on Windows/MS-DOS
Date: Mon, 02 Aug 2010 21:57:16 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Fixed the typo pointed out by Andreas.
>> 
>> 2010-08-02  Óscar Fuentes  <ofv <at> wanadoo.es>
>> 
>> 	* cmdproxy.c (main): use _snprintf instead of wsprintf. Fixes
>> 	bug#6647. wsprintf has a 1024 char limit on Windows.
>
> Thanks.
>
> wsprintf supports wide character (UTF-16) strings, whereas _snprintf
> does not.

wsprintf supports UTF-16 iff the application is compiled with Unicode
support on. cmdproxy uses char, not wchar_t, so if the build switches on
Unicode the compilation will fail.

> At the very least, please leave a comment there about that.

It should be obvious from the type used (char)

> Better yet, why not use memcpy etc. instead of _snprintf; you don't
> really need any formatting features anyway.

It uses

"\"%s\""
" %s"
" /e:%d /c %s"

and more.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.