GNU bug report logs - #6673
[PATCH] only build libstdbuf.so when stdbuf is enabled

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6673 in the body.
You can then email your comments to 6673 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] only build libstdbuf.so when stdbuf is enabled
Date: Mon, 19 Jul 2010 20:51:38 -0400

Currently, only main programs (like stdbuf) can be disabled at configure
time.  Helper programs (like libstdbuf.so) do not have a configure option.

Even if you disable stdbuf with the configure option, libstdbuf.so will
still be compiled and installed.  So delay the parsing of helper programs
until after we know the final enable list, and then only build libstdbuf.so
when stdbuf is also enabled.

Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
---
 configure.ac |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index e7037a1..acd397e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then
 fi
 
 # Limit stdbuf to ELF systems with GCC
-optional_pkglib_progs=
 AC_MSG_CHECKING([whether this is an ELF system])
 AC_EGREP_CPP([yes], [#if __ELF__
 yes
@@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys])
 if test "$elf_sys" = "yes" && \
    test "$GCC" = "yes"; then
   gl_ADD_PROG([optional_bin_progs], [stdbuf])
-  gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so])
 fi
 
 ############################################################################
@@ -395,6 +393,13 @@ esac
 # corresponding ./configure option argument is comma-separated on input.
 gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su])
 
+# Now that we know which programs will actually be built up, figure out
+# which optional helper progs should be compiled.
+optional_pkglib_progs=
+case " $optional_bin_progs " in
+  *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;;
+esac
+
 # Set INSTALL_SU if su installation has been requested via
 # --enable-install-program=su.
 AC_SUBST([INSTALL_SU])
-- 
1.7.1.1

Message #8 received at 6673 <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Mike Frysinger <vapier <at> gentoo.org>
Cc: 6673 <at> debbugs.gnu.org
Subject: Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled
Date: Tue, 20 Jul 2010 14:08:55 +0100

On 20/07/10 01:51, Mike Frysinger wrote:
> Currently, only main programs (like stdbuf) can be disabled at configure
> time.  Helper programs (like libstdbuf.so) do not have a configure option.
> 
> Even if you disable stdbuf with the configure option, libstdbuf.so will
> still be compiled and installed.  So delay the parsing of helper programs
> until after we know the final enable list, and then only build libstdbuf.so
> when stdbuf is also enabled.
> 
> Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
> ---
>  configure.ac |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index e7037a1..acd397e 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then
>  fi
>  
>  # Limit stdbuf to ELF systems with GCC
> -optional_pkglib_progs=
>  AC_MSG_CHECKING([whether this is an ELF system])
>  AC_EGREP_CPP([yes], [#if __ELF__
>  yes
> @@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys])
>  if test "$elf_sys" = "yes" && \
>     test "$GCC" = "yes"; then
>    gl_ADD_PROG([optional_bin_progs], [stdbuf])
> -  gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so])
>  fi
>  
>  ############################################################################
> @@ -395,6 +393,13 @@ esac
>  # corresponding ./configure option argument is comma-separated on input.
>  gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su])
>  
> +# Now that we know which programs will actually be built up, figure out
> +# which optional helper progs should be compiled.
> +optional_pkglib_progs=
> +case " $optional_bin_progs " in
> +  *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;;
> +esac
> +
>  # Set INSTALL_SU if su installation has been requested via
>  # --enable-install-program=su.
>  AC_SUBST([INSTALL_SU])

Looks good Mike.
I'll apply that soon.

cheers,
Pádraig.

Message #13 received at 6673-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: 6673-done <at> debbugs.gnu.org
Subject: Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled
Date: Sun, 17 Apr 2011 11:15:13 +0200

Pádraig Brady wrote:
> On 20/07/10 01:51, Mike Frysinger wrote:
>> Currently, only main programs (like stdbuf) can be disabled at configure
>> time.  Helper programs (like libstdbuf.so) do not have a configure option.
>>
>> Even if you disable stdbuf with the configure option, libstdbuf.so will
>> still be compiled and installed.  So delay the parsing of helper programs
>> until after we know the final enable list, and then only build libstdbuf.so
>> when stdbuf is also enabled.
>>
>> Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
...
> Looks good Mike.
> I'll apply that soon.

Applied nearly a year ago.
Thanks.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.