GNU bug report logs - #6673
[PATCH] only build libstdbuf.so when stdbuf is enabled

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Meyering <jim <at> meyering.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#6673: closed ([PATCH] only build libstdbuf.so when stdbuf is
 enabled)
Date: Sun, 17 Apr 2011 09:16:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 17 Apr 2011 11:15:13 +0200
with message-id <87mxjpb5ni.fsf <at> rho.meyering.net>
and subject line Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled
has caused the GNU bug report #6673,
regarding [PATCH] only build libstdbuf.so when stdbuf is enabled
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
6673: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6673
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mike Frysinger <vapier <at> gentoo.org>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] only build libstdbuf.so when stdbuf is enabled
Date: Mon, 19 Jul 2010 20:51:38 -0400

Currently, only main programs (like stdbuf) can be disabled at configure
time.  Helper programs (like libstdbuf.so) do not have a configure option.

Even if you disable stdbuf with the configure option, libstdbuf.so will
still be compiled and installed.  So delay the parsing of helper programs
until after we know the final enable list, and then only build libstdbuf.so
when stdbuf is also enabled.

Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
---
 configure.ac |    9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index e7037a1..acd397e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -332,7 +332,6 @@ if test $gl_cv_list_mounted_fs = yes && test $gl_cv_fs_space = yes; then
 fi
 
 # Limit stdbuf to ELF systems with GCC
-optional_pkglib_progs=
 AC_MSG_CHECKING([whether this is an ELF system])
 AC_EGREP_CPP([yes], [#if __ELF__
 yes
@@ -341,7 +340,6 @@ AC_MSG_RESULT([$elf_sys])
 if test "$elf_sys" = "yes" && \
    test "$GCC" = "yes"; then
   gl_ADD_PROG([optional_bin_progs], [stdbuf])
-  gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so])
 fi
 
 ############################################################################
@@ -395,6 +393,13 @@ esac
 # corresponding ./configure option argument is comma-separated on input.
 gl_INCLUDE_EXCLUDE_PROG([optional_bin_progs], [arch,hostname,su])
 
+# Now that we know which programs will actually be built up, figure out
+# which optional helper progs should be compiled.
+optional_pkglib_progs=
+case " $optional_bin_progs " in
+  *' stdbuf '*) gl_ADD_PROG([optional_pkglib_progs], [libstdbuf.so]) ;;
+esac
+
 # Set INSTALL_SU if su installation has been requested via
 # --enable-install-program=su.
 AC_SUBST([INSTALL_SU])
-- 
1.7.1.1

[Message part 3 (message/rfc822, inline)]

From: Jim Meyering <jim <at> meyering.net>
To: 6673-done <at> debbugs.gnu.org
Subject: Re: bug#6673: [PATCH] only build libstdbuf.so when stdbuf is enabled
Date: Sun, 17 Apr 2011 11:15:13 +0200

Pádraig Brady wrote:
> On 20/07/10 01:51, Mike Frysinger wrote:
>> Currently, only main programs (like stdbuf) can be disabled at configure
>> time.  Helper programs (like libstdbuf.so) do not have a configure option.
>>
>> Even if you disable stdbuf with the configure option, libstdbuf.so will
>> still be compiled and installed.  So delay the parsing of helper programs
>> until after we know the final enable list, and then only build libstdbuf.so
>> when stdbuf is also enabled.
>>
>> Signed-off-by: Mike Frysinger <vapier <at> gentoo.org>
...
> Looks good Mike.
> I'll apply that soon.

Applied nearly a year ago.
Thanks.  Closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.