GNU bug report logs - #66673
[PATCH] Fix treesit-install-language-grammar recipe addition

Previous Next

Full log

Message #13 received at 66673 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: noah.v.peart <at> gmail.com, 66673 <at> debbugs.gnu.org
Subject: Re: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe
 addition
Date: Sun, 22 Oct 2023 08:15:02 +0300

> Resent-To: bug-gnu-emacs <at> gnu.org
> Cc: 66673-done <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 21 Oct 2023 20:40:52 -0700
> 
> 
> 
> > On Oct 21, 2023, at 8:09 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> > 
> > 
> > 
> > * lisp/treesit.el (treesit-install-language-grammar): fix recipe
> > addition to `treesit-language-source-alist`
> > 
> > Bug: `treesit-install-language-grammar` adds repeated language
> > entry to `treesit-language-source-alist` causing circular list.
> 
> Thank you! I applied the path on emacs-29.

Thanks.

Yuan, if we are fixing treesit-install-language-grammar, I think it
lacks the "-ltree-sitter" command-line option for the link command.
At least on MS-Windows, this is required, as the link command will
fail if we don't supply that option: the linker _must_ scan the
tree-sitter library when generating the shared library for the
grammar.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.