GNU bug report logs - #66673
[PATCH] Fix treesit-install-language-grammar recipe addition

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66673 in the body.
You can then email your comments to 66673 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: nvp <noah.v.peart <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix treesit-install-language-grammar recipe addition
Date: Sat, 21 Oct 2023 20:09:21 -0700

[Message part 1 (text/plain, inline)]

Tags: patch


* lisp/treesit.el (treesit-install-language-grammar): fix recipe
addition to `treesit-language-source-alist`

Bug: `treesit-install-language-grammar` adds repeated language
entry to `treesit-language-source-alist` causing circular list.

Recipe to reproduce:
1. `M-x treesit-install-language-grammar` `bash` (enter all defaults)
2. `M-x treesit-install-language-grammar` `bash`

In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version
3.24.33, cairo version 1.16.0) of 2023-10-21 built on noah-X580VD
Repository revision: 6f87ee0e3a0727e16079778a4264e6e35cd7f3a8
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101004
System Description: Ubuntu 22.04.3 LTS

Configured using:
 'configure --prefix=/usr/local --with-modules --with-tree-sitter
--with-threads --with-x-toolkit=gtk3 --with-xwidgets --with-gnutls
--with-json --with-mailutils --with-jpeg --with-png --with-rsvg
--with-tiff --with-xml2 --with-xpm --with-imagemagick CC=gcc-12
CXX=gcc-12'

[Message part 2 (text/html, inline)]

[fix-treesit-install.patch (text/x-patch, attachment)]

Message #10 received at 66673-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: nvp <noah.v.peart <at> gmail.com>
Cc: 66673-done <at> debbugs.gnu.org
Subject: Re: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe
 addition
Date: Sat, 21 Oct 2023 20:40:52 -0700

> On Oct 21, 2023, at 8:09 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> 
> 
> 
> * lisp/treesit.el (treesit-install-language-grammar): fix recipe
> addition to `treesit-language-source-alist`
> 
> Bug: `treesit-install-language-grammar` adds repeated language
> entry to `treesit-language-source-alist` causing circular list.

Thank you! I applied the path on emacs-29.

Yuan

Message #13 received at 66673 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: noah.v.peart <at> gmail.com, 66673 <at> debbugs.gnu.org
Subject: Re: bug#66673: [PATCH] Fix treesit-install-language-grammar recipe
 addition
Date: Sun, 22 Oct 2023 08:15:02 +0300

> Resent-To: bug-gnu-emacs <at> gnu.org
> Cc: 66673-done <at> debbugs.gnu.org
> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 21 Oct 2023 20:40:52 -0700
> 
> 
> 
> > On Oct 21, 2023, at 8:09 PM, nvp <noah.v.peart <at> gmail.com> wrote:
> > 
> > 
> > 
> > * lisp/treesit.el (treesit-install-language-grammar): fix recipe
> > addition to `treesit-language-source-alist`
> > 
> > Bug: `treesit-install-language-grammar` adds repeated language
> > entry to `treesit-language-source-alist` causing circular list.
> 
> Thank you! I applied the path on emacs-29.

Thanks.

Yuan, if we are fixing treesit-install-language-grammar, I think it
lacks the "-ltree-sitter" command-line option for the link command.
At least on MS-Windows, this is required, as the link command will
fail if we don't supply that option: the linker _must_ scan the
tree-sitter library when generating the shared library for the
grammar.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.