GNU bug report logs - #6656
24.0.50; Bugfix:gnus-summary-bookmark-make-record

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 16 Jul 2010 20:29:02 UTC

Severity: normal

Found in version 24.0.50

Done: Katsumi Yamaoka <yamaoka <at> jpl.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: bug#6656: closed (Re: bug#6656: 24.0.50; Bugfix:gnus-summary-bookmark-make-record)
Date: Tue, 20 Jul 2010 03:22:02 +0000

[Message part 1 (text/plain, inline)]
Your bug report

#6656: 24.0.50; Bugfix:gnus-summary-bookmark-make-record

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 6656 <at> debbugs.gnu.org.

-- 
6656: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6656
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 6656-done <at> debbugs.gnu.org
Subject: Re: bug#6656: 24.0.50; Bugfix:gnus-summary-bookmark-make-record
Date: Tue, 20 Jul 2010 12:21:36 +0900

Thierry Volpiatto wrote:
> Hi,
> just fix bug introduced in:

> ,----
>|    commit c20fb917f2a9b0597dc4f9b96d692393802192bf
>|    Commit: Katsumi Yamaoka <yamaoka <at> jpl.org>
>|    CommitDate: Thu Jul 15 00:56:13 2010 +0000
>|
>|       Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
>|
>|       2010-07-15  Katsumi Yamaoka  <yamaoka <at> jpl.org>
>|        * gnus-sum.el (gnus-summary-bookmark-make-record): Make it work for
>|        Emacs 23 as well.
> `----

> (bookmark-make-record-default 'no-file 'no-context pos)==> good
> (bookmark-make-record-default 'no-file 'no-context (point))==> bad

> When pos is set to (point) value, it is in gnus-art buffer, if you use
> (point) directly in bookmark-make-record-default, you use the value of
> point in the gnus-sum buffer, what is wrong.

Fixed.  Sorry for my mistake.


[Message part 3 (message/rfc822, inline)]
From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Bugfix:gnus-summary-bookmark-make-record
Date: Fri, 16 Jul 2010 22:25:55 +0200

[Message part 4 (text/plain, inline)]
Hi,
just fix bug introduced in:

,----
|    commit c20fb917f2a9b0597dc4f9b96d692393802192bf
|    Commit: Katsumi Yamaoka <yamaoka <at> jpl.org>
|    CommitDate: Thu Jul 15 00:56:13 2010 +0000
| 
|       Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
|       
|       2010-07-15  Katsumi Yamaoka  <yamaoka <at> jpl.org>
|        * gnus-sum.el (gnus-summary-bookmark-make-record): Make it work for
|        Emacs 23 as well.
`----

(bookmark-make-record-default 'no-file 'no-context pos)==> good
(bookmark-make-record-default 'no-file 'no-context (point))==> bad

When pos is set to (point) value, it is in gnus-art buffer, if you use
(point) directly in bookmark-make-record-default, you use the value of
point in the gnus-sum buffer, what is wrong.


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

[patch-r109443 (application/octet-stream, attachment)]
This bug report was last modified 15 years and 8 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.