GNU bug report logs - #6656
24.0.50; Bugfix:gnus-summary-bookmark-make-record

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Fri, 16 Jul 2010 20:29:02 UTC

Severity: normal

Found in version 24.0.50

Done: Katsumi Yamaoka <yamaoka <at> jpl.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6656 in the body.
You can then email your comments to 6656 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6656; Package emacs. (Fri, 16 Jul 2010 20:29:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Thierry Volpiatto <thierry.volpiatto <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 16 Jul 2010 20:29:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Bugfix:gnus-summary-bookmark-make-record
Date: Fri, 16 Jul 2010 22:25:55 +0200

[Message part 1 (text/plain, inline)]
Hi,
just fix bug introduced in:

,----
|    commit c20fb917f2a9b0597dc4f9b96d692393802192bf
|    Commit: Katsumi Yamaoka <yamaoka <at> jpl.org>
|    CommitDate: Thu Jul 15 00:56:13 2010 +0000
| 
|       Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
|       
|       2010-07-15  Katsumi Yamaoka  <yamaoka <at> jpl.org>
|        * gnus-sum.el (gnus-summary-bookmark-make-record): Make it work for
|        Emacs 23 as well.
`----

(bookmark-make-record-default 'no-file 'no-context pos)==> good
(bookmark-make-record-default 'no-file 'no-context (point))==> bad

When pos is set to (point) value, it is in gnus-art buffer, if you use
(point) directly in bookmark-make-record-default, you use the value of
point in the gnus-sum buffer, what is wrong.


-- 
Thierry Volpiatto
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

[patch-r109443 (application/octet-stream, attachment)]
Reply sent to Katsumi Yamaoka <yamaoka <at> jpl.org>:
You have taken responsibility. (Tue, 20 Jul 2010 03:22:02 GMT) Full text and rfc822 format available.
Notification sent to Thierry Volpiatto <thierry.volpiatto <at> gmail.com>:
bug acknowledged by developer. (Tue, 20 Jul 2010 03:22:02 GMT) Full text and rfc822 format available.

Message #10 received at 6656-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 6656-done <at> debbugs.gnu.org
Subject: Re: bug#6656: 24.0.50; Bugfix:gnus-summary-bookmark-make-record
Date: Tue, 20 Jul 2010 12:21:36 +0900

Thierry Volpiatto wrote:
> Hi,
> just fix bug introduced in:

> ,----
>|    commit c20fb917f2a9b0597dc4f9b96d692393802192bf
>|    Commit: Katsumi Yamaoka <yamaoka <at> jpl.org>
>|    CommitDate: Thu Jul 15 00:56:13 2010 +0000
>|
>|       Make gnus-summary-bookmark-make-record work for Emacs 23 as well.
>|
>|       2010-07-15  Katsumi Yamaoka  <yamaoka <at> jpl.org>
>|        * gnus-sum.el (gnus-summary-bookmark-make-record): Make it work for
>|        Emacs 23 as well.
> `----

> (bookmark-make-record-default 'no-file 'no-context pos)==> good
> (bookmark-make-record-default 'no-file 'no-context (point))==> bad

> When pos is set to (point) value, it is in gnus-art buffer, if you use
> (point) directly in bookmark-make-record-default, you use the value of
> point in the gnus-sum buffer, what is wrong.

Fixed.  Sorry for my mistake.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 17 Aug 2010 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 7 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.