GNU bug report logs - #66556
30.0.50; Missing choice in eglot-report-progress :type

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Sun, 15 Oct 2023 13:42:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#66556: closed (30.0.50; Missing choice in eglot-report-progress
 :type)
Date: Sat, 21 Oct 2023 10:08:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sat, 21 Oct 2023 03:06:49 -0700
with message-id <CADwFkmkxesZ4Dy5v9T1ADKj3OyAfC-YUwOvXEPyysv63KduMqg <at> mail.gmail.com>
and subject line Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
has caused the debbugs.gnu.org bug report #66556,
regarding 30.0.50; Missing choice in eglot-report-progress :type
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
66556: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66556
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 10:40:30 -0300
The docstring for eglot-report-progress says it value may be messages,
but its :type is just boolean.



[Message part 3 (message/rfc822, inline)]
From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>, 66556-done <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sat, 21 Oct 2023 03:06:49 -0700
Version: 30.1

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> There's no sign of eglot-handle-notification checking for a value of
> messages in eglot-report-progress in emacs-29.  So I don't think
> anything needs to be changed there.  Of course, João would know better.

Thanks, so I installed the patch on master.

[1: cb89cbc406e]: 2023-10-21 12:05:31 +0200
  Fix eglot-report-progress :type
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb89cbc406efeeadbb46eb6f4d81827c7c2caf94


This bug report was last modified 1 year and 209 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.