GNU bug report logs - #66556
30.0.50; Missing choice in eglot-report-progress :type

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Sun, 15 Oct 2023 13:42:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Fixed in version 30.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66556 in the body.
You can then email your comments to 66556 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#66556; Package emacs. (Sun, 15 Oct 2023 13:42:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 15 Oct 2023 13:42:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 10:40:30 -0300

The docstring for eglot-report-progress says it value may be messages,
but its :type is just boolean.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66556; Package emacs. (Sun, 15 Oct 2023 13:47:01 GMT) Full text and rfc822 format available.

Message #8 received at 66556 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 66556 <at> debbugs.gnu.org
Subject: Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 10:45:42 -0300

[Message part 1 (text/plain, inline)]
tags 66556 patch
quit


Patch attached.

[0001-Fix-eglot-report-progress-type.patch (text/x-patch, attachment)]
Added tag(s) patch. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Sun, 15 Oct 2023 13:47:02 GMT) Full text and rfc822 format available.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66556; Package emacs. (Sun, 15 Oct 2023 14:25:01 GMT) Full text and rfc822 format available.

Message #13 received at 66556 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>, 66556 <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 07:24:11 -0700

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> Patch attached.

Thanks, but this patch is against master, right?  Should it be fixed in
emacs-29 as well?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66556; Package emacs. (Sun, 15 Oct 2023 15:02:02 GMT) Full text and rfc822 format available.

Message #16 received at 66556 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>, 66556 <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sun, 15 Oct 2023 12:00:30 -0300

On 15/10/23 11:24, Stefan Kangas wrote:
> Mauro Aranda <maurooaranda <at> gmail.com> writes:
>
>> Patch attached.
>
> Thanks, but this patch is against master, right?

Right.

> Should it be fixed in emacs-29 as well?

There's no sign of eglot-handle-notification checking for a value of
messages in eglot-report-progress in emacs-29.  So I don't think
anything needs to be changed there.  Of course, João would know better.
Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sat, 21 Oct 2023 10:08:02 GMT) Full text and rfc822 format available.
Notification sent to Mauro Aranda <maurooaranda <at> gmail.com>:
bug acknowledged by developer. (Sat, 21 Oct 2023 10:08:02 GMT) Full text and rfc822 format available.

Message #21 received at 66556-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Mauro Aranda <maurooaranda <at> gmail.com>, 66556-done <at> debbugs.gnu.org
Cc: João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#66556: 30.0.50; Missing choice in eglot-report-progress :type
Date: Sat, 21 Oct 2023 03:06:49 -0700

Version: 30.1

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> There's no sign of eglot-handle-notification checking for a value of
> messages in eglot-report-progress in emacs-29.  So I don't think
> anything needs to be changed there.  Of course, João would know better.

Thanks, so I installed the patch on master.

[1: cb89cbc406e]: 2023-10-21 12:05:31 +0200
  Fix eglot-report-progress :type
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=cb89cbc406efeeadbb46eb6f4d81827c7c2caf94
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 Nov 2023 12:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 208 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.