GNU bug report logs - #66520
30.0.50; Small issues with defcustoms in ERC

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mauro Aranda <maurooaranda <at> gmail.com>
Subject: bug#66520: closed (Re: bug#66520: 30.0.50; Small issues with
 defcustoms in ERC)
Date: Fri, 13 Oct 2023 15:06:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#66520: 30.0.50; Small issues with defcustoms in ERC

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 66520 <at> debbugs.gnu.org.

-- 
66520: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=66520
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "J.P." <jp <at> neverwas.me>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 66520-done <at> debbugs.gnu.org
Subject: Re: bug#66520: 30.0.50; Small issues with defcustoms in ERC
Date: Fri, 13 Oct 2023 08:04:48 -0700

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> tags 66520 patch
> quit
>
>
> I attach a patch to fix these issues.

Appreciate the diligence!

>  Maybe I'm wrong about changing the docstring in erc-networks-alist.

Nah, I couldn't find any sign of the function variant being considered
in the 18+ years since the file was first introduced to the old CVS
repo.

I've added this as

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=baf778c7

Thanks and closing.

[Message part 3 (message/rfc822, inline)]

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Small issues with defcustoms in ERC
Date: Fri, 13 Oct 2023 10:33:08 -0300

Looking for defcustom docstrings and :type inconsistencies, I found the
following in erc/:

The docstring of erc-fill-variable-maximum-indentation says its value
can be nil, but its :type is just integer.

The choices in erc-keep-place-indicator-style look like a copy-pasta
from erc-keep-place-indicator-buffer-type.  The docstring matches what
the code checks, so I guess the choices are wrong.

Finally, erc-networks-alist says that MATCHER can be either a regexp or
a function.  But neither erc-determine-network (obsoleted) nor
erc-networks--determine check to see if MATCHER is a function. So maybe
that isn't supported?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.