GNU bug report logs - #66520
30.0.50; Small issues with defcustoms in ERC

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Fri, 13 Oct 2023 13:34:02 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: "J.P." <jp <at> neverwas.me>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 66520 in the body.
You can then email your comments to 66520 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#66520; Package emacs. (Fri, 13 Oct 2023 13:34:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Mauro Aranda <maurooaranda <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 13 Oct 2023 13:34:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Small issues with defcustoms in ERC
Date: Fri, 13 Oct 2023 10:33:08 -0300

Looking for defcustom docstrings and :type inconsistencies, I found the
following in erc/:

The docstring of erc-fill-variable-maximum-indentation says its value
can be nil, but its :type is just integer.

The choices in erc-keep-place-indicator-style look like a copy-pasta
from erc-keep-place-indicator-buffer-type.  The docstring matches what
the code checks, so I guess the choices are wrong.

Finally, erc-networks-alist says that MATCHER can be either a regexp or
a function.  But neither erc-determine-network (obsoleted) nor
erc-networks--determine check to see if MATCHER is a function. So maybe
that isn't supported?
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#66520; Package emacs. (Fri, 13 Oct 2023 13:39:01 GMT) Full text and rfc822 format available.

Message #8 received at 66520 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 66520 <at> debbugs.gnu.org
Subject: Re: bug#66520: 30.0.50; Small issues with defcustoms in ERC
Date: Fri, 13 Oct 2023 10:37:44 -0300

[Message part 1 (text/plain, inline)]
tags 66520 patch
quit


I attach a patch to fix these issues.  Maybe I'm wrong about changing
the docstring in erc-networks-alist.
[0001-More-defcustom-fixes-in-ERC-Bug-66520.patch (text/x-patch, attachment)]
Added tag(s) patch. Request was from Mauro Aranda <maurooaranda <at> gmail.com> to control <at> debbugs.gnu.org. (Fri, 13 Oct 2023 13:39:02 GMT) Full text and rfc822 format available.
Reply sent to "J.P." <jp <at> neverwas.me>:
You have taken responsibility. (Fri, 13 Oct 2023 15:06:02 GMT) Full text and rfc822 format available.
Notification sent to Mauro Aranda <maurooaranda <at> gmail.com>:
bug acknowledged by developer. (Fri, 13 Oct 2023 15:06:03 GMT) Full text and rfc822 format available.

Message #15 received at 66520-done <at> debbugs.gnu.org (full text, mbox):

From: "J.P." <jp <at> neverwas.me>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: emacs-erc <at> gnu.org, 66520-done <at> debbugs.gnu.org
Subject: Re: bug#66520: 30.0.50; Small issues with defcustoms in ERC
Date: Fri, 13 Oct 2023 08:04:48 -0700

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> tags 66520 patch
> quit
>
>
> I attach a patch to fix these issues.

Appreciate the diligence!

>  Maybe I'm wrong about changing the docstring in erc-networks-alist.

Nah, I couldn't find any sign of the function variant being considered
in the 18+ years since the file was first introduced to the old CVS
repo.

I've added this as

  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=baf778c7

Thanks and closing.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 11 Nov 2023 12:24:08 GMT) Full text and rfc822 format available.
This bug report was last modified 1 year and 314 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.