GNU bug report logs - #6635
mouse-yank-primary/secondary and unicode from other apps.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6635 in the body.
You can then email your comments to 6635 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David De La Harpe Golden <david <at> harpegolden.net>
To: bug-gnu-emacs <at> gnu.org
Subject: mouse-yank-primary/secondary and unicode from other apps.
Date: Thu, 15 Jul 2010 01:38:11 +0100

[Message part 1 (text/plain, inline)]

mouse-yank-primary and mouse-yank-secondary don't like
inserting non-ascii chars from other apps.

They need to use the slightly higher-level
(x-selection-value 'PRIMARY)

or at least give a 'TEXT arg to their
(x-get-selection 'PRIMARY 'TEXT),

so that the proper kinds of selection type are tried
as e.g. attached.

[myp-encode_r1.diff (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6635: mouse-yank-primary/secondary and unicode from other
	apps.
Date: Wed, 14 Jul 2010 23:29:11 -0600

David De La Harpe Golden wrote:
> mouse-yank-primary and mouse-yank-secondary don't like
> inserting non-ascii chars from other apps.
> 
> They need to use the slightly higher-level
> (x-selection-value 'PRIMARY)
> 
> or at least give a 'TEXT arg to their
> (x-get-selection 'PRIMARY 'TEXT),
> 
> so that the proper kinds of selection type are tried
> as e.g. attached.
...
-  (let ((primary (x-get-selection 'PRIMARY)))
+  (let ((primary (x-selection-value 'PRIMARY)))
     (if primary
-        (insert (x-get-selection 'PRIMARY))
+        (insert (x-selection-value 'PRIMARY))
       (error "No primary selection"))))
...
-  (let ((secondary (x-get-selection 'SECONDARY)))
+  (let ((secondary (x-selection-value 'SECONDARY)))
     (if secondary
-        (insert (x-get-selection 'SECONDARY))
+        (insert (x-selection-value 'SECONDARY))
       (error "No secondary selection"))))

Can someone explain why the result of x-get-selection/x-selection-value
is bound to a variable, but instead of referencing the variable in the
insert function call the expression is evaluated again?  I.e. why not
change it to:

 (let ((primary (x-selection-value 'PRIMARY)))
   (if primary
       (insert primary)
     (error "No primary selection"))))
...
 (let ((secondary (x-selection-value 'SECONDARY)))
   (if secondary
       (insert secondary)
     (error "No secondary selection"))))

Thanks,

-- 
Kevin Rodgers
Denver, Colorado, USA

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: David De La Harpe Golden <david <at> harpegolden.net>
To: Kevin Rodgers <kevin.d.rodgers <at> gmail.com>
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#6635: mouse-yank-primary/secondary and unicode from other
	apps.
Date: Sun, 18 Jul 2010 17:39:41 +0100

On 15/07/10 06:29, Kevin Rodgers wrote:

> Can someone explain why the result of x-get-selection/x-selection-value
> is bound to a variable, but instead of referencing the variable in the
> insert function call the expression is evaluated again? I.e. why not
> change it to:
>

I don't know anyway; you're likely quite right - in fact wouldn't there 
be a race the other way? I think the selection could (at least in 
principle) vanish in between the two calls if another app owns it...

> (let ((primary (x-selection-value 'PRIMARY)))
> (if primary
> (insert primary)
> (error "No primary selection"))))
> ...
> (let ((secondary (x-selection-value 'SECONDARY)))
> (if secondary
> (insert secondary)
> (error "No secondary selection"))))
>
> Thanks,
>

Message #14 received at 6635 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: david <at> harpegolden.net
Cc: 6720 <at> debbugs.gnu.org, 6635 <at> debbugs.gnu.org
Subject: Re: battle with x-clipboard vs. Chinese
Date: Sun, 25 Jul 2010 09:08:58 +0800

>>>>> "DDLHG" == David De La Harpe Golden <david <at> harpegolden.net> writes:

DDLHG> On 24/07/10 18:36, jidanni <at> jidanni.org wrote:
>> I just updated to
>> emacs-snapshot:
>> Installed: 1:20100724-1
>> and am having to battle getting Chinese in correctly from the X
>> clipboard.
>> It is turning into ###, ???, \u{5432}, etc. etc.
>> 

DDLHG> Do you see this when using middle mouse button or C-y or both?

All I know is starting with 
   $ apt-cache policy emacs-snapshot 
   emacs-snapshot:
     Installed: 1:20100724-1
     Candidate: 1:20100724-1
     Version table:
    *** 1:20100724-1 0
           500 http://emacs.orebokech.com sid/main Packages
           100 /var/lib/dpkg/status

I am having two kinds of pain:

1. Having to write things into /tmp/files to be able to read them into
emacs correctly as xclip now can't if I want Chinese intact.
I try every button and end up having to resort to /tmp.


2. Even more disconnection between C-y, Shift-insert, the middle mouse
button, between emacs and the outside world. I wish I could make them
all connected.

DDLHG> This sounds like it might be bug #6635, an encoding handling problem
DDLHG> in mouse-yank-primary, which could affect people more due to recent
DDLHG> changes:

DDLHG> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6635

Message #17 received at 6635 <at> debbugs.gnu.org (full text, mbox):

From: jidanni <at> jidanni.org
To: david <at> harpegolden.net
Cc: 6720 <at> debbugs.gnu.org, 6635 <at> debbugs.gnu.org
Subject: Re: battle with x-clipboard vs. Chinese
Date: Sun, 25 Jul 2010 09:28:20 +0800

And the most scary thing of all is now things that I kill with C-k in
emacs are not necessarily what Shift-Insert will now paste in xterm.
That has never happened before and is causing me to send dangers wads of
text of some previous yank to the shell.

Message #20 received at 6635 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: David De La Harpe Golden <david <at> harpegolden.net>
Cc: 6635 <at> debbugs.gnu.org
Subject: Re: bug#6635: mouse-yank-primary/secondary and unicode from other
	apps.
Date: Thu, 06 Oct 2011 17:42:11 -0400

David De La Harpe Golden wrote:

> mouse-yank-primary and mouse-yank-secondary don't like
> inserting non-ascii chars from other apps.

Is this still an issue?

I copied some non-ASCII chars in firefox and pasted them to the current
Emacs trunk with no problem.

Message #23 received at 6635 <at> debbugs.gnu.org (full text, mbox):

From: David De La Harpe Golden <david <at> harpegolden.net>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 6635 <at> debbugs.gnu.org
Subject: Re: bug#6635: mouse-yank-primary/secondary and unicode from other
	apps.
Date: Fri, 07 Oct 2011 00:17:23 +0100

On 06/10/11 22:42, Glenn Morris wrote:
> David De La Harpe Golden wrote:
>
>> mouse-yank-primary and mouse-yank-secondary don't like
>> inserting non-ascii chars from other apps.
>
> Is this still an issue?
>
> I copied some non-ASCII chars in firefox and pasted them to the current
> Emacs trunk with no problem.

I think this got fixed in trunk by Jan D. under #6802 and closing this 
report was overlooked. And it appears to be fixed for both primary and 
secondary, just tested in case.

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6802#40

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.