GNU bug report logs - #6620
24.0.50; define-minor-mode has no initial-value keyword

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Lawrence Mitchell <wence <at> gmx.li>
Subject: bug#6620: closed (Re: bug#6620: 24.0.50; define-minor-mode has no
 initial-value keyword)
Date: Thu, 22 Jul 2010 11:13:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#6620: 24.0.50; define-minor-mode has no initial-value keyword

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 6620 <at> debbugs.gnu.org.

-- 
6620: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=6620
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Lawrence Mitchell <wence <at> gmx.li>
Cc: 6620-done <at> debbugs.gnu.org
Subject: Re: bug#6620: 24.0.50; define-minor-mode has no initial-value keyword
Date: Thu, 22 Jul 2010 13:12:29 +0200

> Patch is simple:

> -  :global t :initial-value (= (frame-width) 132)
> +  :global t :init-value (= (frame-width) 132)

Committed, thanks.

    Juanma

[Message part 3 (message/rfc822, inline)]

From: Lawrence Mitchell <wence <at> gmx.li>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; define-minor-mode has no initial-value keyword
Date: Mon, 12 Jul 2010 18:21:52 +0100

Hi there,

This change:

2010-05-03  Stefan Monnier  <monnier <at> iro.umontreal.ca>

       Use define-minor-mode where applicable.

Introduced an erroneous :initial-value keyword into the definition of
vt100-wide-mode.  The correct keyword is :init-value.

Patch is simple:

diff --git a/lisp/term/vt100.el b/lisp/term/vt100.el
index 017c976..24561fe 100644
--- a/lisp/term/vt100.el
+++ b/lisp/term/vt100.el
@@ -45,7 +45,7 @@
   "Toggle 132/80 column mode for vt100s.
 With positive argument, switch to 132-column mode.
 With negative argument, switch to 80-column mode."
-  :global t :initial-value (= (frame-width) 132)
+  :global t :init-value (= (frame-width) 132)
   (send-string-to-terminal (if vt100-wide-mode "\e[?3h" "\e[?3l"))
   (set-frame-width terminal-frame (if vt100-wide-mode 132 80)))



Cheers,
Lawrence

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.