GNU bug report logs - #6620
24.0.50; define-minor-mode has no initial-value keyword

Previous Next

Package: emacs;

Reported by: Lawrence Mitchell <wence <at> gmx.li>

Date: Mon, 12 Jul 2010 17:26:01 UTC

Severity: normal

Found in version 24.0.50

Done: Juanma Barranquero <lekktu <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6620 in the body.
You can then email your comments to 6620 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org:
bug#6620; Package emacs. (Mon, 12 Jul 2010 17:26:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Lawrence Mitchell <wence <at> gmx.li>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 12 Jul 2010 17:26:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lawrence Mitchell <wence <at> gmx.li>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; define-minor-mode has no initial-value keyword
Date: Mon, 12 Jul 2010 18:21:52 +0100

Hi there,

This change:

2010-05-03  Stefan Monnier  <monnier <at> iro.umontreal.ca>

       Use define-minor-mode where applicable.

Introduced an erroneous :initial-value keyword into the definition of
vt100-wide-mode.  The correct keyword is :init-value.

Patch is simple:

diff --git a/lisp/term/vt100.el b/lisp/term/vt100.el
index 017c976..24561fe 100644
--- a/lisp/term/vt100.el
+++ b/lisp/term/vt100.el
@@ -45,7 +45,7 @@
   "Toggle 132/80 column mode for vt100s.
 With positive argument, switch to 132-column mode.
 With negative argument, switch to 80-column mode."
-  :global t :initial-value (= (frame-width) 132)
+  :global t :init-value (= (frame-width) 132)
   (send-string-to-terminal (if vt100-wide-mode "\e[?3h" "\e[?3l"))
   (set-frame-width terminal-frame (if vt100-wide-mode 132 80)))



Cheers,
Lawrence
Reply sent to Juanma Barranquero <lekktu <at> gmail.com>:
You have taken responsibility. (Thu, 22 Jul 2010 11:13:02 GMT) Full text and rfc822 format available.
Notification sent to Lawrence Mitchell <wence <at> gmx.li>:
bug acknowledged by developer. (Thu, 22 Jul 2010 11:13:02 GMT) Full text and rfc822 format available.

Message #10 received at 6620-done <at> debbugs.gnu.org (full text, mbox):

From: Juanma Barranquero <lekktu <at> gmail.com>
To: Lawrence Mitchell <wence <at> gmx.li>
Cc: 6620-done <at> debbugs.gnu.org
Subject: Re: bug#6620: 24.0.50; define-minor-mode has no initial-value keyword
Date: Thu, 22 Jul 2010 13:12:29 +0200

> Patch is simple:

> -  :global t :initial-value (= (frame-width) 132)
> +  :global t :init-value (= (frame-width) 132)

Committed, thanks.

    Juanma
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 19 Aug 2010 11:24:03 GMT) Full text and rfc822 format available.
This bug report was last modified 15 years and 22 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.