GNU bug report logs - #66171
[PATCH] gnu: git: Install shell completions.

Previous Next

Package: guix-patches;

Reported by: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Date: Sat, 23 Sep 2023 19:46:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #26 received at 66171 <at> debbugs.gnu.org (full text, mbox):

From: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
To: 66171 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>,
 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>,
 Simon Tournier <zimon.toutoune <at> gmail.com>
Subject: [PATCH v3] gnu: git: Install zsh completions and git-prompt.
Date: Sat, 23 Sep 2023 21:43:07 +0200
* gnu/packages/version-control.scm (git)[#:phases]<install-shell-completion>:
Also install git-prompt and zsh _git site function.
---
 gnu/packages/version-control.scm | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 9716a6f27a..d8c9bf4009 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -448,12 +448,17 @@ (define-public git
                      "DOCBOOK2X_TEXI=docbook2texi" "PERL_PATH=perl")))
          (add-after 'install 'install-shell-completion
            (lambda* (#:key outputs #:allow-other-keys)
-             (let* ((out         (assoc-ref outputs "out"))
-                    (completions (string-append out "/etc/bash_completion.d")))
-               ;; TODO: Install the tcsh and zsh completions in the right place.
-               (mkdir-p completions)
+             (let* ((out  (assoc-ref outputs "out"))
+                    (bash (string-append out "/etc/bash_completion.d"))
+                    (zsh  (string-append out "/share/zsh/site-functions")))
+               ;; TODO: Install the tcsh completions in the right place.
+               (for-each mkdir-p (list bash zsh))
                (copy-file "contrib/completion/git-completion.bash"
-                          (string-append completions "/git")))))
+                          (string-append bash "/git"))
+               (copy-file "contrib/completion/git-prompt.sh"
+                          (string-append out "/bin/git-prompt"))
+               (copy-file "contrib/completion/git-completion.zsh"
+                          (string-append zsh "/_git")))))
          (add-after 'install 'install-credential-netrc
            (lambda* (#:key outputs #:allow-other-keys)
              (let* ((netrc (assoc-ref outputs "credential-netrc")))

base-commit: ce0cc6137df81919389f61671096a6ce701c0889
prerequisite-patch-id: ee5d7299c5790d77e0d409f34165063fcff10a8b
prerequisite-patch-id: 369548fa905a48e7e2164ca4b6c9897e392a5025
prerequisite-patch-id: 7650e691c505ecc63e3b1a1265b3cb3a2869443e
prerequisite-patch-id: 5e7e47f338fa42c4f5c654a803f062b5e3f757a6
-- 
2.41.0





This bug report was last modified 1 year and 222 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.